From: Sabrina Dubroca <sd@queasysnail.net>
To: Marek Mietus <mmietus97@yahoo.com>
Cc: netdev@vger.kernel.org, kuba@kernel.org, Jason@zx2c4.com
Subject: Re: [PATCH net-next v7 04/11] net: tunnel: allow noref dsts in udp_tunnel{,6}_dst_lookup
Date: Fri, 30 Jan 2026 01:56:21 +0100 [thread overview]
Message-ID: <aXwBtY4tLDfO5rR4@krikkit> (raw)
In-Reply-To: <20260127070452.6581-5-mmietus97@yahoo.com>
2026-01-27, 08:04:45 +0100, Marek Mietus wrote:
> Update udp_tunnel{,6}_dst_lookup to return noref dsts when possible.
> This is done using a new boolean which indicates whether the returned
> dst is noref. When the returned dst is noref, the dst is only valid
> inside the RCU read-side critical section in which it was queried.
>
> Update all callers to properly use the new noref argument and convert
> all tunnels that use udp_tunnel{,6}_dst_lookup to noref. This affects
> bareudp, geneve and vxlan tunnels.
Maybe I'm missing something, but after this, all users of
udp_tunnel{,6}_dst_lookup need to be able to handle a noref dst? If
so, can we avoid the "if (!noref) release()" dance in all callers by
doing the release() before returning from _lookup()? The conditional
dst_release/ip_rt_put in this patch and some of the others feels
pretty ugly to me.
--
Sabrina
next prev parent reply other threads:[~2026-01-30 0:56 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260127070452.6581-1-mmietus97.ref@yahoo.com>
2026-01-27 7:04 ` [PATCH net-next v7 00/11] net: tunnel: introduce noref xmit flows for tunnels Marek Mietus
2026-01-27 7:04 ` [PATCH net-next v7 01/11] net: dst_cache: add noref versions for dst_cache Marek Mietus
2026-01-27 7:04 ` [PATCH net-next v7 02/11] net: tunnel: convert iptunnel_xmit to noref Marek Mietus
2026-02-03 8:21 ` Paolo Abeni
2026-02-04 16:52 ` Marek Mietus
2026-01-27 7:04 ` [PATCH net-next v7 03/11] net: tunnel: convert udp_tunnel{6,}_xmit_skb " Marek Mietus
2026-01-27 7:04 ` [PATCH net-next v7 04/11] net: tunnel: allow noref dsts in udp_tunnel{,6}_dst_lookup Marek Mietus
2026-01-30 0:56 ` Sabrina Dubroca [this message]
2026-01-27 7:04 ` [PATCH net-next v7 05/11] net: ovpn: convert ovpn_udp{4,6}_output to use a noref dst Marek Mietus
2026-01-27 7:04 ` [PATCH net-next v7 06/11] wireguard: socket: convert send{4,6} to use a noref dst when possible Marek Mietus
2026-01-27 7:04 ` [PATCH net-next v7 07/11] net: tunnel: convert ip_md_tunnel_xmit " Marek Mietus
2026-02-03 8:27 ` Paolo Abeni
2026-01-27 7:04 ` [PATCH net-next v7 08/11] net: tunnel: convert ip_tunnel_xmit " Marek Mietus
2026-01-27 7:04 ` [PATCH net-next v7 09/11] net: sctp: convert sctp_v{4,6}_xmit " Marek Mietus
2026-01-27 7:04 ` [PATCH net-next v7 10/11] net: sit: convert ipip6_tunnel_xmit to use a noref dst Marek Mietus
2026-01-27 7:04 ` [PATCH net-next v7 11/11] net: tipc: convert tipc_udp_xmit " Marek Mietus
2026-02-03 8:32 ` [PATCH net-next v7 00/11] net: tunnel: introduce noref xmit flows for tunnels Paolo Abeni
2026-02-12 14:47 ` Marek Mietus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aXwBtY4tLDfO5rR4@krikkit \
--to=sd@queasysnail.net \
--cc=Jason@zx2c4.com \
--cc=kuba@kernel.org \
--cc=mmietus97@yahoo.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox