From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fout-b3-smtp.messagingengine.com (fout-b3-smtp.messagingengine.com [202.12.124.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4A72E2DFF28 for ; Fri, 30 Jan 2026 00:56:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=202.12.124.146 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769734589; cv=none; b=Hn15QlNe0+WyJ7X5gn58bdVlP7n5nFAeXU6Bhqu4LlWezydbgmHXtbFhxKuOf4igKKIKEDwFc1u4wtHkz8HBQDnn96e1JxkThWN4l7847j16dG7rQLnUUUbX7jMeELOrQbNtUDkT18sfkiOofNAFqxSRSNGQX0fTxxRhhbk/CBA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769734589; c=relaxed/simple; bh=P7EKM3EHqhvyDvJfZgxgHylSj6bn0or2aJf4wK9Zvmo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=tDeMC1uae8XfJoBLfZf/Kao01FQCoCkvlAi9ecG+bqyn3WOGPEGGGtCSjj6JFcEiCBZsOmoRyO/K/zlALR29PdScPnk7XrF3evixL/reYFku/rNbUz7A2UIhOAAoAwoO0K/WpXItazV3vR6WAXagL43JeXn4kW7hrFh3xG1sZrs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=queasysnail.net; spf=pass smtp.mailfrom=queasysnail.net; dkim=pass (2048-bit key) header.d=queasysnail.net header.i=@queasysnail.net header.b=H3NVM6uZ; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=ms17JHqF; arc=none smtp.client-ip=202.12.124.146 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=queasysnail.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=queasysnail.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=queasysnail.net header.i=@queasysnail.net header.b="H3NVM6uZ"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="ms17JHqF" Received: from phl-compute-02.internal (phl-compute-02.internal [10.202.2.42]) by mailfout.stl.internal (Postfix) with ESMTP id 1495F1D0013C; Thu, 29 Jan 2026 19:56:25 -0500 (EST) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-02.internal (MEProxy); Thu, 29 Jan 2026 19:56:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=queasysnail.net; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm1; t=1769734584; x= 1769820984; bh=x/IqoU/bRE+m2Myo+HJJkiQw1QN64LOGc3GgRY85x5Y=; b=H 3NVM6uZRD2dW8pV0bshrN+eX3nb3VdBJLn6lgN+gd/Ix9x5E/kSWichSMxP/Yhes wBtRAINiivg583wQYv6MqUEE9sG2HJnnVr/VE3hJPc1SG5BK0i6qBvwNm1gqpVqf 8daHDBkn54H8cSMpTOm4kph+4R33x1SE3nH5aGmdPgKSQCfFM82cz9xJ3mlyXH6N JpEzAAHk2WWeGbhO7fWUGRjXinf6JNCwy9O6UHRRtWcrx8+gbMvypt9Vac7oavjj X00ZMOfzl+qP4X6wUfT3xjQsCOAEhyD/PQ/oXm7EVtTkG7lXbnHtGZu+91Yo9QRl KcUxW8S+fi7mFWeZ3IgUQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1769734584; x=1769820984; bh=x/IqoU/bRE+m2Myo+HJJkiQw1QN64LOGc3G gRY85x5Y=; b=ms17JHqFReOuUEAzAv5mkdidoT01QHoOsCUl+8xFWqdjqdOtbT4 4plo8pXiZQLNIiOrwbonoAusSEAhr2unhmxHrYeOvyQTndrQI9JnfH6jkDGnVu0r s2Alw4VA+rtPlMHBTsT3/9v/6WZimYKHVkHiqv/Bf0VkgZqY+PDdJ3xxQOL7g8aj zPHH51sv9bwo0MDY8CjCau9d8BVC6u9bOgffhD124xqEfHgOoe8o0S0g08ZmWs20 CltxRJSXDSElKY8xNfoinxAjbmgse/g8X6YzQvAqILgG5PPt4QEpr9Cwt/R87bhv Ekdpo79+ht2J4KvFvpa05T0UyMFwmqaJ9DQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefgedrtddtgdduieejieekucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhepfffhvfevuffkfhggtggujgesthdtredttddtjeenucfhrhhomhepufgrsghrihhn rgcuffhusghrohgtrgcuoehsugesqhhuvggrshihshhnrghilhdrnhgvtheqnecuggftrf grthhtvghrnhepuefhhfffgfffhfefueeiudegtdefhfekgeetheegheeifffguedvueff fefgudffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh epshgusehquhgvrghshihsnhgrihhlrdhnvghtpdhnsggprhgtphhtthhopeegpdhmohgu vgepshhmthhpohhuthdprhgtphhtthhopehmmhhivghtuhhsleejseihrghhohhordgtoh hmpdhrtghpthhtohepnhgvthguvghvsehvghgvrhdrkhgvrhhnvghlrdhorhhgpdhrtghp thhtohepkhhusggrsehkvghrnhgvlhdrohhrghdprhgtphhtthhopehjrghsohhnseiigi dvtgegrdgtohhm X-ME-Proxy: Feedback-ID: i934648bf:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 29 Jan 2026 19:56:23 -0500 (EST) Date: Fri, 30 Jan 2026 01:56:21 +0100 From: Sabrina Dubroca To: Marek Mietus Cc: netdev@vger.kernel.org, kuba@kernel.org, Jason@zx2c4.com Subject: Re: [PATCH net-next v7 04/11] net: tunnel: allow noref dsts in udp_tunnel{,6}_dst_lookup Message-ID: References: <20260127070452.6581-1-mmietus97@yahoo.com> <20260127070452.6581-5-mmietus97@yahoo.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260127070452.6581-5-mmietus97@yahoo.com> 2026-01-27, 08:04:45 +0100, Marek Mietus wrote: > Update udp_tunnel{,6}_dst_lookup to return noref dsts when possible. > This is done using a new boolean which indicates whether the returned > dst is noref. When the returned dst is noref, the dst is only valid > inside the RCU read-side critical section in which it was queried. > > Update all callers to properly use the new noref argument and convert > all tunnels that use udp_tunnel{,6}_dst_lookup to noref. This affects > bareudp, geneve and vxlan tunnels. Maybe I'm missing something, but after this, all users of udp_tunnel{,6}_dst_lookup need to be able to handle a noref dst? If so, can we avoid the "if (!noref) release()" dance in all callers by doing the release() before returning from _lookup()? The conditional dst_release/ip_rt_put in this patch and some of the others feels pretty ugly to me. -- Sabrina