From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Maxime Chevallier <maxime.chevallier@bootlin.com>
Cc: davem@davemloft.net, "Andrew Lunn" <andrew@lunn.ch>,
"Jakub Kicinski" <kuba@kernel.org>,
"Eric Dumazet" <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Heiner Kallweit" <hkallweit1@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
thomas.petazzoni@bootlin.com,
"Christophe Leroy" <christophe.leroy@csgroup.eu>,
"Herve Codina" <herve.codina@bootlin.com>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Vladimir Oltean" <vladimir.oltean@nxp.com>,
"Köry Maincent" <kory.maincent@bootlin.com>,
"Marek Behún" <kabel@kernel.org>,
"Oleksij Rempel" <o.rempel@pengutronix.de>,
"Nicolò Veronese" <nicveronese@gmail.com>,
"Simon Horman" <horms@kernel.org>,
mwojtas@chromium.org,
"Romain Gantois" <romain.gantois@bootlin.com>,
"Daniel Golle" <daniel@makrotopia.org>,
"Dimitri Fedrau" <dimitri.fedrau@liebherr.com>
Subject: Re: [PATCH net-next 06/13] net: sfp: Add a sfp-bus ops when connecting a module without PHY
Date: Fri, 30 Jan 2026 16:19:38 +0000 [thread overview]
Message-ID: <aXzaGg3AkHOdP30A@shell.armlinux.org.uk> (raw)
In-Reply-To: <20260127134202.8208-7-maxime.chevallier@bootlin.com>
On Tue, Jan 27, 2026 at 02:41:54PM +0100, Maxime Chevallier wrote:
> The SFP bus infrastructure notifies its upstream when a PHY device was
> discovered on the module. However, we don't have any indication when a
> module with no PHY was inserted, except for the .insert() and .start()
> notifications.
That's the way you tell - if you get the .start() callback but you
haven't had a PHY connected, that means there's no PHY.
There should be no need to add this callback, since you shouldn't be
thinking that the module is fully initialised until you have received
the .start() callback.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2026-01-30 16:19 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-27 13:41 [PATCH net-next 00/13] net: phy_port: SFP modules representation and phy_port listing Maxime Chevallier
2026-01-27 13:41 ` [PATCH net-next 01/13] net: phy: phy_port: Correctly recompute the port's linkmodes Maxime Chevallier
2026-01-27 14:00 ` Kory Maincent
2026-01-27 15:21 ` Maxime Chevallier
2026-01-27 13:41 ` [PATCH net-next 02/13] net: phy: phy_link_topology: Add a helper for opportunistic alloc Maxime Chevallier
2026-01-27 13:41 ` [PATCH net-next 03/13] net: phy: phy_link_topology: Track ports in phy_link_topology Maxime Chevallier
2026-01-27 13:41 ` [PATCH net-next 04/13] net: phylink: Register a phy_port for MAC-driven SFP busses Maxime Chevallier
2026-01-27 13:41 ` [PATCH net-next 05/13] net: phy: Create SFP phy_port before registering usptream Maxime Chevallier
2026-01-28 15:49 ` Romain Gantois
2026-01-30 13:31 ` Maxime Chevallier
2026-01-27 13:41 ` [PATCH net-next 06/13] net: sfp: Add a sfp-bus ops when connecting a module without PHY Maxime Chevallier
2026-01-30 16:19 ` Russell King (Oracle) [this message]
2026-01-30 17:08 ` Maxime Chevallier
2026-01-27 13:41 ` [PATCH net-next 07/13] net: phy: Represent PHY-less SFP modules with phy_port Maxime Chevallier
2026-01-28 15:54 ` Romain Gantois
2026-01-30 13:32 ` Maxime Chevallier
2026-01-27 13:41 ` [PATCH net-next 08/13] net: phylink: " Maxime Chevallier
2026-01-28 16:01 ` Romain Gantois
2026-01-30 13:36 ` Maxime Chevallier
2026-01-27 13:41 ` [PATCH net-next 09/13] net: phy: phy_port: Store information about a MII port's occupancy Maxime Chevallier
2026-01-28 16:08 ` Romain Gantois
2026-01-30 13:38 ` Maxime Chevallier
2026-01-27 13:41 ` [PATCH net-next 10/13] net: phy: phy_link_topology: Add a helper to retrieve ports Maxime Chevallier
2026-01-27 22:23 ` kernel test robot
2026-01-27 22:44 ` kernel test robot
2026-01-28 16:10 ` Romain Gantois
2026-01-30 13:41 ` Maxime Chevallier
2026-01-27 13:41 ` [PATCH net-next 11/13] net: phy: store phy_modes in a static array Maxime Chevallier
2026-01-27 13:42 ` [PATCH net-next 12/13] netlink: specs: Add ethernet port listing with ethtool Maxime Chevallier
2026-01-27 13:42 ` [PATCH net-next 13/13] net: ethtool: Introduce ethtool command to list ports Maxime Chevallier
2026-01-27 23:16 ` kernel test robot
2026-01-27 21:07 ` [PATCH net-next 00/13] net: phy_port: SFP modules representation and phy_port listing Jakub Kicinski
2026-01-27 21:18 ` Maxime Chevallier
2026-01-28 8:07 ` Maxime Chevallier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aXzaGg3AkHOdP30A@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=christophe.leroy@csgroup.eu \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=dimitri.fedrau@liebherr.com \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=herve.codina@bootlin.com \
--cc=hkallweit1@gmail.com \
--cc=horms@kernel.org \
--cc=kabel@kernel.org \
--cc=kory.maincent@bootlin.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=mwojtas@chromium.org \
--cc=netdev@vger.kernel.org \
--cc=nicveronese@gmail.com \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=romain.gantois@bootlin.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox