From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [78.32.30.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5519836C0B1 for ; Fri, 30 Jan 2026 18:09:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=78.32.30.218 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769796563; cv=none; b=kMKJYBQ/PUQZq0b+pYimBC8kzdVKam5A2uMkt5A2eeKrPhvfCf4FFdz9rbU/X4uE1lMOQdn3yJbvmoCBYBssHyDMW0lTUnr8HAbwmkTJSjGBCSVxYhQNYcqM69csc6OZjDw1KbegTL73Bt8n4YJrTRaEU9/H8iCc7bVeXeBGxrI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769796563; c=relaxed/simple; bh=e/Bt9m9lnx3IOS1PLwqfMdX95DKtRAdPMruzoSYKGbA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=EBufEk2D2W9lVuEgkujRXmkMkdqz5K8dtYenvJGJSfBSrbv6pqQREQGslM4+PHfhO1+fzMcmbc5jCzUORdIVKa8EKpPYpnh1KturNBdJFJwEVbNN2rezJlVX/SyH54fjhhdSD3T5inkuLxYFfuARL8R/rg4eoCAIHTcEv295qTA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk; spf=none smtp.mailfrom=armlinux.org.uk; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b=y8g5IMvG; arc=none smtp.client-ip=78.32.30.218 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="y8g5IMvG" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=NJGHCJHC/C1S/dc48iAgg6S72Ja9f72htrzVxmHBznY=; b=y8g5IMvGwzIvn9WkzEVPh4AHot IhhlsFV8sIPDLGDtax1wUOk9cjSIdE3slCsK0mabLqDgtmwGIDcfBwEi0E/4UX/Wl7s24kMfe8Tu8 bBA6ZgW1hDAYrFBJgDCUuzEnNC3CeL/cDDlgYJB1UNz9gvduqe34eGAgsaSzMh+7xC3RcurkARW78 V8fuuT8N+sUlCYCX82GH0yKvOzWgh5dVUK8XwQBH3W3F2qOGg/GL0fQPkF+AUJCqK9G+Gn24ZuTjc k1azLxitSHg3NYX4yx9lGo1ieKhr+UPiKMCEHk3v7xTN7VHl5/YV97PgUcQH6S4K+XUAQJwSsF/xI UyDV2bGA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:46880) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vlsvh-000000001Km-0cQA; Fri, 30 Jan 2026 18:09:13 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.98.2) (envelope-from ) id 1vlsvd-000000000it-3G8k; Fri, 30 Jan 2026 18:09:09 +0000 Date: Fri, 30 Jan 2026 18:09:09 +0000 From: "Russell King (Oracle)" To: Maxime Chevallier Cc: Andrew Lunn , Alexandre Torgue , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, netdev@vger.kernel.org, Paolo Abeni Subject: Re: [PATCH net-next 1/3] net: stmmac: clear half-duplex caps where unsupported Message-ID: References: <9dfdeee0-7758-439b-a2a5-a7f243427cf4@bootlin.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9dfdeee0-7758-439b-a2a5-a7f243427cf4@bootlin.com> Sender: Russell King (Oracle) On Fri, Jan 30, 2026 at 06:29:23PM +0100, Maxime Chevallier wrote: > Hi, > > On 30/01/2026 12:10, Russell King (Oracle) wrote: > > Where a core supports hardware features, but does not indicate support > > for half-duplex, clear phylink's half-duplex 1G, 100M and 10M > > capability bits to disallow half-duplex operation and advertisement of > > these link modes. > > > > This will avoid the need for special code in the PCS driver to do this > > based on the ESTATUS register bits, as the support in the PCS is > > dependent on the same synthesis choice as the MAC core. > > > > Signed-off-by: Russell King (Oracle) > > Gave it a quick test on socfpga, as this impacts all variants, > and we seem to be good so, > > Tested-by: Maxime Chevallier > Reviewed-by: Maxime Chevallier If you look at /sys/kernel/debug/stmmaceth/ethX/dma_cap, it should say whether half duplex is supported (I guess in your case it will be, it's probably very unlikely not to be.) However, would be worth knowing whether the if() is taken or not! -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!