From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD5C329A32D for ; Thu, 12 Feb 2026 20:53:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770929591; cv=none; b=T7RoHntX0Jq5kXTZuXFZgSqqWJYJ/nKkL/2JXi0jOozrUT9MCNpbmcAC+FgszggZ883J0cfbP8WndlflHnB4U3ONfzgSCY0Okzw1lVoI894UOOzfVSM0CUJIkZtWF+ZgdiJGJmwoVrl/B72pThGDFMCZk5p601KN1bgoqemOLTg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770929591; c=relaxed/simple; bh=iIYldWO1yWWolN4bbBuyPnJV93TUrrkg80C+Xk+0TG8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=K5WFhW2K0yu5fA28di/s3GEJUd2IuZ6LVbsw05pCDVHXTC/kHywGtM2Fc6LvWCeAG4FI6H0xAaEPaH+SKn7ukkvKJH5OVUbNwBysht1S2Zw663yskaaO0ewDRrQL83to2jQRLU+Otu2y5qUoJrFEnRphN62W9jub+WqYazseeIY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ML+Q0QqQ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ML+Q0QqQ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 38BEDC4CEF7; Thu, 12 Feb 2026 20:53:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1770929591; bh=iIYldWO1yWWolN4bbBuyPnJV93TUrrkg80C+Xk+0TG8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ML+Q0QqQExCIEzt7Fb+XfoWE7sXr7uEQ2RqdkokUX7il/S+CSCfdRB3k/sQMUrHH1 m+vRPnrvgsty8IO9MCUPNz/DQ902Gwxty1eYKDmGHa9WpoZXNjoVexSfh52tOlOBZh OubEyfYokGPMkr+kepYNT2l8stISbZJVW0TWhruWRAWivblb2GSqDCcTEJGZuqjtBN kT0EG0lELKwdGPbk2czHkf009PosoKUKLMTAwhUcK2b3zXApEkTKxCgwIad/np1fCN Pk6Xb5wHzl0G3cKH0j5iCFeb4otMKouIMKzBHqo43xa2QDTGLggZEdVGF3co5QoXN/ 3Jhd990IAJcFg== Date: Thu, 12 Feb 2026 20:53:08 +0000 From: Simon Horman To: Michal Swiatkowski Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, Aleksandr Loktionov Subject: Re: [PATCH iwl-net v1] libie: prevent memleak in fwlog code Message-ID: References: <20260211091008.236185-1-michal.swiatkowski@linux.intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260211091008.236185-1-michal.swiatkowski@linux.intel.com> On Wed, Feb 11, 2026 at 10:10:08AM +0100, Michal Swiatkowski wrote: > All cmd_buf buffers are allocated and need to be freed after usage. > Add an error unwinding path that properly frees these buffers. > > The memory leak happens whenever fwlog configuration is changed. For > example: > > $echo 256K > /sys/kernel/debug/ixgbe/0000\:32\:00.0/fwlog/log_size > > Fixes: 96a9a9341cda ("ice: configure FW logging") > Reviewed-by: Aleksandr Loktionov > Signed-off-by: Michal Swiatkowski Reviewed-by: Simon Horman