From: Simon Horman <horms@kernel.org>
To: Allison Henderson <achender@kernel.org>
Cc: netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
pabeni@redhat.com, edumazet@google.com, rds-devel@oss.oracle.com,
kuba@kernel.org, linux-rdma@vger.kernel.org,
allison.henderson@oracle.com
Subject: Re: [PATCH net v2] net/rds: rds_sendmsg should not discard payload_len
Date: Thu, 12 Feb 2026 18:09:16 +0000 [thread overview]
Message-ID: <aY4XTIr2qklED4cs@horms.kernel.org> (raw)
In-Reply-To: <20260210170952.1836306-1-achender@kernel.org>
On Tue, Feb 10, 2026 at 10:09:52AM -0700, Allison Henderson wrote:
> Commit 3db6e0d172c9 ("rds: use RCU to synchronize work-enqueue with
> connection teardown") modifies rds_sendmsg to avoid enqueueing work
> while a tear down is in progress. However, it also changed the return
> value of rds_sendmsg to that of rds_send_xmit instead of the
> payload_len. This means the user may incorrectly receive errno values
> when it should have simply received a payload of 0 while the peer
> attempts a reconnections. So this patch corrects the teardown handling
> code to only use the out error path in that case, thus restoring the
> original payload_len return value.
>
> Fixes: 3db6e0d172c9 ("rds: use RCU to synchronize work-enqueue with connection teardown")
> Signed-off-by: Allison Henderson <achender@kernel.org>
>
> ---
> Changes in v2:
> - Rebased on net/main to fix apply failure in v1
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2026-02-12 18:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-10 17:09 [PATCH net v2] net/rds: rds_sendmsg should not discard payload_len Allison Henderson
2026-02-12 18:09 ` Simon Horman [this message]
2026-02-13 3:05 ` Jakub Kicinski
2026-02-13 6:39 ` Allison Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aY4XTIr2qklED4cs@horms.kernel.org \
--to=horms@kernel.org \
--cc=achender@kernel.org \
--cc=allison.henderson@oracle.com \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rds-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox