From: Simon Horman <horms@kernel.org>
To: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
Aleksandr Loktionov <aleksandr.loktionov@intel.com>
Subject: Re: [PATCH iwl-net v1] libie: don't unroll if fwlog isn't supported
Date: Thu, 12 Feb 2026 21:00:17 +0000 [thread overview]
Message-ID: <aY4_Yau83X1TxEop@horms.kernel.org> (raw)
In-Reply-To: <20260211091140.236389-1-michal.swiatkowski@linux.intel.com>
On Wed, Feb 11, 2026 at 10:11:40AM +0100, Michal Swiatkowski wrote:
> The libie_fwlog_deinit() function can be called during driver unload
> even when firmware logging was never properly initialized. This led to call
> trace:
>
> [ 148.576156] Oops: Oops: 0000 [#1] SMP NOPTI
> [ 148.576167] CPU: 80 UID: 0 PID: 12843 Comm: rmmod Kdump: loaded Not tainted 6.17.0-rc7next-queue-3oct-01915-g06d79d51cf51 #1 PREEMPT(full)
> [ 148.576177] Hardware name: HPE ProLiant DL385 Gen10 Plus/ProLiant DL385 Gen10 Plus, BIOS A42 07/18/2020
> [ 148.576182] RIP: 0010:__dev_printk+0x16/0x70
> [ 148.576196] Code: 1f 44 00 00 90 90 90 90 90 90 90 90 90 90 90 90 90 90 90 90 0f 1f 44 00 00 41 55 41 54 49 89 d4 55 48 89 fd 53 48 85 f6 74 3c <4c> 8b 6e 50 48 89 f3 4d 85 ed 75 03 4c 8b 2e 48 89 df e8 f3 27 98
> [ 148.576204] RSP: 0018:ffffd2fd7ea17a48 EFLAGS: 00010202
> [ 148.576211] RAX: ffffd2fd7ea17aa0 RBX: ffff8eb288ae2000 RCX: 0000000000000000
> [ 148.576217] RDX: ffffd2fd7ea17a70 RSI: 00000000000000c8 RDI: ffffffffb68d3d88
> [ 148.576222] RBP: ffffffffb68d3d88 R08: 0000000000000000 R09: 0000000000000000
> [ 148.576227] R10: 00000000000000c8 R11: ffff8eb2b1a49400 R12: ffffd2fd7ea17a70
> [ 148.576231] R13: ffff8eb3141fb000 R14: ffffffffc1215b48 R15: ffffffffc1215bd8
> [ 148.576236] FS: 00007f5666ba6740(0000) GS:ffff8eb2472b9000(0000) knlGS:0000000000000000
> [ 148.576242] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> [ 148.576247] CR2: 0000000000000118 CR3: 000000011ad17000 CR4: 0000000000350ef0
> [ 148.576252] Call Trace:
> [ 148.576258] <TASK>
> [ 148.576269] _dev_warn+0x7c/0x96
> [ 148.576290] libie_fwlog_deinit+0x112/0x117 [libie_fwlog]
> [ 148.576303] ixgbe_remove+0x63/0x290 [ixgbe]
> [ 148.576342] pci_device_remove+0x42/0xb0
> [ 148.576354] device_release_driver_internal+0x19c/0x200
> [ 148.576365] driver_detach+0x48/0x90
> [ 148.576372] bus_remove_driver+0x6d/0xf0
> [ 148.576383] pci_unregister_driver+0x2e/0xb0
> [ 148.576393] ixgbe_exit_module+0x1c/0xd50 [ixgbe]
> [ 148.576430] __do_sys_delete_module.isra.0+0x1bc/0x2e0
> [ 148.576446] do_syscall_64+0x7f/0x980
>
> It can be reproduced by trying to unload ixgbe driver in recovery mode.
>
> Fix that by checking if fwlog is supported before doing unroll.
>
> Fixes: 641585bc978e ("ixgbe: fwlog support for e610")
> Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
> Signed-off-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2026-02-12 21:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-11 9:11 [PATCH iwl-net v1] libie: don't unroll if fwlog isn't supported Michal Swiatkowski
2026-02-12 21:00 ` Simon Horman [this message]
2026-02-26 6:10 ` [Intel-wired-lan] " Rinitha, SX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aY4_Yau83X1TxEop@horms.kernel.org \
--to=horms@kernel.org \
--cc=aleksandr.loktionov@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=michal.swiatkowski@linux.intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox