From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 325181E376C; Fri, 13 Feb 2026 14:19:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770992344; cv=none; b=vALPJlxnvghPwDNFEF+THA7upL5mbWIWVsldz0KMK4Ri3zliBCHqygdCwhTUKM6hL3C+8mlbfwSZlE00E29aNZ0RzRts15vMPC/hrxHOMGM/qDTb5ObGSOeyCsRwE3/6Pv7wmbBcNUbRSTIruKMiP3QG1A5UbMzgdE1x+FgNNAI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770992344; c=relaxed/simple; bh=T+WU0QN6oLz5dRbHnI15ISCNNguwotjY59hsUOGBEuE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=mAdrbgyy+FJ3XCAoU+nob3lJ/NJdEkccl3P3fJS8YbOvFDJDc7R9vdzQrpwGV+kjAYNi17ScFnbRQm6jgGs3tCNG+FGXzRspFH+TneO31wmcUP7bi/yj4ovew6UWbs8QWjX7UdHrcpmB/V6Kxc4H4h+5rJqqsI9ZpJVsFYBqjpM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=K0Fbb1dZ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="K0Fbb1dZ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C7C00C16AAE; Fri, 13 Feb 2026 14:19:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1770992343; bh=T+WU0QN6oLz5dRbHnI15ISCNNguwotjY59hsUOGBEuE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=K0Fbb1dZFif3zC5eISWPo54HKbjuhmBzb6zxCWXHtCI6PbHFTS9ruQtabCz9IY0GX d+7uJuB7mySEm00o1VpFgjKOGvD/mizoo1YTEEKOjum1EyQ2SRofxBSfSWPgMjb/y1 mOJfZhCvf2XgY8vX6zmL9vR5PWmcBgLQpw0eZj0+aRPNswYJTzOZPYWWwDcHQQrir1 bQ6E8UxL4xYpM4I8MztaqPQsCxMUHCNFAwVXF4Zdv/428bmwLd1zoVGvZghPniTRDW imaIrXVsPrUJSU4Xxf2flLli9Xx4fVimUillDTMYomwvH4LbsDcuNYOzyB6//xSwZP 9duHW7Bag7qow== Date: Fri, 13 Feb 2026 14:18:59 +0000 From: Simon Horman To: Paolo Abeni Cc: Yohei Kojima , Andrew Lunn , Jakub Kicinski , "David S. Miller" , Eric Dumazet , Jonathan Corbet , netdev@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v2] docs: ethtool: clarify the bit-by-bit bitset format description Message-ID: References: Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Feb 11, 2026 at 12:55:55PM +0100, Paolo Abeni wrote: > On 2/7/26 11:25 AM, Yohei Kojima wrote: > > Clarify the bit-by-bit bitset format's behavior around mandatory > > attributes and bit identification. More specifically, the following > > changes are made: > > > > * Rephrase a misleading sentence which implies name and index are > > mutually exclusive > > * Describe that ETHTOOL_A_BITSET_BITS nest is mandatory > > * Describe that a request fails if inconsistent identifiers are given > > > > Signed-off-by: Yohei Kojima > > --- > > Current ethtool-netlink documentation doesn't describe several behavior > > around bit-by-bit bitset, which makes it hard to develop a ethtool > > library without digging into the kernel code. This patch eases the gap > > between the kernel behavior and the documentation by adding descriptions > > around the mandatory attribute and bit identification. > > This needs review by someone provided with English natural language > skills far better than mine. I'm wrapping the net-next PR right now; > this has to be deferred after the merge window, I'm sorry. Hi Paolo, It's my opinion that, from an English language perspective, the changes in this patch match the description. Reviewed-by: Simon Horman