From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [78.32.30.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 844C6286A7 for ; Tue, 3 Feb 2026 00:17:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=78.32.30.218 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770077844; cv=none; b=CPNU9u17gslY10xFgCaceg/ETZXVFxx4aReVYnQ+mYvmJX5h11YQrVAxQtu9zxbQPm05y9q7NGzRQfKujbvZ7Ao7KhDSXntDDmvknS1loLmvAKhDC8mx5kUkkX1EK1tlHW9cKDSGymq0Zz6f51jyMr81QJq5S1LmDQW4gn1Ao8U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770077844; c=relaxed/simple; bh=Ng135SnaS703nDA7esgIsFfXee++TNvFidYovRMyJnU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ALFrnZDkWXPAu64XOKY31PMk41PP57EZTVgvc423ixoXv04B/WVVBO/YNUmu0aPSS44tkhRsNapuN8LLAK6eo99jpAqw9I1v3Rs0nKM8hq74j/abjR9B6V/UjMt1BEzCIZZ2jmkKgSZsDeuOLdz+Ac1buetsLRfnlwJUMJ43X8I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk; spf=none smtp.mailfrom=armlinux.org.uk; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b=VHco1eed; arc=none smtp.client-ip=78.32.30.218 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="VHco1eed" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=cnbZIEEYc7qpXnHl4ZHTwHEJ9GmdouAAJMZTX/GpBdE=; b=VHco1eedf+GGw5ftuQkpadN50P 7/H8FTN1MGUAxFL0qaQpqSUGBucDqIYDt2U6LLBoiqx7tvKS6VoTTBhrOYlT1RxPCi6HFdsETvIQp sXTZAAPd5royUP8fucUiITv0PgZWrzYozcBefdUuZQOxe2GyOcd6r+F67dWJJ3SFiTt1LB02rYw7V Pfll0qmBlvzg+6CwkRVObhvX8/S3fYitEX1qZyg0Dq3jn83YD/SjpS9v5OJyj6Us0yPmzm9hhgY8a pVqBbhlOEvLVREJxuvD4A86L1kSexJyTYxCFgGMK+cpZoLagFf11xaAlc550PdCWJ+aDfbmBgHihf j7NM+9ZA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:52622) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vn46R-000000004UO-08eh; Tue, 03 Feb 2026 00:17:11 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.98.2) (envelope-from ) id 1vn46M-000000003qY-46I1; Tue, 03 Feb 2026 00:17:07 +0000 Date: Tue, 3 Feb 2026 00:17:06 +0000 From: "Russell King (Oracle)" To: Ovidiu Panait Cc: Alexandre Torgue , Andrew Lunn , Andrew Lunn , Clark Wang , Daniel Scally , "David S. Miller" , Emanuele Ghidoli , Eric Dumazet , Fabio Estevam , Heiner Kallweit , imx@lists.linux.dev, Jakub Kicinski , Kieran Bingham , linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, Maxime Coquelin , netdev@vger.kernel.org, Oleksij Rempel , Paolo Abeni , Pengutronix Kernel Team , Rob Herring , Sascha Hauer , Shawn Guo , Stefan Klug , Wei Fang , Laurent Pinchart Subject: Re: [PATCH RFC net-next] net: stmmac: provide flag to disable EEE Message-ID: References: Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Russell King (Oracle) On Mon, Feb 02, 2026 at 10:23:45PM +0000, Russell King (Oracle) wrote: > On Mon, Feb 02, 2026 at 08:54:52PM +0200, Ovidiu Panait wrote: > > If not, maybe this patch could be merged to add the flag that disables > > EEE and I will just send a patch to disable EEE on our platforms as well. > > We still need the flag to disable EEE for platforms where lpi_intr_o is > logically OR'd with the other interrupts, so there's no way to ignore > its persistent assertion. I'll also state that we need both patches, but there's no point pushing my original patch (to allow EEE to be disabled) unless Laurent is going to also submit a patch to make use of the flag - the EEE disable and Laurent's patch needs to be part of a series. We don't merge stuff that adds facilities that have no users, because that's been proven time and time again to be a recipe for accumulating cruft. So, at the moment, "net: stmmac: provide flag to disable EEE" ain't going anywhere until there's a patch that makes use of the new flag. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!