From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Ethan Nelson-Moore <enelsonmoore@gmail.com>
Cc: linux-usb@vger.kernel.org, netdev@vger.kernel.org,
"Vadim Fedorenko" <vadim.fedorenko@linux.dev>,
"Andrew Lunn" <andrew@lunn.ch>,
"Andrew Lunn" <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Peter Korsgaard" <peter@korsgaard.com>,
"Steve Glendinning" <steve.glendinning@shawell.net>,
"Oliver Neukum" <oneukum@suse.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Oleksij Rempel" <o.rempel@pengutronix.de>,
"Max Schulze" <max.schulze@online.de>,
"Krzysztof Hałasa" <khalasa@piap.pl>
Subject: Re: [PATCH net-next v4] net: usb: introduce usbnet_mii_ioctl helper function
Date: Tue, 3 Feb 2026 11:49:26 +0200 [thread overview]
Message-ID: <aYHEplTvRrfhCRQu@smile.fi.intel.com> (raw)
In-Reply-To: <CADkSEUgmX1tk-qJ7ee=P3EYcvriW91nVJZ6AFDpVEVjj7O8pJg@mail.gmail.com>
On Tue, Feb 03, 2026 at 12:49:57AM -0800, Ethan Nelson-Moore wrote:
> On Tue, Feb 3, 2026 at 12:25 AM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > > +extern int usbnet_mii_ioctl(struct net_device *net, struct ifreq *rq, int cmd);
> >
> > Do we still need to populate 'extern'? Can we get rid of this redundancy?
> In my opinion, while you're right that it isn't necessary because all
> functions (unlike variables) are implied to be extern, the use of
> extern to indicate functions that are exported/intended to be part of
> the API is a good idea.
I'm not sure. This makes it harder to read for no benefit. All non-static
functions are part of the API.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-02-03 9:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-03 1:34 [PATCH net-next v4] net: usb: introduce usbnet_mii_ioctl helper function Ethan Nelson-Moore
2026-02-03 8:25 ` Andy Shevchenko
2026-02-03 8:49 ` Ethan Nelson-Moore
2026-02-03 9:49 ` Andy Shevchenko [this message]
2026-02-04 3:48 ` Ethan Nelson-Moore
2026-02-04 3:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aYHEplTvRrfhCRQu@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=enelsonmoore@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=khalasa@piap.pl \
--cc=kuba@kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=max.schulze@online.de \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=oneukum@suse.com \
--cc=pabeni@redhat.com \
--cc=peter@korsgaard.com \
--cc=steve.glendinning@shawell.net \
--cc=vadim.fedorenko@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox