From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A63CE30FF1E; Tue, 3 Feb 2026 09:49:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.21 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770112175; cv=none; b=cLE8xB0I6HZQf8MpZURgyBCdIFGcwT56C9rjDZfg4iFKIXhihXf7HmialQ1TpqltzCVTVOUeq0ur5aEIFeQ6mCu1sT25YF+4Y2/nT9E7tt0vfZ1/W49A0FOqluHALGVIJvdbA7yQlAnPnVsIrRgbEGvtYnAMSH/ZSwVW4SC7KRI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770112175; c=relaxed/simple; bh=Yvv8PdiJk4vferQPdXd1xsgzuanXzMbWFOfsBrfoLOM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=VsIneYq/A3jHhRRifOa9B4vIaLBjNSqZfqGP6ZzcEGdEtb0SU0KP3X4UeiP/NWHxMlubpeDbXJ4DtgqkJt8lLm6zfCct0L3zJgR5wHl7NrySvNw1q4Jgo4nEmHOsLYNizgjNnexP+TJN/uOJgIIDkQeEvTv0pa2yFsmTRYeQgS0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=RwGYWHD3; arc=none smtp.client-ip=198.175.65.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="RwGYWHD3" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1770112174; x=1801648174; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=Yvv8PdiJk4vferQPdXd1xsgzuanXzMbWFOfsBrfoLOM=; b=RwGYWHD3p4M8FuP4t0+vNRw5G5jEV+xh9vXqhmgUy/cXJ4Sdo4yFuOPa L7vVjJeu3vn7Un+JjHUwQT18Lrn/w3rHDVzCwGtkkg7nUsG2LvdIIhbV5 LSKDkIqRTQJby/OXJS4s9nPSx7bpFQWs2wJZZCBHXxeJyzWvDLDeSik7U u+5NhbxfC24np5+3HUVdTFbvEtqs0HZONPx9tlFazWotJsUsMgl/KINdO /FaI/vMvOvyEGwD8Cve4U8pltebk5CMv9Rd7bkkzpWH6QzY8G6GVIpbRN hOXEnVCSc5rpdE7qyseoIFqBLjiX1CBvKzEoO2RWSVr2PeWDp9nmXpsgB g==; X-CSE-ConnectionGUID: WkrSdiQtTBKvXc9hs5InSw== X-CSE-MsgGUID: Zh+znDpTSHWx3dW/IabATA== X-IronPort-AV: E=McAfee;i="6800,10657,11690"; a="71185739" X-IronPort-AV: E=Sophos;i="6.21,270,1763452800"; d="scan'208";a="71185739" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Feb 2026 01:49:33 -0800 X-CSE-ConnectionGUID: xOfB06JITtCoOp841Qer0w== X-CSE-MsgGUID: wVyZksmhT5GQwaBw3xZcoQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,270,1763452800"; d="scan'208";a="247406072" Received: from pgcooper-mobl3.ger.corp.intel.com (HELO localhost) ([10.245.245.99]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Feb 2026 01:49:29 -0800 Date: Tue, 3 Feb 2026 11:49:26 +0200 From: Andy Shevchenko To: Ethan Nelson-Moore Cc: linux-usb@vger.kernel.org, netdev@vger.kernel.org, Vadim Fedorenko , Andrew Lunn , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Peter Korsgaard , Steve Glendinning , Oliver Neukum , Greg Kroah-Hartman , Oleksij Rempel , Max Schulze , Krzysztof =?utf-8?Q?Ha=C5=82asa?= Subject: Re: [PATCH net-next v4] net: usb: introduce usbnet_mii_ioctl helper function Message-ID: References: <20260203013517.26170-1-enelsonmoore@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Tue, Feb 03, 2026 at 12:49:57AM -0800, Ethan Nelson-Moore wrote: > On Tue, Feb 3, 2026 at 12:25 AM Andy Shevchenko > wrote: > > > +extern int usbnet_mii_ioctl(struct net_device *net, struct ifreq *rq, int cmd); > > > > Do we still need to populate 'extern'? Can we get rid of this redundancy? > In my opinion, while you're right that it isn't necessary because all > functions (unlike variables) are implied to be extern, the use of > extern to indicate functions that are exported/intended to be part of > the API is a good idea. I'm not sure. This makes it harder to read for no benefit. All non-static functions are part of the API. -- With Best Regards, Andy Shevchenko