From: Felix Maurer <fmaurer@redhat.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, horms@kernel.org,
jkarrenpalo@gmail.com, tglx@linutronix.de, mingo@kernel.org,
allison.henderson@oracle.com, petrm@nvidia.com,
antonio@openvpn.net
Subject: Re: [PATCH net-next v2 1/9] selftests: hsr: Add ping test for PRP
Date: Tue, 3 Feb 2026 16:07:50 +0100 [thread overview]
Message-ID: <aYIPRqJMTRbvkF3s@thinkpad> (raw)
In-Reply-To: <20260203134712.Q1vJp5UQ@linutronix.de>
On Tue, Feb 03, 2026 at 02:47:12PM +0100, Sebastian Andrzej Siewior wrote:
> On 2026-02-03 13:23:50 [+0100], Felix Maurer wrote:
> > But like you, I'm uncertain what would be the right thing to do and
> > which port should control the MAC for all the others.
>
> At the very least I need the same MAC on both ends for PTP.
> Now that check the spec, 5.2.1.1 "HSR handling of multicast frames",
> bottom below Figure 10, says it sends the frame over frame A and frame B
> oder the ports. The "src-MAC + sequence number" uniquely identify the
> same frame.
> Now I am certain that the two different MACs are wrong. Let deal with
> this later and then decide what to do about the testsuite.
Alright, I lean towards same MAC on both ports as well. But yeah, let's
fix this in the future, including the test suite.
Thanks,
Felix
next prev parent reply other threads:[~2026-02-03 15:08 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-22 14:56 [PATCH net-next v2 0/9] hsr: Implement more robust duplicate discard algorithm Felix Maurer
2026-01-22 14:56 ` [PATCH net-next v2 1/9] selftests: hsr: Add ping test for PRP Felix Maurer
2026-01-29 11:05 ` Sebastian Andrzej Siewior
2026-01-29 13:31 ` Felix Maurer
2026-01-29 15:21 ` Sebastian Andrzej Siewior
2026-01-29 17:44 ` Felix Maurer
2026-02-02 11:51 ` Felix Maurer
2026-02-02 15:55 ` Sebastian Andrzej Siewior
2026-02-03 10:12 ` Felix Maurer
2026-02-03 11:55 ` Sebastian Andrzej Siewior
2026-02-03 12:23 ` Felix Maurer
2026-02-03 13:47 ` Sebastian Andrzej Siewior
2026-02-03 15:07 ` Felix Maurer [this message]
2026-01-22 14:56 ` [PATCH net-next v2 2/9] selftests: hsr: Check duplicates on HSR with VLAN Felix Maurer
2026-01-22 14:56 ` [PATCH net-next v2 3/9] selftests: hsr: Add tests for faulty links Felix Maurer
2026-01-22 14:56 ` [PATCH net-next v2 4/9] hsr: Implement more robust duplicate discard for PRP Felix Maurer
2026-01-28 16:38 ` Simon Horman
2026-01-28 18:37 ` Felix Maurer
2026-02-02 16:57 ` Sebastian Andrzej Siewior
2026-02-03 10:23 ` Felix Maurer
2026-02-03 11:57 ` Sebastian Andrzej Siewior
2026-02-03 12:42 ` Felix Maurer
2026-02-03 13:49 ` Sebastian Andrzej Siewior
2026-02-03 15:11 ` Felix Maurer
2026-01-29 13:29 ` Sebastian Andrzej Siewior
2026-01-29 15:30 ` Felix Maurer
2026-02-02 8:47 ` Steffen Lindner
2026-01-22 14:57 ` [PATCH net-next v2 5/9] selftests: hsr: Add tests for more link faults with PRP Felix Maurer
2026-01-29 13:32 ` Sebastian Andrzej Siewior
2026-02-02 11:30 ` Felix Maurer
2026-02-02 16:45 ` Sebastian Andrzej Siewior
2026-02-03 12:09 ` Felix Maurer
2026-02-03 14:49 ` Sebastian Andrzej Siewior
2026-02-03 15:32 ` Felix Maurer
2026-01-22 14:57 ` [PATCH net-next v2 6/9] hsr: Implement more robust duplicate discard for HSR Felix Maurer
2026-01-29 14:43 ` Sebastian Andrzej Siewior
2026-01-29 16:17 ` Felix Maurer
2026-01-29 18:01 ` Felix Maurer
2026-01-30 10:34 ` Felix Maurer
2026-02-02 17:53 ` Sebastian Andrzej Siewior
2026-02-03 11:49 ` Felix Maurer
2026-02-03 12:08 ` Sebastian Andrzej Siewior
2026-02-02 17:11 ` Sebastian Andrzej Siewior
2026-02-03 11:08 ` Felix Maurer
2026-02-03 12:09 ` Sebastian Andrzej Siewior
2026-01-22 14:57 ` [PATCH net-next v2 7/9] selftests: hsr: Add more link fault tests " Felix Maurer
2026-01-22 14:57 ` [PATCH net-next v2 8/9] hsr: Update PRP duplicate discard KUnit test for new algorithm Felix Maurer
2026-01-29 15:12 ` Sebastian Andrzej Siewior
2026-01-29 16:19 ` Felix Maurer
2026-01-22 14:57 ` [PATCH net-next v2 9/9] MAINTAINERS: Assign hsr selftests to HSR Felix Maurer
2026-01-22 17:24 ` [PATCH net-next v2 0/9] hsr: Implement more robust duplicate discard algorithm Sebastian Andrzej Siewior
2026-01-23 1:35 ` Jakub Kicinski
2026-01-26 9:28 ` Felix Maurer
2026-01-29 15:29 ` Sebastian Andrzej Siewior
2026-01-29 16:29 ` Felix Maurer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aYIPRqJMTRbvkF3s@thinkpad \
--to=fmaurer@redhat.com \
--cc=allison.henderson@oracle.com \
--cc=antonio@openvpn.net \
--cc=bigeasy@linutronix.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jkarrenpalo@gmail.com \
--cc=kuba@kernel.org \
--cc=mingo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox