Re: [EXTERNAL] [PATCH net-next 0/2] net: ti: icssg: Remove dedicated workqueue for ndo_set_rx_mode callback

[Kevin Hao <haokexin@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 3419 bytes --]

On Wed, Feb 04, 2026 at 04:44:21PM +0530, Meghana Malladi wrote:
> Hi Kevin,
> 
> On 2/4/26 08:11, Kevin Hao wrote:
> > While addressing an issue in the cpsw driver, I based my fix on the
> > implementation of the emac_ndo_set_rx_mode() function in icssg. During
> > review, Jakub pointed out that the dedicated workqueue for the
> > ndo_set_rx_mode callback might be unnecessary. 
> > ZjQcmQRYFpfptBannerStart
> > This message was sent from outside of Texas Instruments.
> > Do not click links or open attachments unless you recognize the source
> > of this email and know the content is safe.
> > Report Suspicious
> > <https://us-phishalarm-ewt.proofpoint.com/EWT/v1/G3vK!
> > uxdqXRfPtm1bKoXPFrvrtsCD2dIkXHVJwEzupcwg1k-qY0e_2PUuMdZgJf-
> > SUVShc4kuXcBnqQbeqGz1dHBW-_OSdROPAjSiNpSTmAhDg8nQbc8$>
> > ZjQcmQRYFpfptBannerEnd
> > 
> > While addressing an issue in the cpsw driver, I based my fix on the
> > implementation of the emac_ndo_set_rx_mode() function in icssg. During review,
> > Jakub pointed out that the dedicated workqueue for the ndo_set_rx_mode
> > callback might be unnecessary. I subsequently used the system workqueue for
> > this purpose in the cpsw driver, and it performed as expected. Therefore,
> > I believe the same approach can be applied to the icssg driver. These two
> > patches aim to remove this dedicated workqueue for icssg drivers.
> > 
> 
> It would be more helpful, if you could provide link to the cpsw fix which
> you have mentioned above.

The fix for cpsw is available at:
  https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=c0b5dc73a38f954e780f93a549b8fe225235c07a

Jakub's suggestion can be found here:
  https://lore.kernel.org/all/20260127190836.6a420768@kernel.org/

I will also include this information in the v2 cover letter.

Thanks,
Kevin

> 
> > Please note: I do not have access to a board that supports the CSSG PRU
> > Ethernet controller, so this change has only been build-tested.
> > 
> > ---
> > Cc: MD Danish Anwar <danishanwar@ti.com>
> > Cc: Roger Quadros <rogerq@kernel.org>
> > Cc: Andrew Lunn <andrew+netdev@lunn.ch>
> > Cc: "David S. Miller" <davem@davemloft.net>
> > Cc: Eric Dumazet <edumazet@google.com>
> > Cc: Jakub Kicinski <kuba@kernel.org>
> > Cc: Paolo Abeni <pabeni@redhat.com>
> > Cc: Meghana Malladi <m-malladi@ti.com>
> > Cc: Jacob Keller <jacob.e.keller@intel.com>
> > Cc: Vadim Fedorenko <vadim.fedorenko@linux.dev>
> > Cc: Himanshu Mittal <h-mittal1@ti.com>
> > Cc: Simon Horman <horms@kernel.org>
> > Cc: Byungchul Park <byungchul@sk.com>
> > Cc: Markus Elfring <elfring@users.sourceforge.net>
> > 
> > ---
> > Kevin Hao (2):
> >        net: ti: icssg-prueth-sr1: Remove unused workqueue
> >        net: ti: icssg-prueth: Use system default workqueue in ndo_set_rx_mode callback
> > 
> >   drivers/net/ethernet/ti/icssg/icssg_common.c     |  1 -
> >   drivers/net/ethernet/ti/icssg/icssg_prueth.c     | 13 ++++---------
> >   drivers/net/ethernet/ti/icssg/icssg_prueth.h     |  1 -
> >   drivers/net/ethernet/ti/icssg/icssg_prueth_sr1.c |  9 +--------
> >   4 files changed, 5 insertions(+), 19 deletions(-)
> > ---
> > base-commit: 5c009020744fe129e4728e71c44a6c7816c9105e
> > change-id: 20260203-icssg-prueth-workqueue-f460eba72132
> > 
> > Best regards,
> > -- 
> > Kevin Hao <haokexin@gmail.com>
> > 
> 
> Thanks,
> Meghana

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]