From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 230C327B359; Wed, 4 Feb 2026 14:33:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770215585; cv=none; b=luz6G9dBBaU7WI1ahsohTODScTAx6ecvBzSXMDRahwrGBHw+CMTwB3m8nDgXUyCQo+1POEcYW+WUlJPVVTfoGLJyn+qw3Js6RTL+xQxcJF/OmrxFWuxMbvbde9pbdGLQhS9eFNHGZGQsz+60D5vuDElMxHQzw/FlZFJWayGPpNs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770215585; c=relaxed/simple; bh=pXXP39c4G2+cWRpwZabdRWaGFcVTaSz2uuubofAEqzs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Ci3YIbLcyrSylk7YRntHplyv/oGu2O7lIPsgbcCXsLanBYewBrQc9KuL6s/wJCgCwglJJ2VtQFApTyyS360TnqBOeZaMzNZQkCt15VBXPNve5StRfHGwJjhj9igfO0BGgFROXvUGBy/IB6JWe3KTouQoJXzDR0GRNMTH/WCCpcc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=ZZrndd52; arc=none smtp.client-ip=192.198.163.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="ZZrndd52" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1770215585; x=1801751585; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=pXXP39c4G2+cWRpwZabdRWaGFcVTaSz2uuubofAEqzs=; b=ZZrndd52X7Qu0MdAns6V9dd3yERRvGk7YfS0jFo4cdCH7AihB2nvPVsb QTcxWC8CmqL/a6jkcEf9iWfwNTairWoOda1g/mGCg0CsGIbjfHCTkVdOc 7w5RqR9SeTV9OI80bL7eJTpXwgJb8AR4i77rlQmJy3OZYsOemqx8fEBxf OiVuMjsHeB98Eu3fTMVsdiYFfDjM+xrBUrDlFtjFiSC3v9xJ4BqkfiSQ7 72K7DgXkkjJlALc8V+TRGFrvWupQKtVLbX6fMjexOfUFOMNNGI6bZQGcZ 9q6SEd2r6A0nEjN4NT62JBauG3vWbc7rCIxF7vCCwGKZdthI299LdNV4K w==; X-CSE-ConnectionGUID: RtoAN6d6RHKuBCPoahCOxw== X-CSE-MsgGUID: ABqIg06QTxGRuoJBLRsFrA== X-IronPort-AV: E=McAfee;i="6800,10657,11691"; a="96855671" X-IronPort-AV: E=Sophos;i="6.21,272,1763452800"; d="scan'208";a="96855671" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Feb 2026 06:33:03 -0800 X-CSE-ConnectionGUID: 7iVTz8XvT0iKwlrMyzxQmw== X-CSE-MsgGUID: PQeFSibgRTmg/z2CvsDH3g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,272,1763452800"; d="scan'208";a="247776896" Received: from pgcooper-mobl3.ger.corp.intel.com (HELO localhost) ([10.245.245.188]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Feb 2026 06:32:58 -0800 Date: Wed, 4 Feb 2026 16:32:55 +0200 From: Andy Shevchenko To: Jeff Layton Cc: Chuck Lever , NeilBrown , linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, llvm@lists.linux.dev, Trond Myklebust , Anna Schumaker , Olga Kornievskaia , Dai Ngo , Tom Talpey , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt Subject: Re: [PATCH v2 0/3] sunrpc: Fix `make W=1` build issues Message-ID: References: <20260204094500.2443455-1-andriy.shevchenko@linux.intel.com> <9859fe54fded87e720e375b1b267908437480f47.camel@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9859fe54fded87e720e375b1b267908437480f47.camel@kernel.org> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Wed, Feb 04, 2026 at 09:28:28AM -0500, Jeff Layton wrote: > On Wed, 2026-02-04 at 10:41 +0100, Andy Shevchenko wrote: > > Compiler is not happy about unused variables (especially when > > dprintk() call is defined as no-op). Here is the series to > > address the issues. > > > > Changelog v2: > > - added patch to kill RPC_IFDEBUG() macro (LKP, Geert) > > - united separate patches in the series > > - collected tags (Geert) > > > > v1: 20260204010402.2149563-1-andriy.shevchenko@linux.intel.com > > v1: 20260204010415.2149607-1-andriy.shevchenko@linux.intel.com > > > > Andy Shevchenko (3): > > nfs/blocklayout: Fix compilation error (`make W=1`) in > > bl_write_pagelist() > > sunrpc: Kill RPC_IFDEBUG() > > sunrpc: Fix compilation error (`make W=1`) when dprintk() is no-op > > > > fs/lockd/svclock.c | 5 +++++ > > fs/nfs/blocklayout/blocklayout.c | 4 +--- > > fs/nfsd/nfsfh.c | 9 +++++--- > > include/linux/sunrpc/debug.h | 10 +++++---- > > net/sunrpc/xprtrdma/svc_rdma_transport.c | 27 ++++++++++++------------ > > 5 files changed, 32 insertions(+), 23 deletions(-) > > These all look like good changes to me. The first patch should go to > Trond/Anna and Chuck will probably pick up the other two? As I explained in v1, the error in the first patch may be shadowed if the third one (and hence second) is taken first. That's why I prefer them to go via single place. > Reviewed-by: Jeff Layton Thanks! -- With Best Regards, Andy Shevchenko