From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx1.secunet.com (mx1.secunet.com [62.96.220.36]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F21B9360729; Thu, 5 Feb 2026 07:58:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=62.96.220.36 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770278314; cv=none; b=bn7kgF3k2ALP1wlfTukQFm9KI2MNHDSGKvO/jR101UXJyXuk5Tguxfqyv+Gs+xINPsK2Mv1bH21Bi1xN+1+JJdsSencvnNheaAdlf5zzUTblJdamqHMVo5K//c0ccW94dzFINTnOfb0fu/mztVtoV/bQcSZwCrX3C5WWinvUhXc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770278314; c=relaxed/simple; bh=pkWS7JtxH2V5mKX8UrQ08efERr2CUTHYYzCGVyb5BGE=; h=Date:From:To:CC:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=mUaY3ITjSno9+N6Y5+v6p0XfoLRR8lKTC+qaUSZs9v4YKuV6BA0m+KTP/vStGHusDqr5yT8MGp1kxemheaF9pp4wvghRg1dONBLYAs4UnvJIlwTFNHfxLJ3Fp7C9nZM2+58qJLkuRdiHGIlGe+astzDS8IcAgraAhPcRmk9kGB4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=secunet.com; spf=pass smtp.mailfrom=secunet.com; dkim=pass (2048-bit key) header.d=secunet.com header.i=@secunet.com header.b=QQq8jiLW; arc=none smtp.client-ip=62.96.220.36 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=secunet.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=secunet.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=secunet.com header.i=@secunet.com header.b="QQq8jiLW" Received: from localhost (localhost [127.0.0.1]) by mx1.secunet.com (Postfix) with ESMTP id 7A0BE2084A; Thu, 5 Feb 2026 08:58:32 +0100 (CET) X-Virus-Scanned: by secunet Received: from mx1.secunet.com ([127.0.0.1]) by localhost (mx1.secunet.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dMKAJ3yHvG15; Thu, 5 Feb 2026 08:58:29 +0100 (CET) Received: from EXCH-01.secunet.de (rl1.secunet.de [10.32.0.231]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.secunet.com (Postfix) with ESMTPS id CEC5920844; Thu, 5 Feb 2026 08:58:29 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.secunet.com CEC5920844 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=secunet.com; s=202301; t=1770278309; bh=3Sy60T/xKliudAYvigy+B1nmABmcknoDy0r3XYANbJs=; h=Date:From:To:CC:Subject:References:In-Reply-To:From; b=QQq8jiLWKhG6n2kihFvH8aLUtXmM0Irl0SzNfrKW3apfrAamVwrbdKVbDsUxCixut KJZurcJtmmbEiCqjRA4RqQF3/adt5xWjfub1ZWM85NltRVDQPJmFYHuQa0VmXwByIh bDK2zpnPFYbes1liiRsahCgspJj5IlscLCkfmQV4Qs1vraaFJ28IkLQ7RSqGf4+nbH jTUjF/n/VJI7sOlb4b4v7jTrsooitNckGq36nkRjKKZ4HTYyGAN9yZG/Fx7mbn9eqe D5tK0PgtrgefiOhbz667PuGA3Des1WUvQ4OJACXpbFc7R9mtF735vRl7JJoE+bnVnz 4gAiHmRgWto5w== Received: from secunet.com (10.182.7.193) by EXCH-01.secunet.de (10.32.0.171) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Thu, 5 Feb 2026 08:58:29 +0100 Received: (nullmailer pid 856736 invoked by uid 1000); Thu, 05 Feb 2026 07:58:28 -0000 Date: Thu, 5 Feb 2026 08:58:28 +0100 From: Steffen Klassert To: Tariq Toukan CC: Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , "David S. Miller" , Herbert Xu , , , Mark Bloch , Gal Pressman , Moshe Shemesh , Jianbo Liu , Cosmin Ratiu , Alexandre Cassen , Leon Romanovsky Subject: Re: [PATCH net] xfrm: skip templates check for packet offload tunnel mode Message-ID: References: <1769518163-125874-1-git-send-email-tariqt@nvidia.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1769518163-125874-1-git-send-email-tariqt@nvidia.com> X-ClientProxiedBy: EXCH-02.secunet.de (10.32.0.172) To EXCH-01.secunet.de (10.32.0.171) On Tue, Jan 27, 2026 at 02:49:23PM +0200, Tariq Toukan wrote: > From: Leon Romanovsky > > In packet offload, hardware is responsible to check templates. The > result of its operation is forwarded through secpath by relevant > drivers. That secpath is actually removed in __xfrm_policy_check2(). > > In case packet is forwarded, this secpath is reset in RX, but pushed > again to TX where policy is rechecked again against dummy secpath > in xfrm_policy_ok(). > > Such situation causes to unexpected XfrmInTmplMismatch increase. > > As a solution, simply skip template mismatch check. > > Fixes: 600258d555f0 ("xfrm: delete intermediate secpath entry in packet offload mode") > Signed-off-by: Leon Romanovsky > Reviewed-by: Jianbo Liu > Reviewed-by: Cosmin Ratiu > Signed-off-by: Tariq Toukan Applied, thanks everyone!