From: Florian Westphal <fw@strlen.de>
To: Paolo Abeni <pabeni@redhat.com>
Cc: netdev@vger.kernel.org,
Steffen Klassert <steffen.klassert@secunet.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Simon Horman <horms@kernel.org>
Subject: Re: [RFC PATCH] xfrm: reduce struct sec_path size
Date: Fri, 6 Feb 2026 01:11:37 +0100 [thread overview]
Message-ID: <aYUxubug67eqQ6aH@strlen.de> (raw)
In-Reply-To: <a2552992ca2fa29754340eaa05b1a185fca7a381.1770309837.git.pabeni@redhat.com>
Paolo Abeni <pabeni@redhat.com> wrote:
> The mentioned struct has an hole and uses unnecessary wide type to
> store a MAC length.
Good catch.
> struct sec_path {
> int len;
> int olen;
> struct xfrm_offload ovec[1];
> int verified_cnt;
Why not s/int/u8/ while at it?
> struct xfrm_state * xvec[6];
len is xvec, olen is the offload length which can only be 0 or 1 at this time.
verified_cnt also refers to xvec[].
> /* Used to keep whole l2 header for transport mode GRO */
> - __u32 orig_mac_len;
> + __u16 orig_mac_len;
Matches mac_len in sk_buff; I think this change is fine.
next prev parent reply other threads:[~2026-02-06 0:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-05 16:44 [RFC PATCH] xfrm: reduce struct sec_path size Paolo Abeni
2026-02-06 0:11 ` Florian Westphal [this message]
2026-02-06 9:37 ` Paolo Abeni
2026-02-06 9:48 ` Steffen Klassert
2026-02-06 14:36 ` Paolo Abeni
2026-02-06 14:42 ` Steffen Klassert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aYUxubug67eqQ6aH@strlen.de \
--to=fw@strlen.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=herbert@gondor.apana.org.au \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox