From: Kevin Hao <haokexin@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, stable@vger.kernel.org,
MD Danish Anwar <danishanwar@ti.com>,
Roger Quadros <rogerq@kernel.org>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH net] net: ti: icssg-prueth: Add dependency on HSR
Date: Fri, 6 Feb 2026 10:56:54 +0800 [thread overview]
Message-ID: <aYVYdqmyzBnTOZAV@pek-khao-d3> (raw)
In-Reply-To: <20260205100315.134766d7@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 578 bytes --]
On Thu, Feb 05, 2026 at 10:03:15AM -0800, Jakub Kicinski wrote:
> Looks like there are appropriate static inlines in place to handle
> HSR=n in the driver the only problematic case is if HSR is m and
> drivers is y, no?
>
> depends on HSR || HSR=n
>
> is likely more suitable.
Yes, the icssg-prueth driver can still be built with HSR disabled. Therefore,
this should be an optional dependency. I will update it to:
depends on HSR if HSR
as this is the recommended way to express optional dependencies according to
kconfig-language.rst.
Thanks,
Kevin
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2026-02-06 2:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-03 12:43 [PATCH net] net: ti: icssg-prueth: Add dependency on HSR Kevin Hao
2026-02-05 18:03 ` Jakub Kicinski
2026-02-06 2:56 ` Kevin Hao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aYVYdqmyzBnTOZAV@pek-khao-d3 \
--to=haokexin@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=danishanwar@ti.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rogerq@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox