From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: netdev@vger.kernel.org, imx@lists.linux.dev,
Andrew Lunn <andrew+netdev@lunn.ch>,
Clark Wang <xiaoning.wang@nxp.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Fabio Estevam <festevam@denx.de>,
Fabio Estevam <festevam@gmail.com>,
Francesco Dolcini <francesco.dolcini@toradex.com>,
Frank Li <Frank.Li@nxp.com>, Heiko Schocher <hs@denx.de>,
Jakub Kicinski <kuba@kernel.org>,
Joakim Zhang <qiangqing.zhang@nxp.com>, Joy Zou <joy.zou@nxp.com>,
Kieran Bingham <kieran.bingham@ideasonboard.com>,
Marcel Ziswiler <marcel.ziswiler@toradex.com>,
Marco Felsch <m.felsch@pengutronix.de>,
Martyn Welch <martyn.welch@collabora.com>,
Mathieu Othacehe <othacehe@gnu.org>,
Paolo Abeni <pabeni@redhat.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Richard Hu <richard.hu@technexion.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Shawn Guo <shawnguo@kernel.org>,
Shenwei Wang <shenwei.wang@nxp.com>,
Stefan Klug <stefan.klug@ideasonboard.com>,
Stefano Radaelli <stefano.radaelli21@gmail.com>,
Wei Fang <wei.fang@nxp.com>,
Xiaoliang Yang <xiaoliang.yang_1@nxp.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] net: stmmac: imx: Disable EEE
Date: Mon, 9 Feb 2026 13:12:25 +0000 [thread overview]
Message-ID: <aYndOVkz7AOQK7qr@shell.armlinux.org.uk> (raw)
In-Reply-To: <20260208232931.2272237-1-laurent.pinchart@ideasonboard.com>
On Mon, Feb 09, 2026 at 01:29:31AM +0200, Laurent Pinchart wrote:
...
> Fix the issue by disabling EEE completely on i.MX8MP.
>
> [1] https://lore.kernel.org/all/20251026122905.29028-1-laurent.pinchart@ideasonboard.com/
> [2] https://lore.kernel.org/all/20251123053518.8478-1-laurent.pinchart@ideasonboard.com/
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> This patch depends on https://lore.kernel.org/r/20251026122905.29028-1-laurent.pinchart@ideasonboard.com
Are you sure? That's the one adding the DT property, not my patch that
adds the flag you need for this.
> @@ -355,7 +354,8 @@ static struct imx_dwmac_ops imx8mp_dwmac_data = {
> .addr_width = 34,
> .mac_rgmii_txclk_auto_adj = false,
> .set_intf_mode = imx8mp_set_intf_mode,
> - .flags = STMMAC_FLAG_HWTSTAMP_CORRECT_LATENCY,
> + .flags = STMMAC_FLAG_HWTSTAMP_CORRECT_LATENCY
> + | STMMAC_FLAG_EEE_DISABLE,
I thought we had a coding style comment about wrapping like this
(operators should be trailing on the previous line, not at the
beginning of the following line) but I can find nothing in
Documentation/process/coding-style.rst Confused. Maybe it's
somewhere else in the re-organised documentation.
Thanks!
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2026-02-09 13:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-08 23:29 [PATCH] net: stmmac: imx: Disable EEE Laurent Pinchart
2026-02-09 13:12 ` Russell King (Oracle) [this message]
2026-02-09 13:21 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aYndOVkz7AOQK7qr@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=Frank.Li@nxp.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=festevam@denx.de \
--cc=festevam@gmail.com \
--cc=francesco.dolcini@toradex.com \
--cc=hs@denx.de \
--cc=imx@lists.linux.dev \
--cc=joy.zou@nxp.com \
--cc=kernel@pengutronix.de \
--cc=kieran.bingham@ideasonboard.com \
--cc=kuba@kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=m.felsch@pengutronix.de \
--cc=marcel.ziswiler@toradex.com \
--cc=martyn.welch@collabora.com \
--cc=netdev@vger.kernel.org \
--cc=othacehe@gnu.org \
--cc=pabeni@redhat.com \
--cc=qiangqing.zhang@nxp.com \
--cc=richard.hu@technexion.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=shenwei.wang@nxp.com \
--cc=stefan.klug@ideasonboard.com \
--cc=stefano.radaelli21@gmail.com \
--cc=wei.fang@nxp.com \
--cc=xiaoliang.yang_1@nxp.com \
--cc=xiaoning.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox