public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Joe Damato <joe@dama.to>
To: Michael Chan <michael.chan@broadcom.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
	kuba@kernel.org, pabeni@redhat.com, andrew+netdev@lunn.ch,
	pavan.chebbi@broadcom.com, andrew.gospodarek@broadcom.com
Subject: Re: [PATCH net-next 1/2] bnxt_en: Refactor bnxt_need_reserve_rings()
Date: Mon, 9 Feb 2026 14:21:58 -0800	[thread overview]
Message-ID: <aYpeBvldHPDI7N/F@devvm20253.cco0.facebook.com> (raw)
In-Reply-To: <20260207235118.1987301-2-michael.chan@broadcom.com>

On Sat, Feb 07, 2026 at 03:51:17PM -0800, Michael Chan wrote:
> bnxt_need_reserve_rings() checks 6 ring resources against the reserved
> values to determine if a new reservation is needed.  Factor out the code
> to collect the total resources into a new helper function
> bnxt_get_total_resources() to make the code cleaner and easier to read.
> Instead of individual scalar variables, use the struct bnxt_hw_rings to
> hold all the ring resources.  Using the struct, hwr.cp replaces the nq
> variable and the chip specific hwr.cp_p5 replaces cp on newer chips.
> 
> There is no change in behavior.  This will make it easier to check the
> RSS context resource in the next patch.
> 
> Reviewed-by: Andy Gospodarek <andrew.gospodarek@broadcom.com>
> Signed-off-by: Michael Chan <michael.chan@broadcom.com>
> ---
>  drivers/net/ethernet/broadcom/bnxt/bnxt.c | 45 +++++++++++++++--------
>  1 file changed, 30 insertions(+), 15 deletions(-)

Reviewed-by: Joe Damato <joe@dama.to>

  reply	other threads:[~2026-02-09 22:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-07 23:51 [PATCH net-next 0/2] bnxt_en: Add RSS context resource check Michael Chan
2026-02-07 23:51 ` [PATCH net-next 1/2] bnxt_en: Refactor bnxt_need_reserve_rings() Michael Chan
2026-02-09 22:21   ` Joe Damato [this message]
2026-02-07 23:51 ` [PATCH net-next 2/2] bnxt_en: Check RSS contexts in bnxt_need_reserve_rings() Michael Chan
2026-02-09 22:22   ` Joe Damato
2026-02-11  4:30 ` [PATCH net-next 0/2] bnxt_en: Add RSS context resource check patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aYpeBvldHPDI7N/F@devvm20253.cco0.facebook.com \
    --to=joe@dama.to \
    --cc=andrew+netdev@lunn.ch \
    --cc=andrew.gospodarek@broadcom.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=michael.chan@broadcom.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=pavan.chebbi@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox