From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [78.32.30.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6803B242D70; Wed, 11 Feb 2026 13:26:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=78.32.30.218 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770816412; cv=none; b=LSHcIjz+S7gsyVm5Arus3sKelkaTxzyp79bO++UBlGKf5bFDOsOUPKyiNlz4Qo6Cgdli3kez6QALzZvOD0Z1l+OtQeK6RfOqkBETf8sSdee1OzAKKNZQrKpoQg8JNg4QPs5jWMFxy587KEsacCf45xCQlwnLrZzvc+7pybY1DIo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770816412; c=relaxed/simple; bh=MVd5ohr5USyAJoOGADV1XP5YoTH/7jSAAnfRFvFnxjY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Yh9YerpuEIQUf+9JpGM8hw3A8c0H8jETAzAnW/Ra9ha7Jo6JevjoFT+fmy27m50DGjiStOnga1a3X8BcfMVyJBMyyB2CiNlmjMvjRdNXSBteC6LNZbOXDMiWzUfP+r/zjttXNSNBB+E/AuXpPcc6M+A5x3aVHfUtx63VG++sQ4I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk; spf=none smtp.mailfrom=armlinux.org.uk; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b=OSmX10tL; arc=none smtp.client-ip=78.32.30.218 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="OSmX10tL" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=qwOXPjLznHLtKRD4jgitsvTq9cSNo39oPpMZkvXFnGQ=; b=OSmX10tLBcbwgHYLjcjG+TGjsh 4Xr1rYBsUEjKvHRYFdODp8sw5KVpQfGchDY+VIGMjMGHNr2PvoldkUAbTj6iBZtTvTnDKcAIR1zG3 3rEP2Rrh3AO6O8vCYfrMSRxkZNy8uOvJO15L0IS3l9bfYrb1u7m3uBd+Pxj6S5OAP5e4JgASxXHyV NIFeF2qvLMvdiuLuxAbMHCkneSGMDaXXG6lgozSZXmeLIpNqvJ58flEIE/ehZKPL31fClFYiNPJ6p B0D5VwQHtQJogoEXMdQMT+K/yPOSBrCxEny/StkJm6+FKlNnayEhxqPunVKzLIVUFtT1Kn/mCtCBq SaN45VSQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:41770) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vqAEt-000000003Sg-34ho; Wed, 11 Feb 2026 13:26:44 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.98.2) (envelope-from ) id 1vqAEr-000000003o2-1RPH; Wed, 11 Feb 2026 13:26:41 +0000 Date: Wed, 11 Feb 2026 13:26:41 +0000 From: "Russell King (Oracle)" To: Meghana Malladi Cc: pabeni@redhat.com, kuba@kernel.org, edumazet@google.com, davem@davemloft.net, hkallweit1@gmail.com, andrew@lunn.ch, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, srk@ti.com, Vignesh Raghavendra , Roger Quadros , danishanwar@ti.com Subject: Re: [PATCH net] net: phy: dp83869: Set auto mdix bit for forced 100Base-Tx mode Message-ID: References: <20260211131033.2525617-1-m-malladi@ti.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260211131033.2525617-1-m-malladi@ti.com> Sender: Russell King (Oracle) On Wed, Feb 11, 2026 at 06:40:32PM +0530, Meghana Malladi wrote: > When using DP83869 in force 100Base-Tx mode, the PHY is required > to have robust Auto-MDIX feature enabled from register 1Eh. > Refer to 7.4.1.2 100BASE-TX section in the TRM [1] for more details. > > [1]: https://www.ti.com/lit/ds/symlink/dp83869hm.pdf > Signed-off-by: Meghana Malladi > --- > drivers/net/phy/dp83869.c | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/drivers/net/phy/dp83869.c b/drivers/net/phy/dp83869.c > index 1f381d7b13ff..70d759c45c6a 100644 > --- a/drivers/net/phy/dp83869.c > +++ b/drivers/net/phy/dp83869.c > @@ -110,6 +110,7 @@ > > /* CFG4 bits */ > #define DP83869_INT_OE BIT(7) > +#define DP83869_CFG4_ENABLE_AUTO_MDIX_100FD BIT(9) > > /* OP MODE */ > #define DP83869_OP_MODE_MII BIT(5) > @@ -900,6 +901,23 @@ static int dp83869_phy_reset(struct phy_device *phydev) > return dp83869_config_init(phydev); > } > > +static void dp83869_link_change_notify(struct phy_device *phydev) > +{ > + int cfg4; > + > + /* When using DP83869 in force 100Base-Tx mode, the PHY is required > + * to have robust Auto-MDIX feature enabled > + */ > + if (phydev->autoneg == AUTONEG_DISABLE && > + phydev->speed == SPEED_100 && > + phydev->duplex == DUPLEX_FULL) { > + cfg4 = phy_read(phydev, DP83869_CFG4); > + if (cfg4 >= 0) { > + cfg4 |= DP83869_CFG4_ENABLE_AUTO_MDIX_100FD; > + phy_write(phydev, DP83869_CFG4, cfg4); > + } > + } Shouldn't this kind of configuration be done via .config_aneg() ? -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!