From: Simon Horman <horms@kernel.org>
To: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
Przemek Kitszel <przemyslaw.kitszel@intel.com>
Subject: Re: [PATCH iwl-net v1] ice: set max queues in alloc_etherdev_mqs()
Date: Tue, 24 Feb 2026 09:40:07 +0000 [thread overview]
Message-ID: <aZ1x9zwU77RJlKti@horms.kernel.org> (raw)
In-Reply-To: <20260223125157.819135-1-michal.swiatkowski@linux.intel.com>
On Mon, Feb 23, 2026 at 01:51:57PM +0100, Michal Swiatkowski wrote:
> When allocating netdevice using alloc_etherdev_mqs() the maximum
> supported queues number should be passed. The vsi->alloc_txq/rxq is
> storing current number of queues, not the maximum ones.
>
> Use the same function for getting max Tx and Rx queues which is used
> during ethtool -l call to set maximum number of queues during netdev
> allocation.
>
> Reproduction steps:
> $ethtool -l $pf # says current 16, max 64
> $ethtool -S $pf # fine
> $ethtool -L $pf combined 40 # crash
>
> [491187.472594] Call Trace:
> [491187.472829] <TASK>
> [491187.473067] netif_set_xps_queue+0x26/0x40
> [491187.473305] ice_vsi_cfg_txq+0x265/0x3d0 [ice]
> [491187.473619] ice_vsi_cfg_lan_txqs+0x68/0xa0 [ice]
> [491187.473918] ice_vsi_cfg_lan+0x2b/0xa0 [ice]
> [491187.474202] ice_vsi_open+0x71/0x170 [ice]
> [491187.474484] ice_vsi_recfg_qs+0x17f/0x230 [ice]
> [491187.474759] ? dev_get_min_mp_channel_count+0xab/0xd0
> [491187.474987] ice_set_channels+0x185/0x3d0 [ice]
> [491187.475278] ethnl_set_channels+0x26f/0x340
>
> Fixes: ee13aa1a2c5a ("ice: use netif_get_num_default_rss_queues()")
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
> Signed-off-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2026-02-24 9:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-23 12:51 [PATCH iwl-net v1] ice: set max queues in alloc_etherdev_mqs() Michal Swiatkowski
2026-02-24 9:40 ` Simon Horman [this message]
2026-02-24 10:03 ` [Intel-wired-lan] " Paul Menzel
2026-02-24 10:51 ` Przemek Kitszel
2026-03-23 16:17 ` Nowlin, Alexander
2026-03-24 10:02 ` Rinitha, SX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aZ1x9zwU77RJlKti@horms.kernel.org \
--to=horms@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=michal.swiatkowski@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox