From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A37B36CDE6 for ; Tue, 24 Feb 2026 09:40:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771926010; cv=none; b=mZndQfPBGq/Tn1e9oUXA/O4uVH/0Sv98hmMyXNQboN15mq4wtz8nG2Xbgmy/ChysRZER4vLPoARulRCwoyMwQaLvF4OfJjvNzuQt5PKquZQ0BjqIiuhr0cg1G59NqcghSmP+TJlI3nJRGtelZVr+8VFBt9xchqdL912ujvUmHaM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771926010; c=relaxed/simple; bh=N+5C2uHwaPX2zVBtOgRhnM8WpLXGYOlGRM6SIgx9wSo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=QY129r69LduNypBbBUI+Oih0l9vdwjSgykZBMH/p+DwEBnQRBd1P8AZZbX6FiPk2UbqAmaqEEd4Yx4DdFD/Yw+v16nXnMXEsGY6KA+LzwMGfboK4SJx3YW0wJWp1c/M0yuE//IJB0Fhy3xvGbtM094Ss0wZ7p1cqcLF35J97GBc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=sBIdAcUO; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="sBIdAcUO" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1E778C116D0; Tue, 24 Feb 2026 09:40:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1771926010; bh=N+5C2uHwaPX2zVBtOgRhnM8WpLXGYOlGRM6SIgx9wSo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=sBIdAcUOm+bfeBzKoSv7NA/F/la9TlpbClXLBOW/ATSmAvlto5kt4A9aoEXACaWXY i5nreYarSPqMwpKtIwAe94at5ItkbJxmXTbowPGnyK3D03b/y8pf1b0NbDPbkU9O3w Q0fvNr68kLjVaHLVA3gRqgUpcIH+N7Hu0++ISO3dfO0ih2PsUtbDebe4154ZtWdH2U UAKaqAff4/yM1QBvMUyXDbDon3ypUp4qlislzDBpFvsmU/bMr/tE3uUf2ejN/RzFXL +pQ9WxunOShKf0vj05ArkNQgyGC+OavjriP+snTS3NyovHyCyUaw7yYomqM43fEWnq /ez5ayFDJGZow== Date: Tue, 24 Feb 2026 09:40:07 +0000 From: Simon Horman To: Michal Swiatkowski Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, Przemek Kitszel Subject: Re: [PATCH iwl-net v1] ice: set max queues in alloc_etherdev_mqs() Message-ID: References: <20260223125157.819135-1-michal.swiatkowski@linux.intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260223125157.819135-1-michal.swiatkowski@linux.intel.com> On Mon, Feb 23, 2026 at 01:51:57PM +0100, Michal Swiatkowski wrote: > When allocating netdevice using alloc_etherdev_mqs() the maximum > supported queues number should be passed. The vsi->alloc_txq/rxq is > storing current number of queues, not the maximum ones. > > Use the same function for getting max Tx and Rx queues which is used > during ethtool -l call to set maximum number of queues during netdev > allocation. > > Reproduction steps: > $ethtool -l $pf # says current 16, max 64 > $ethtool -S $pf # fine > $ethtool -L $pf combined 40 # crash > > [491187.472594] Call Trace: > [491187.472829] > [491187.473067] netif_set_xps_queue+0x26/0x40 > [491187.473305] ice_vsi_cfg_txq+0x265/0x3d0 [ice] > [491187.473619] ice_vsi_cfg_lan_txqs+0x68/0xa0 [ice] > [491187.473918] ice_vsi_cfg_lan+0x2b/0xa0 [ice] > [491187.474202] ice_vsi_open+0x71/0x170 [ice] > [491187.474484] ice_vsi_recfg_qs+0x17f/0x230 [ice] > [491187.474759] ? dev_get_min_mp_channel_count+0xab/0xd0 > [491187.474987] ice_set_channels+0x185/0x3d0 [ice] > [491187.475278] ethnl_set_channels+0x26f/0x340 > > Fixes: ee13aa1a2c5a ("ice: use netif_get_num_default_rss_queues()") > Reviewed-by: Przemek Kitszel > Signed-off-by: Michal Swiatkowski Reviewed-by: Simon Horman