From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 37EF923E346 for ; Tue, 24 Feb 2026 17:19:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771953544; cv=none; b=j+WJ3G2Kwzpc9OqrdI63BdxMs7A8/2tsaFncbo9u4/YUT7YA0CZma+nNqnP6q1c5GhcV/5DyRFzp/NvBKA1AXpB+3hFW5ffztCOkJlK0HplhPSNQ2TRYl/jVxO4mVtY/ULaD4k7b3Ju8pmfZriAM+R2Bb3/mgHIlFMArDp4gt0c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771953544; c=relaxed/simple; bh=i900DRGWs6LR6oE7M0VKybLNsNo5+GIYgR2gjE2Mip8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=pz+EmQZEJLtQrDCg7mvRHrFRuDudozVMI7D/VR5uacHVqV/WA0+A6prqXAuHnjxGWGmQjAQOeAHaSThKj2I9Umh6qQVHeATLSpcbLC6wNDtGuMilVhF2ZMXg16aO1FH1HahVPubEUC2aszvvlx9vAlly8h2T43LDBgyK4vXLO7s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=cyNFKDu9; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="cyNFKDu9" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6F709C116D0; Tue, 24 Feb 2026 17:19:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1771953544; bh=i900DRGWs6LR6oE7M0VKybLNsNo5+GIYgR2gjE2Mip8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cyNFKDu9Xm71SYg65fcSRPY3cSRewxuHFC9UEN/Vz0mN2qSWzUQ0uGI+CFFL7kjsP 7FssG/8hs+EC+xCGW+YW7dVqzJtI+uMjBtmsLf7YBHUQXMKHYjKL06kIGSTOYev8Dm wrqHVlAFwxHiKU7fMDazh2FcNGI51fqqGnmx1jE1RRl//AsoWHmKBdzAIZ9VjjERTf pPRUz02N5WmrZTJOry3C5oVfXOyRN2VjoefK5GYcE0bAcWbBmi79uo4i8t+gTXVMnA qc+hEm2jdY3Ccidh+PKApfD3dJ+J9oBl374o9TAqn990MXj6j2QFoSQwyAAmYO+sK2 NuDFl7gmAlT4g== Date: Tue, 24 Feb 2026 17:19:00 +0000 From: Simon Horman To: Fernando Fernandez Mancera Cc: netdev@vger.kernel.org, davem@davemloft.net, dsahern@kernel.org, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, tgraf@infradead.org Subject: Re: [PATCH 2/2 net-next] ipv4: bump rt_genid when a relevant devconf value changes through netlink Message-ID: References: <20260223153045.32044-1-fmancera@suse.de> <20260223153045.32044-2-fmancera@suse.de> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260223153045.32044-2-fmancera@suse.de> On Mon, Feb 23, 2026 at 04:30:45PM +0100, Fernando Fernandez Mancera wrote: > When modifying IPv4 devconf values using netlink for some relevant > fields the rt_cache_flush() call was missing. In addition, if forwarding > is enabled on the interface then disable LRO. > > This is needed to avoid possible connectivity issues and ease the > responsabilities of user space tools. > > Fixes: 9f0f7272ac95 ("ipv4: AF_INET link address family") > Signed-off-by: Fernando Fernandez Mancera > --- > net/ipv4/devinet.c | 23 ++++++++++++++++++++++- > 1 file changed, 22 insertions(+), 1 deletion(-) > > diff --git a/net/ipv4/devinet.c b/net/ipv4/devinet.c > index 590c68e979f5..9f55c13a9c1f 100644 > --- a/net/ipv4/devinet.c > +++ b/net/ipv4/devinet.c > @@ -2159,6 +2159,8 @@ static int inet_set_link_af(struct net_device *dev, const struct nlattr *nla, > { > struct in_device *in_dev = __in_dev_get_rtnl(dev); > struct nlattr *a, *tb[IFLA_INET_MAX+1]; > + struct net *net = dev_net(in_dev->dev); > + bool flush_cache = false; > int rem; > > if (!in_dev) Hi Fernando, Here it is assumed that in_dev may be NULL. But a few lines above it is now dereferenced unconditionally. Flagged by Smatch. -- pw-bot: cr