public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] net/hsr: update outdated comment
@ 2026-02-24  2:12 kexinsun
  2026-02-24 17:36 ` Simon Horman
  0 siblings, 1 reply; 2+ messages in thread
From: kexinsun @ 2026-02-24  2:12 UTC (permalink / raw)
  To: davem
  Cc: edumazet, kuba, pabeni, horms, netdev, linux-kernel, julia.lawall,
	xutong.ma, yunbolyu, ratnadiraw, kexinsun

The function hsr_rcv() was renamed hsr_handle_frame() and moved to
net/hsr/hsr_slave.c by commit 81ba6afd6e64 ("net/hsr: Switch from
dev_add_pack() to netdev_rx_handler_register()"). Update the comment
accordingly.

Signed-off-by: kexinsun <kexinsun@smail.nju.edu.cn>
---
 net/hsr/hsr_device.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/hsr/hsr_device.c b/net/hsr/hsr_device.c
index d1bfc49b5f01..5c3eca2235ce 100644
--- a/net/hsr/hsr_device.c
+++ b/net/hsr/hsr_device.c
@@ -742,7 +742,7 @@ int hsr_dev_finalize(struct net_device *hsr_dev, struct net_device *slave[2],
 		hsr->proto_ops = &hsr_ops;
 	}
 
-	/* Make sure we recognize frames from ourselves in hsr_rcv() */
+	/* Make sure we recognize frames from ourselves in hsr_handle_frame() */
 	res = hsr_create_self_node(hsr, hsr_dev->dev_addr,
 				   slave[1]->dev_addr);
 	if (res < 0)
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] net/hsr: update outdated comment
  2026-02-24  2:12 [PATCH] net/hsr: update outdated comment kexinsun
@ 2026-02-24 17:36 ` Simon Horman
  0 siblings, 0 replies; 2+ messages in thread
From: Simon Horman @ 2026-02-24 17:36 UTC (permalink / raw)
  To: kexinsun
  Cc: davem, edumazet, kuba, pabeni, netdev, linux-kernel, julia.lawall,
	xutong.ma, yunbolyu, ratnadiraw

On Tue, Feb 24, 2026 at 10:12:05AM +0800, kexinsun wrote:
> The function hsr_rcv() was renamed hsr_handle_frame() and moved to
> net/hsr/hsr_slave.c by commit 81ba6afd6e64 ("net/hsr: Switch from
> dev_add_pack() to netdev_rx_handler_register()"). Update the comment
> accordingly.
> 
> Signed-off-by: kexinsun <kexinsun@smail.nju.edu.cn>

I notice that you have sent a number of similar fixes recently.
I am curious to know how you found these problems.

If you are using a tool, please consider using the Assisted-by tag:
https://docs.kernel.org/process/coding-assistants.html

Also, both git grep and our AI generated code review
tell me that this is not the only instance of hsr_rcv lingering
in comments in this driver. Please update all of them.

-- 
pw-bot: changes-requested

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-02-24 17:36 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-24  2:12 [PATCH] net/hsr: update outdated comment kexinsun
2026-02-24 17:36 ` Simon Horman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox