From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A8893E555; Tue, 24 Feb 2026 17:36:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771954612; cv=none; b=o6FOha5nvzNlTTQamkkhRC8jUAvQ5HIukOFsI+6Ch2PWT6UseseJKfkqwgjHSiqoXpDxkrC/+EiEzln5b1bXV60vW3sSdB5+qDK+mYp9woi7QmFt/PMxdvO0DWddNjph7WpbC3GvmvZKyGNHXvy88P4c5G7qX+JD4TLcWDMjAl0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771954612; c=relaxed/simple; bh=D2ttvjm0kDTDRJSJsU4I6IT2so61IzcGQYqgQil448U=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=NljVWlxHvKs/OUui5bg7+pfN1iODJU3VUl4D47/2KOOZf2O8CHFuPMN/z29q3Ny49yPqINQyWSxPzaWZbdV8KHnrjdm0vYZkXxDxQajcT81seYN3kHdxbg7hjQCaGrj1yPqANEnq2lRcCht6EOWRe0Hx8FQBDKr0CV9b6rC5MNI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=cHCKBZvj; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="cHCKBZvj" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 27490C116D0; Tue, 24 Feb 2026 17:36:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1771954612; bh=D2ttvjm0kDTDRJSJsU4I6IT2so61IzcGQYqgQil448U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cHCKBZvjHpSEtIHnJF1gPsw4Z4CBV1bEIGIZBUKzwOfuMRK1v04Eajx2tTQcNIJJS aVD6FcNF60XKXaN60frgafhQlVg7qx8GJmxe3h4aNsclNH/zNGeue9ElGyyjW3IS4S 1cZo67R+5fHxkvKMx7MKCgn+PXJPl2K/4C5QInGP0Inpq7TRON2zh+N01ejvBGoSfQ xEouHhsJtgWtFJxJXuUp9gzQ+CRMbpHBiLy/Q1sO6d2//tiE2HlSpQs32FmbBBzURi b1s4f6svMojDR3luceLEu+WaNDyYjXrogCx0U3CmXOQG53aKQcYH3x7WpXgXPuzGWP Klcuw7gM4ZPLA== Date: Tue, 24 Feb 2026 17:36:48 +0000 From: Simon Horman To: kexinsun Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, julia.lawall@inria.fr, xutong.ma@inria.fr, yunbolyu@smu.edu.sg, ratnadiraw@smu.edu.sg Subject: Re: [PATCH] net/hsr: update outdated comment Message-ID: References: <20260224021205.1285-1-kexinsun@smail.nju.edu.cn> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260224021205.1285-1-kexinsun@smail.nju.edu.cn> On Tue, Feb 24, 2026 at 10:12:05AM +0800, kexinsun wrote: > The function hsr_rcv() was renamed hsr_handle_frame() and moved to > net/hsr/hsr_slave.c by commit 81ba6afd6e64 ("net/hsr: Switch from > dev_add_pack() to netdev_rx_handler_register()"). Update the comment > accordingly. > > Signed-off-by: kexinsun I notice that you have sent a number of similar fixes recently. I am curious to know how you found these problems. If you are using a tool, please consider using the Assisted-by tag: https://docs.kernel.org/process/coding-assistants.html Also, both git grep and our AI generated code review tell me that this is not the only instance of hsr_rcv lingering in comments in this driver. Please update all of them. -- pw-bot: changes-requested