public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH net-next 0/7] net: sparx5: clean up probe/remove init and deinit paths
@ 2026-02-25  9:05 Daniel Machon
  2026-02-25  9:05 ` [PATCH net-next 1/7] net: sparx5: call sparx5_start() last in probe() Daniel Machon
                   ` (7 more replies)
  0 siblings, 8 replies; 10+ messages in thread
From: Daniel Machon @ 2026-02-25  9:05 UTC (permalink / raw)
  To: Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, Steen Hegelund, UNGLinuxDriver, Richard Cochran
  Cc: netdev, linux-arm-kernel, linux-kernel

This series refactors the sparx5 init and deinit code out of
sparx5_start() and into probe(), adding proper per-subsystem cleanup
labels and deinit functions.

Currently, the sparx5 driver initializes most subsystems inside
sparx5_start(), which is called from probe(). This includes registering
netdevs, starting worker threads for stats and MAC table polling,
requesting PTP IRQs, and initializing VCAP. The function has grown to
handle many unrelated subsystems, and has no granular error handling —
it either succeeds entirely or returns an error, leaving cleanup to a
single catch-all label in probe().

The remove() path has a similar problem: teardown is not structured as
the reverse of initialization, and several subsystems lack proper deinit
functions. For example, the stats workqueue has no corresponding
cleanup, and the mact workqueue is destroyed without first cancelling
its delayed work.

Refactor this by moving each init function out of sparx5_start() and
into probe(), with a corresponding goto-based cleanup label. Add deinit
functions for subsystems that allocate resources, to properly cancel
work and destroy workqueues. Ensure that cleanup order in both error
paths and remove() follows the reverse of initialization order. What
remains in sparx5_start() is only hardware register setup and FDMA/XTR
initialization that does not require cleanup.

Before this series, most init functions live inside sparx5_start() with
no individual cleanup:

  probe():
    sparx5_start():              <- no granular error handling
      sparx5_mact_init()
      sparx_stats_init()           <- starts worker, no cleanup
      mact_queue setup             <- no cancel on teardown
      sparx5_register_netdevs()
      sparx5_register_notifier_blocks()
      sparx5_vcap_init()
    sparx5_ptp_init()

    probe() error path:
      cleanup_ports:
        sparx5_cleanup_ports()
        destroy_workqueue(mact_queue)

After this series, probe() initializes subsystems in order with
matching cleanup labels, and remove() tears down in reverse:

probe():
    sparx5_ptp_init()
    sparx5_vcap_init()
    sparx5_mact_init()
    sparx5_stats_init()
    sparx5_register_netdevs()
    sparx5_register_notifier_blocks()
    sparx5_start()

  remove():
    sparx5_unregister_notifier_blocks()
    sparx5_unregister_netdevs()
    sparx5_stats_deinit()
    sparx5_mact_deinit()
    sparx5_vcap_deinit()
    sparx5_ptp_deinit()
    sparx5_destroy_netdevs()

Signed-off-by: Daniel Machon <daniel.machon@microchip.com>
---
Daniel Machon (7):
      net: sparx5: call sparx5_start() last in probe()
      net: sparx5: move netdev and notifier block registration to probe
      net: sparx5: move VCAP initialization to probe
      net: sparx5: move MAC table initialization and add deinit function
      net: sparx5: move stats initialization and add deinit function
      net: sparx5: move calendar initialization to probe
      net: sparx5: move remaining init functions from start() to probe()

 .../ethernet/microchip/sparx5/sparx5_calendar.c    |  15 ++-
 .../net/ethernet/microchip/sparx5/sparx5_ethtool.c |   9 +-
 .../ethernet/microchip/sparx5/sparx5_mactable.c    |  27 +++-
 .../net/ethernet/microchip/sparx5/sparx5_main.c    | 149 ++++++++++-----------
 .../net/ethernet/microchip/sparx5/sparx5_main.h    |  12 +-
 drivers/net/ethernet/microchip/sparx5/sparx5_ptp.c |  13 ++
 .../ethernet/microchip/sparx5/sparx5_vcap_impl.c   |   2 +-
 7 files changed, 135 insertions(+), 92 deletions(-)
---
base-commit: 17d0056f71b13050317a662a505b1a36fb7009e5
change-id: 20260216-sparx5-init-deinit-037cf165c62e

Best regards,
-- 
Daniel Machon <daniel.machon@microchip.com>


^ permalink raw reply	[flat|nested] 10+ messages in thread
end of thread, other threads:[~2026-02-26 20:13 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-25  9:05 [PATCH net-next 0/7] net: sparx5: clean up probe/remove init and deinit paths Daniel Machon
2026-02-25  9:05 ` [PATCH net-next 1/7] net: sparx5: call sparx5_start() last in probe() Daniel Machon
2026-02-25  9:05 ` [PATCH net-next 2/7] net: sparx5: move netdev and notifier block registration to probe Daniel Machon
2026-02-25  9:05 ` [PATCH net-next 3/7] net: sparx5: move VCAP initialization " Daniel Machon
2026-02-25  9:05 ` [PATCH net-next 4/7] net: sparx5: move MAC table initialization and add deinit function Daniel Machon
2026-02-25  9:05 ` [PATCH net-next 5/7] net: sparx5: move stats " Daniel Machon
2026-02-25  9:05 ` [PATCH net-next 6/7] net: sparx5: move calendar initialization to probe Daniel Machon
2026-02-25  9:05 ` [PATCH net-next 7/7] net: sparx5: move remaining init functions from start() to probe() Daniel Machon
2026-02-25  9:15 ` [PATCH net-next 0/7] net: sparx5: clean up probe/remove init and deinit paths Russell King (Oracle)
2026-02-26 20:12   ` Daniel Machon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox