From: Hangbin Liu <liuhangbin@gmail.com>
To: Jay Vosburgh <jv@jvosburgh.net>
Cc: netdev@vger.kernel.org, Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Jiri Bohac <jbohac@suse.cz>, Liang Li <liali@redhat.com>
Subject: Re: [PATCH net] bonding: alb: fix UAF in rlb_arp_recv during bond up/down
Date: Sat, 14 Feb 2026 09:13:49 +0000 [thread overview]
Message-ID: <aZA8zSNByzQBxgaN@fedora> (raw)
In-Reply-To: <418608.1771019572@famine>
On Fri, Feb 13, 2026 at 01:52:52PM -0800, Jay Vosburgh wrote:
> Hangbin Liu <liuhangbin@gmail.com> wrote:
> >
> >Fix this by setting recv_probe to NULL before calling
> >bond_alb_deinitialize(), and then calling synchronize_net() to wait
> >for any concurrent RX processing to finish.
>
> I think the change looks good, however, to my reading the
> sentence above describes the order of events as 1) recv_probe = NULL, 2)
> bond_alb_deinitialize(), then 3) synchroninze_net(), whereas the changed
> code below is 1, 3, then 2.
>
> The code order is correct, but I think the commit description
> should match the code.
>
Got it. I will post v2 version to fix this.
Hangbin
prev parent reply other threads:[~2026-02-14 9:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-13 9:54 [PATCH net] bonding: alb: fix UAF in rlb_arp_recv during bond up/down Hangbin Liu
2026-02-13 10:16 ` Nikolay Aleksandrov
2026-02-13 10:30 ` Hangbin Liu
2026-02-13 21:52 ` Jay Vosburgh
2026-02-14 9:13 ` Hangbin Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aZA8zSNByzQBxgaN@fedora \
--to=liuhangbin@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jbohac@suse.cz \
--cc=jv@jvosburgh.net \
--cc=kuba@kernel.org \
--cc=liali@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox