From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 021822773E4 for ; Tue, 17 Feb 2026 18:35:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771353311; cv=none; b=t7E8rWqDoMKqDMMGTPxi5i9+cwGcVnYVFEQPas4QebrBI958pPDixNHY5YGy8e2qzKVMVP2oP90IwuVG6HOCB1+q8BggodwkSYgzd+/4IE/5B4GWk0ttHGhJ9dcEWMow2dneRu4BwE2ABj5Eb1LlF+FNKxqkmcjjRNr8WHUlQ7Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771353311; c=relaxed/simple; bh=dvn4WhoeyZ48zTOLiekWToB7p0p7kq21LM0Em3rfrXc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ObJ33NzxAWpW7BvPEZmiWP2HQZ7F3b4pSW1GlC/FhaoBhbdLUHBeo4nK6r23qHQRGgb+bsv3GeOZ7j9SfmxlF3PANiZSeOw7/GGfb0XvhQYKsZ5ryG6A2clbP8ucrRhXD2VbHysDlPHFn0zblDpQutLi/vCcQRfqJPONXni5fiY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=RDgF3v2w; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=EYi6vk+1; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="RDgF3v2w"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="EYi6vk+1" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61HGHEav1601370 for ; Tue, 17 Feb 2026 18:35:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=whCFM/BSXgDYxgAJq7FXzzvO BcHA3JZlYE1RiqYzwa0=; b=RDgF3v2wzcsLhhMnH8jJtVlwHjzy/EmJS8YH71Tp knkpCG1Zd1yevXd10FcYSMEOEq2LtaMVSWqlWjGFlsZDZePz7mYyemc9eXkRQPAn OrRoeWRnSadtiHSvmEVEZAzhVmhC8bCQfZiGu3CIKGaKUG4lqLu1ZED0R4XpqubW 035XsnUYSPWYNpS4mGmrj4KLyepupzJ6tBOuh7T+z0sPIXhr20EwdflWj/sdY2I2 t+TeyoPQzbqkJRbueblz5w+iaXG9OawdWvbVW/Nqwh58LaPZ+vcWJDJqVT03J07D TL/knQp3vOUmSTureJz+tpOZLkSCpScafXm9cI9QUq4b/A== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cc6tmbdje-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 17 Feb 2026 18:35:09 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2aad5fec176so52420305ad.2 for ; Tue, 17 Feb 2026 10:35:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1771353308; x=1771958108; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=whCFM/BSXgDYxgAJq7FXzzvOBcHA3JZlYE1RiqYzwa0=; b=EYi6vk+1eANbmSsKFX62giKY2YXeAgu1EWeIYBjsM8h0jmF05Jsye4PRwyo+o8XjgW 1tEwBHI/01cVUUOi+eGDyNsV61LyuoEomVmWUlpynl8x1zmn8k6dR3gWxfM7rzoGnGI0 9jxEGFNmPhjKUMwQfrkxElHg+MuCn+//PHWwjscbjSH2Wj3AhLh7j8PjOuWwDoPW7WL0 KB952opcsBMdIiyhJczmIeP49OqPPm/+c1WiZdFo+/lxXTHcpUCizwG+80BW9rISmrnv 77agTGPFilh9AblO3YPVlGsHmrTj1VmFV2gnLlRzSUCgPtjQ+v+HtGwaU3EsGzg35a2T SpGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771353308; x=1771958108; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=whCFM/BSXgDYxgAJq7FXzzvOBcHA3JZlYE1RiqYzwa0=; b=rEKrJ7d3GQkBYqwyXfr5lwdk/wByxgNxoMtKFgZKdz3pe4a0xAlzJwflpkLgyTlz37 ZuIuY6WL/T4+vXRIOqmrmVjY205NShZcheenw3atznYvMB1QgTpV7rcL1X5aGFfEYteR Fd7VWYpK+SlhCxO/gCckX7EZXv/uL/7FbWKqDBeRq5bGBZv/uP0Y9PYJjeH8cwk6BqUx 80XXfhEO9qxEryn/JXuk0VTqOcn/1ROWd9T9ZacDt7vcXm6P8hYgGmrijHI9JBAfqiOS W8uRyseDRw1MmUjJHM1hWvdQugnrSZGARUkfeB3u1xJ0owgZoABOhqS2jfo7hdG28aza Jbpw== X-Forwarded-Encrypted: i=1; AJvYcCXeTaZ9DSVIOWOgti/6fldZQIVKS5aylDUp3sBQ+gj/edLGdILpVWj6vmAcs0RCZyrKXe0A5ss=@vger.kernel.org X-Gm-Message-State: AOJu0YztNsM/Xzwy3sT2x+J3Qu4VneAUbdIjhP5+814kqFugmstTdcTo uhrXhPLl4+8XASGXZwjybRT7sgzIhpM3fFeOC45UG/19bMkcGztaHZ/vZ7ABK7U/vb1W5VdKfLS 3Q1TDPRSdPIObOshSiIfuS5egXEs+ssiFX61nFzCa41bNbS2yZpfygthwVV1FgyKph08= X-Gm-Gg: AZuq6aLOIuHuWloO2ahMwoUzQkeDhLJ12mUIKqEGZKcjnfv4eeh6Toz2OzkBD9BF4V0 8Eyypwo9z7cgWUDjJYHNIEwy6uxvs0jT5Qy5qEVDeQUqJrtfEafVrvjhXT92zZSX9nkpkNVVjEa Vw2ZH+AMU1tdGZbsgA8Ubiv7WpEHGGey5/49FARztpE3uEl1E2qzoxaPRPJGLusy63F3pY4uWUa +6CYFOfkg+T5OY8+uMLAQyUtxHC7j5Q57VJCFBG3gazEFfY4Uj+MDxXF4hkYRl01UanVQBBy+S1 QRvK93Rxyt45LOjIDiNsr4avtztMoRTMGjh53xBoGi4pqh0/Ow6rUrnwFJJyjJBYpr5XCqlWUt5 nDU5PxQ5XY4pLEueKsznoNVgiKpXtIc8PQL8= X-Received: by 2002:a17:903:1a44:b0:2a9:62f1:3fbb with SMTP id d9443c01a7336-2ab505b61bbmr154642375ad.37.1771353307771; Tue, 17 Feb 2026 10:35:07 -0800 (PST) X-Received: by 2002:a17:903:1a44:b0:2a9:62f1:3fbb with SMTP id d9443c01a7336-2ab505b61bbmr154642075ad.37.1771353307166; Tue, 17 Feb 2026 10:35:07 -0800 (PST) Received: from oss.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ad1a713d5dsm180261815ad.29.2026.02.17.10.35.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Feb 2026 10:35:06 -0800 (PST) Date: Wed, 18 Feb 2026 00:05:00 +0530 From: Mohd Ayaan Anwar To: "Russell King (Oracle)" Cc: Alexandre Torgue , Andrew Lunn , "David S. Miller" , Eric Dumazet , Frank Li , imx@lists.linux.dev, Jakub Kicinski , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, Maxime Chevallier , netdev@vger.kernel.org, Paolo Abeni , Pengutronix Kernel Team , Sascha Hauer , Vinod Koul Subject: Re: [PATCH RFC net-next 2/9] net: stmmac: qcom-ethqos: remove register field value obfuscations Message-ID: References: Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Proofpoint-GUID: sAtGLqRElITppIj7WcxusB1-WV2lLzcW X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjE3MDE1MSBTYWx0ZWRfX/JzpXimYWxMP kVvwORpfS7OZe9j6AGXlhB0QE/DXxdaCoNblU74WnRv/eR1rMS32oJZhxmRjm/dqo7O4KaBr4RN R0KPSxboi3IBf0ADXY8dWuLdc5cScN4MgeXkRAo90w2GlIxhm4Qx/lb9i5AvJ7HNJ4u0598O1t6 r3081bCFj9zgViOzXVz1pcqh6VEf7+2qoehi9m3QaHNXwXSobLoBww7aOZTLEmLT+gM/UMalJhv I+0G5oroAGXyC+RKkB/B7JO33vB0bBytn8LsV4XACHO3UHkUfl4vuPfkk1H2TmbUuOcbLSOgQzV vzVtOTUquFH4BfdT21iU6jyLlbEF94ZR4+GnXBrljXz8NS6vCft/5z2MiHFQHn0pIoZLvJ47EGS xmIkjglC4fmMQu5Gdg29n7pORmFtIWCmWidHproRuVcG2hfL9GYsAXic9z9II5nYiRaqplWuir6 ev5n6x1aN8+7BY9fN/A== X-Proofpoint-ORIG-GUID: sAtGLqRElITppIj7WcxusB1-WV2lLzcW X-Authority-Analysis: v=2.4 cv=IOoPywvG c=1 sm=1 tr=0 ts=6994b4dd cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=kj9zAlcOel0A:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=PHq6YzTAAAAA:8 a=EUspDBNiAAAA:8 a=eMU2cjtvKFU-KvXMnqsA:9 a=CjuIK1q_8ugA:10 a=GvdueXVYPmCkWapjIL-Q:22 a=ZKzU8r6zoKMcqsNulkmm:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-17_03,2026-02-16_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 spamscore=0 lowpriorityscore=0 adultscore=0 clxscore=1015 suspectscore=0 malwarescore=0 bulkscore=0 phishscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602170151 On Thu, Feb 12, 2026 at 12:17:51AM +0000, Russell King (Oracle) wrote: > Convert the register field values to something more human readable. > > For example, using (BIT(29) | BIT(27)) to update a register field that > consists of bits 29:27 is an obfuscated way of writing decimal 5 for > this field. The comment above needs to explain that this value is 5. > > Worse still is BIT(12) | GENMASK(9, 8), which is used to hide the > decimal value 19 for the bitfield 16:8. > > Fix these, and a few others by using FIELD_PREP(). While it means we > have bare numeric constants, this is more preferable than having the > obfuscation. > > Signed-off-by: Russell King (Oracle) Reviewed-by: Mohd Ayaan Anwar Ayaan