From: Mohd Ayaan Anwar <mohd.anwar@oss.qualcomm.com>
To: "Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>
Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>, Frank Li <Frank.Li@nxp.com>,
imx@lists.linux.dev, Jakub Kicinski <kuba@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
Maxime Chevallier <maxime.chevallier@bootlin.com>,
netdev@vger.kernel.org, Paolo Abeni <pabeni@redhat.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Sascha Hauer <s.hauer@pengutronix.de>,
Vinod Koul <vkoul@kernel.org>
Subject: Re: [PATCH RFC net-next 5/9] net: stmmac: qcom-ethqos: move loopback disable to .mac_finish()
Date: Wed, 18 Feb 2026 00:08:08 +0530 [thread overview]
Message-ID: <aZS1kIrwBFdwH8Zw@oss.qualcomm.com> (raw)
In-Reply-To: <E1vqKPG-000000093mZ-2CL3@rmk-PC.armlinux.org.uk>
On Thu, Feb 12, 2026 at 12:18:06AM +0000, Russell King (Oracle) wrote:
> Loopback is enabled to allow the dwmac soft reset to succeed. This
> is enabled when clocks are enabled in ethqos_clks_config(), which
> happens at driver probe and runtime PM resume - e.g. when the
> network device is administratively brought up.
>
> Currently, the loopback is disabled when the link comes up (via
> .mac_link_up() calling this driver's .fix_mac_speed().)
>
> Move the qcom_ethqos_set_sgmii_loopback() call which disables
> loopback from ethqos_fix_mac_speed() into ethqos' SerDes specific
> .mac_finish() method so that loopback is disabled a little earlier
> after reset has completed, and dwmac setup has completed.
>
> Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Reviewed-by: Mohd Ayaan Anwar <mohd.anwar@oss.qualcomm.com>
Ayaan
next prev parent reply other threads:[~2026-02-17 18:38 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-12 0:09 [PATCH RFC net-next 0/9] net: stmmac: qcom-ethqos: cleanups and re-organise SerDes handling Russell King (Oracle)
2026-02-12 0:17 ` [PATCH RFC net-next 1/9] net: stmmac: qcom-ethqos: rename "por" memebers to "rgmii_por" Russell King (Oracle)
2026-02-17 18:34 ` Mohd Ayaan Anwar
2026-02-12 0:17 ` [PATCH RFC net-next 2/9] net: stmmac: qcom-ethqos: remove register field value obfuscations Russell King (Oracle)
2026-02-17 18:35 ` Mohd Ayaan Anwar
2026-02-12 0:17 ` [PATCH RFC net-next 3/9] net: stmmac: qcom-ethqos: change ethqos_configure*() to return void Russell King (Oracle)
2026-02-17 18:35 ` Mohd Ayaan Anwar
2026-02-12 0:18 ` [PATCH RFC net-next 4/9] net: stmmac: qcom-ethqos: move qcom_ethqos_set_sgmii_loopback() up Russell King (Oracle)
2026-02-17 18:37 ` Mohd Ayaan Anwar
2026-02-12 0:18 ` [PATCH RFC net-next 5/9] net: stmmac: qcom-ethqos: move loopback disable to .mac_finish() Russell King (Oracle)
2026-02-17 18:38 ` Mohd Ayaan Anwar [this message]
2026-02-12 0:18 ` [PATCH RFC net-next 6/9] net: stmmac: pass interface mode into fix_mac_speed() method Russell King (Oracle)
2026-02-12 16:26 ` Maxime Chevallier
2026-02-12 0:18 ` [PATCH RFC net-next 7/9] net: stmmac: qcom-ethqos: pass phy interface mode to configs Russell King (Oracle)
2026-02-17 18:39 ` Mohd Ayaan Anwar
2026-02-12 0:18 ` [PATCH RFC net-next 8/9] net: stmmac: qcom-ethqos: use phy interface mode for inband Russell King (Oracle)
2026-02-17 18:40 ` Mohd Ayaan Anwar
2026-02-12 0:18 ` [PATCH RFC net-next 9/9] net: stmmac: qcom-ethqos: move SerDes speed configuration Russell King (Oracle)
2026-02-17 18:40 ` Mohd Ayaan Anwar
2026-02-13 19:21 ` [PATCH RFC net-next 0/9] net: stmmac: qcom-ethqos: cleanups and re-organise SerDes handling Mohd Ayaan Anwar
2026-02-16 15:42 ` Russell King (Oracle)
2026-02-17 10:21 ` Vinod Koul
2026-02-17 18:30 ` Mohd Ayaan Anwar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aZS1kIrwBFdwH8Zw@oss.qualcomm.com \
--to=mohd.anwar@oss.qualcomm.com \
--cc=Frank.Li@nxp.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=s.hauer@pengutronix.de \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox