[PATCH net] bnge: Fix typo

[PATCH net] bnge: Fix typo

[Vikas Gupta]

Fix the HWRM command type and use the appropriate command to reserve
the resources.

Fixes: 627c67f038d2 ("bng_en: Add resource management support")
Signed-off-by: Vikas Gupta <vikas.gupta@broadcom.com>
Reviewed-by: Bhargava Chenna Marreddy <bhargava.marreddy@broadcom.com>
---
 drivers/net/ethernet/broadcom/bnge/bnge_hwrm_lib.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_hwrm_lib.c b/drivers/net/ethernet/broadcom/bnge/bnge_hwrm_lib.c
index 84c90a957719..91a4ef9e3150 100644
--- a/drivers/net/ethernet/broadcom/bnge/bnge_hwrm_lib.c
+++ b/drivers/net/ethernet/broadcom/bnge/bnge_hwrm_lib.c
@@ -442,7 +442,7 @@ __bnge_hwrm_reserve_pf_rings(struct bnge_dev *bd, struct bnge_hw_rings *hwr)
 	struct hwrm_func_cfg_input *req;
 	u32 enables = 0;
 
-	if (bnge_hwrm_req_init(bd, req, HWRM_FUNC_QCFG))
+	if (bnge_hwrm_req_init(bd, req, HWRM_FUNC_CFG))
 		return NULL;
 
 	req->fid = cpu_to_le16(0xffff);
-- 
2.47.1

Re: [PATCH net] bnge: Fix typo

[Simon Horman]

On Mon, Feb 16, 2026 at 07:32:35PM +0530, Vikas Gupta wrote:
> Fix the HWRM command type and use the appropriate command to reserve
> the resources.
> 
> Fixes: 627c67f038d2 ("bng_en: Add resource management support")
> Signed-off-by: Vikas Gupta <vikas.gupta@broadcom.com>
> Reviewed-by: Bhargava Chenna Marreddy <bhargava.marreddy@broadcom.com>

Hi,

I think this patch could do with a little more explanation.
It's not clear to me, at least: what the difference is between
HWRM_FUNC_QCFG and HWRM_FUNC_CFG; and why only one of
the instances added by the cited patch needs updating.

...

Re: [PATCH net] bnge: Fix typo

[Vikas Gupta]

[-- Attachment #1: Type: text/plain, Size: 1072 bytes --]

Hi Simon,

On Tue, Feb 17, 2026 at 9:26 PM Simon Horman <horms@kernel.org> wrote:
>
> On Mon, Feb 16, 2026 at 07:32:35PM +0530, Vikas Gupta wrote:
> > Fix the HWRM command type and use the appropriate command to reserve
> > the resources.
> >
> > Fixes: 627c67f038d2 ("bng_en: Add resource management support")
> > Signed-off-by: Vikas Gupta <vikas.gupta@broadcom.com>
> > Reviewed-by: Bhargava Chenna Marreddy <bhargava.marreddy@broadcom.com>
>
> Hi,
>
> I think this patch could do with a little more explanation.
> It's not clear to me, at least: what the difference is between
> HWRM_FUNC_QCFG and HWRM_FUNC_CFG; and why only one of
> the instances added by the cited patch needs updating.

HWRM_FUNC_CFG is used to reserve resources, whereas HWRM_FUNC_QCFG is intended
for querying resource information from the firmware.
Since __bnge_hwrm_reserve_pf_rings() reserves resources for a specific
PF, the command type
should be HWRM_FUNC_CFG.
However, HWRM_FUNC_QCFG was mistakenly used instead.
Does it clarify?

Thanks,
Vikas

>
> ...

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 5465 bytes --]

Re: [PATCH net] bnge: Fix typo

[Jakub Kicinski]

On Tue, 17 Feb 2026 23:13:47 +0530 Vikas Gupta wrote:
> On Tue, Feb 17, 2026 at 9:26 PM Simon Horman <horms@kernel.org> wrote:
> > On Mon, Feb 16, 2026 at 07:32:35PM +0530, Vikas Gupta wrote:  
> > > Fix the HWRM command type and use the appropriate command to reserve
> > > the resources.
> > >
> > > Fixes: 627c67f038d2 ("bng_en: Add resource management support")
> > > Signed-off-by: Vikas Gupta <vikas.gupta@broadcom.com>
> > > Reviewed-by: Bhargava Chenna Marreddy <bhargava.marreddy@broadcom.com>  
> >
> > I think this patch could do with a little more explanation.
> > It's not clear to me, at least: what the difference is between
> > HWRM_FUNC_QCFG and HWRM_FUNC_CFG; and why only one of
> > the instances added by the cited patch needs updating.  
> 
> HWRM_FUNC_CFG is used to reserve resources, whereas HWRM_FUNC_QCFG is intended
> for querying resource information from the firmware.
> Since __bnge_hwrm_reserve_pf_rings() reserves resources for a specific
> PF, the command type
> should be HWRM_FUNC_CFG.
> However, HWRM_FUNC_QCFG was mistakenly used instead.
> Does it clarify?

Yes, please add this to the commit message.

Also please improve the subject. Something like (just a guess):

	bnge: fix reserving resources from FW

"fix typo" sounds like you're fixing spelling in a comment, it's not at
all informative :/