From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 889AF2C11EE for ; Wed, 18 Feb 2026 09:26:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771406767; cv=none; b=enRso0H5W6cOuFl9HPs9XzxwRnIj2cnvzgM7qlZSQyG88c/+oSsrvWG06e2vsXLAsMacsF1Hs2uYyxrrCMyzK2UROoyn+ZAZrayQegoTo+/fUxRgq646D2VsM/leKCe2+pLJbeb6y1dgOYvIgj4MyiB6VfA7uWshTpQgTUc3p7E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771406767; c=relaxed/simple; bh=TLfKk2qADOrbfEuoBvhVTAIQXEmEQg3OyhClYssyi+c=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Zh33xL88Yb+Kq1ohTedpkuZvUKYHpjiN5HWc/f/wUA+ucQ5rXENvNlmXxnGfqXUrboeebdpG71qdUjitN3uE99azZ+ptxu077Jkko/gDjy+J3uTKmvUXHIqcRmZzfz398xB5M/L3Q0LmapDQlZgKvmgQkf4LbAlZh2YOGKCypMY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=rd25Sy6B; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="rd25Sy6B" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 69F13C19421; Wed, 18 Feb 2026 09:26:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1771406767; bh=TLfKk2qADOrbfEuoBvhVTAIQXEmEQg3OyhClYssyi+c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rd25Sy6BoRHD4/ffww6s9HAOxt1aJRcGlZVuLkXC1340br/EyvtvtNKzn9cq6Y9YB rzGXypO7d1nPBiW4mAg2gp80FS5nXuVmTZlboU5bwELH8GJTdcvgjSUd5Pqyk5qLxS Xak01NvEqNjC48nRlLUCFonz22EHPoujXM6XrnLBfRyMi12T3or+sfLvpZqsc0pYeo p2PgXOt8uSFvV2RnebrsWw2HcD0DbWtc5sPlQ0bKmy+A3j6BDC46J46/9ZgNbCxxu3 FIALwvy3I+YmiNcOIwVu4QQQl1C1PWG81fdfr87VnsfVT8xIg1yg3LY9kr8gnn2WuC KBNRph9BdlNug== Date: Wed, 18 Feb 2026 09:26:04 +0000 From: Simon Horman To: Aleksandr Loktionov Cc: intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com, netdev@vger.kernel.org Subject: Re: [PATCH iwl-next v2] ice: implement symmetric RSS hash configuration Message-ID: References: <20260217130039.1802805-1-aleksandr.loktionov@intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260217130039.1802805-1-aleksandr.loktionov@intel.com> On Tue, Feb 17, 2026 at 02:00:39PM +0100, Aleksandr Loktionov wrote: > The driver advertises symmetric RSS support via supported_input_xfrm > but ice_set_rxfh() ignored the input_xfrm parameter, making it > impossible to configure symmetric hashing. > > Fix ice_set_rxfh() to check rxfh->input_xfrm and call > ice_set_rss_hfunc() with ICE_AQ_VSI_Q_OPT_RSS_HASH_SYM_TPLZ when > RXH_XFRM_SYM_XOR is requested. > > Modify ice_set_rss_vsi_ctx() to use vsi->rss_hfunc instead of > hardcoding ICE_AQ_VSI_Q_OPT_RSS_HASH_TPLZ, and export it for > use by ice_set_rxfh(). > > The kernel requires get_rxfh_fields() to report symmetric hash > configurations when symmetric transforms are supported. Update > ice_get_rxfh_fields() to return symmetric field configuration > (src+dst IP and ports) for all flow types. > > Tested with tools/testing/selftests/drivers/net/hw/rss_input_xfrm.py > > Signed-off-by: Aleksandr Loktionov > --- > v1 -> v2 preserve valid symmetric RSS fields. Thanks for the update. Reviewed-by: Simon Horman