From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3B9862F49F6 for ; Thu, 19 Feb 2026 10:35:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771497328; cv=none; b=uzSHHFpCasooR9ilED3hiA2fEpTNw4XXgu3eRbu8pTmqhICuWVSNXWJ6uWpZDx0oeJ7r2sJKudCBdCTP6g9x3Fr7zczGZwzH9yZ3yWjXy06uwIp1ozInFcu28N0aWj3M2Y7QBs1EXIPRNj7QuHUwXkphzT+UUpZ/In4uchs8KOA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771497328; c=relaxed/simple; bh=JzgTJfCZThD8ADnrrzOcTouopRq3PU+mfSlCjHNTIqg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ueT5vjad0i6Drvd2WS917GJ/oIh5UIRpmGBOcsO++Zabrd42boTPRur8H2SkQlg1Trhka/HBdioZTbkVFBcJ1aH+FUQoyWZcA7aAh2empw/299VzXPXJR8fAAob8TYRfQnCed3vnh0ByRpwdhHbDW6OQDtKHn3AHgk3Ji32fFoA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=OnG8/tQg; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=oQV4QSAi; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="OnG8/tQg"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="oQV4QSAi" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1771497326; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3F3zYoVrT9qjM5rAq+b6pbd+/hnAt//GBzSEVJjvXTQ=; b=OnG8/tQggtNY3Lr8AVEqC7zh+Z9YSUah4pY0sWAoRIIuSTRkvgs6IF4gZ0p/eAp0HPkIJl AylTvKx/xPsLLPhd6v+kEDs83ueNQjuD48QiNLTnnCJ5RsSp1alM34hMg5nOA4tXb9SQ5D xXCtUegkUnaM24GQp9g9qfKoIwXmhYk= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-36-9zv9WUmNOFWKoLbahzWZsg-1; Thu, 19 Feb 2026 05:35:24 -0500 X-MC-Unique: 9zv9WUmNOFWKoLbahzWZsg-1 X-Mimecast-MFC-AGG-ID: 9zv9WUmNOFWKoLbahzWZsg_1771497323 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-435ab9ed85dso503302f8f.1 for ; Thu, 19 Feb 2026 02:35:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1771497323; x=1772102123; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=3F3zYoVrT9qjM5rAq+b6pbd+/hnAt//GBzSEVJjvXTQ=; b=oQV4QSAim8zkAt72BCdWOW/0atkiHhZffjQCtYsgFklc3kS/jwjCiz8u1e7HRW5oTk Wuv9hWwMByh8Msm3JXH3PJoq9LT/SkPDTNWr08vO4/QUVKyZ5Ef6pWjWLG/SGaar/x0S yUNvU0yGNfcEd+sd6IyJwSqnz1lnRE+oqlWP6drNX6iy52JR/THCXp86qo9MMdqmR6HB 9aHAbROjJoIxgfIgUhjHChfivheG1D8prFps4MwahKkkiCI/8DqBkdyJIr8ifNVepgJ1 EM2rgXoUInohlTguN+Y9HTXjJenj7LRm0Sntz03CRG3ZDhlzaJNpzgqhSrzTdYLCWCgQ vZYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771497323; x=1772102123; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3F3zYoVrT9qjM5rAq+b6pbd+/hnAt//GBzSEVJjvXTQ=; b=tUoBDYZcMb+dm3IXF3LbU+WchcClV/GHbZibk4FSsFoihPrvjBCqQsj5JkyXfzAwLE 3gVtY+tribKordjycBGBTpsa+Yb6cEYjfKkckM8MGfUFlpRxgYxXqHM3paSyb+q02zUO ZSXHfxFYMaH2rW4+nrgbfXKaAcuFf84O/EEVVkwswk9kDSrWea7UW3RO4gFsYkqXHKXd eqXVCXEDZOTI/TTs8K9WqrVOc5g7lN4BzySyup0F5TBBnX22dpnbzOxh9dVjA3VxTRXI kUA7ZnYnOv/fnr3jRruqY6IMYTKyd/vUJto9Tz65h6CisimpzD5Wb2Onn4nJPj1OSDdg hU6A== X-Forwarded-Encrypted: i=1; AJvYcCXY+RJKmQL/aNVDxeqEamCl/LwJeMGON2O9l9wbvrohtqKicbtt/xTvr9T6uZa5eCcE5geo2aw=@vger.kernel.org X-Gm-Message-State: AOJu0YxElUd9msN1HptABNWTneH/Pj8wxSAB+QEEoqv2mDiZOrT7KClt tPrTT+ihLeP97bzqYaiU/g2nlQz0TKkgRDMQjTtQHuY64/4jaMBW7YBS01dALv67fKtlJbNQe9l 3HZi5uJpqm8ccx6edzxtzcUGtyClmR2PPQEDMMs4IEY8CmhF2w4iRvdPTIg== X-Gm-Gg: AZuq6aJPRoa/EbH8aYP9M3exOazta020sJAKm0eZWKQgEZpY+Oqc1M8l7A8tY31ts4V WlyvSbFC5swyhoVx3L3Y0YXRGARqxLUi3FjVrwGGNBcqS8+2lsLuRSV7w/z6EGeS11NjpxmiZyF EcDW8hR04N03SrSfyCnhDZBTnbqbiCu79qXW5TadRcfRAELzzlODoeNSFomPN02Om7UETWnWU0H RNlK7SHqfPCdpepQDvrASwOpVLZashUJjRIJXprfIl0PV2fq+BzomM210mX5TFU6iAYJ7kJBB7b 3Vt9AKj39Sn5JgC6wHzisX/5v7OxIjjx6+MKXZFUiFbb9xDg5iG8VmwVoHKPLsHUnZfti/RmcMI bWONtCoOev7ZAqzDdKprWz7JmsSQTXdnotI815cGQYWCmP9s0jk5ayw4J/c0pOa85tIRg7aU= X-Received: by 2002:a05:600c:4eca:b0:483:6d4a:7e6d with SMTP id 5b1f17b1804b1-48379be60camr248733905e9.30.1771497323446; Thu, 19 Feb 2026 02:35:23 -0800 (PST) X-Received: by 2002:a05:600c:4eca:b0:483:6d4a:7e6d with SMTP id 5b1f17b1804b1-48379be60camr248733415e9.30.1771497322976; Thu, 19 Feb 2026 02:35:22 -0800 (PST) Received: from sgarzare-redhat (host-82-53-134-58.retail.telecomitalia.it. [82.53.134.58]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4839f96967bsm19658265e9.3.2026.02.19.02.35.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Feb 2026 02:35:21 -0800 (PST) Date: Thu, 19 Feb 2026 11:35:19 +0100 From: Stefano Garzarella To: Bobby Eshleman Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Stefan Hajnoczi , Shuah Khan , Bobby Eshleman , "Michael S. Tsirkin" , Jonathan Corbet , Shuah Khan , virtualization@lists.linux.dev, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [PATCH net v2 1/3] selftests/vsock: change tests to respect write-once child ns mode Message-ID: References: <20260218-vsock-ns-write-once-v2-0-19e4c50d509a@meta.com> <20260218-vsock-ns-write-once-v2-1-19e4c50d509a@meta.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20260218-vsock-ns-write-once-v2-1-19e4c50d509a@meta.com> On Wed, Feb 18, 2026 at 10:10:36AM -0800, Bobby Eshleman wrote: >From: Bobby Eshleman > >The child_ns_mode sysctl parameter becomes write-once in a future patch >in this series, which breaks existing tests. This patch updates the >tests to respect this new policy. No additional tests are added. > >Add "global-parent" and "local-parent" namespaces as intermediaries to >spawn namespaces in the given modes. This avoids the need to change >"child_ns_mode" in the init_ns. nsenter must be used because ip netns >unshares the mount namespace so nested "ip netns add" breaks exec calls >from the init ns. Adds nsenter to the deps check. > >Signed-off-by: Bobby Eshleman >--- > tools/testing/selftests/vsock/vmtest.sh | 35 +++++++++++++++------------------ > 1 file changed, 16 insertions(+), 19 deletions(-) Reviewed-by: Stefano Garzarella > >diff --git a/tools/testing/selftests/vsock/vmtest.sh b/tools/testing/selftests/vsock/vmtest.sh >index dc8dbe74a6d0..e1e78b295e41 100755 >--- a/tools/testing/selftests/vsock/vmtest.sh >+++ b/tools/testing/selftests/vsock/vmtest.sh >@@ -210,16 +210,17 @@ check_result() { > } > > add_namespaces() { >- local orig_mode >- orig_mode=$(cat /proc/sys/net/vsock/child_ns_mode) >+ ip netns add "global-parent" 2>/dev/null >+ echo "global" | ip netns exec "global-parent" \ >+ tee /proc/sys/net/vsock/child_ns_mode &>/dev/null >+ ip netns add "local-parent" 2>/dev/null >+ echo "local" | ip netns exec "local-parent" \ >+ tee /proc/sys/net/vsock/child_ns_mode &>/dev/null > >- for mode in "${NS_MODES[@]}"; do >- echo "${mode}" > /proc/sys/net/vsock/child_ns_mode >- ip netns add "${mode}0" 2>/dev/null >- ip netns add "${mode}1" 2>/dev/null >- done >- >- echo "${orig_mode}" > /proc/sys/net/vsock/child_ns_mode >+ nsenter --net=/var/run/netns/global-parent ip netns add "global0" 2>/dev/null >+ nsenter --net=/var/run/netns/global-parent ip netns add "global1" 2>/dev/null >+ nsenter --net=/var/run/netns/local-parent ip netns add "local0" 2>/dev/null >+ nsenter --net=/var/run/netns/local-parent ip netns add "local1" 2>/dev/null > } > > init_namespaces() { >@@ -237,6 +238,8 @@ del_namespaces() { > log_host "removed ns ${mode}0" > log_host "removed ns ${mode}1" > done >+ ip netns del "global-parent" &>/dev/null >+ ip netns del "local-parent" &>/dev/null > } > > vm_ssh() { >@@ -287,7 +290,7 @@ check_args() { > } > > check_deps() { >- for dep in vng ${QEMU} busybox pkill ssh ss socat; do >+ for dep in vng ${QEMU} busybox pkill ssh ss socat nsenter; do > if [[ ! -x $(command -v "${dep}") ]]; then > echo -e "skip: dependency ${dep} not found!\n" > exit "${KSFT_SKIP}" >@@ -1231,12 +1234,8 @@ test_ns_local_same_cid_ok() { > } > > test_ns_host_vsock_child_ns_mode_ok() { >- local orig_mode >- local rc >- >- orig_mode=$(cat /proc/sys/net/vsock/child_ns_mode) >+ local rc="${KSFT_PASS}" > >- rc="${KSFT_PASS}" > for mode in "${NS_MODES[@]}"; do > local ns="${mode}0" > >@@ -1246,15 +1245,13 @@ test_ns_host_vsock_child_ns_mode_ok() { > continue > fi > >- if ! echo "${mode}" > /proc/sys/net/vsock/child_ns_mode; then >- log_host "child_ns_mode should be writable to ${mode}" >+ if ! echo "${mode}" | ip netns exec "${ns}" \ >+ tee /proc/sys/net/vsock/child_ns_mode &>/dev/null; then > rc="${KSFT_FAIL}" > continue > fi > done > >- echo "${orig_mode}" > /proc/sys/net/vsock/child_ns_mode >- > return "${rc}" > } > > >-- >2.47.3 >