From: Guillaume Nault <gnault@redhat.com>
To: Qingfang Deng <dqfext@gmail.com>
Cc: linux-ppp@vger.kernel.org,
Michal Ostrowski <mostrows@earthlink.net>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Michal Ostrowski <mostrows@gmail.com>,
Dianne Skoll <dianne@skoll.ca>,
Paul Mackerras <paulus@ozlabs.org>, Jaco Kroon <jaco@uls.co.za>,
James Carlson <carlsonj@workingcode.com>,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH RFC net-next v2] pppoe: remove kernel-mode relay support
Date: Thu, 19 Feb 2026 15:06:46 +0100 [thread overview]
Message-ID: <aZcY9l35A-Yw8NYH@debian> (raw)
In-Reply-To: <20260213091605.132561-1-dqfext@gmail.com>
On Fri, Feb 13, 2026 at 05:16:04PM +0800, Qingfang Deng wrote:
> The kernel-mode PPPoE relay feature and its two associated ioctls
> (PPPOEIOCSFWD and PPPOEIOCDFWD) are not used by any existing userspace
> PPPoE implementations. The most commonly-used package, RP-PPPoE [1],
> handles the relaying entirely in userspace.
>
> This legacy code has remained in the driver since its introduction in
> kernel 2.3.99-pre7 for over two decades, but has served no practical
> purpose.
Also, this code was broken since its inception up to 2016, as it did
leak a socket reference in the normal data path (see commit 29e73269aa4d
("pppoe: fix reference counting in PPPoE proxy")). The bug was caught
by code inspection, which strongly suggests that nobody tried to use it
before that.
> Remove the unused relay code.
Reviewed-by: Guillaume Nault <gnault@redhat.com>
prev parent reply other threads:[~2026-02-19 14:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-13 9:16 [PATCH RFC net-next v2] pppoe: remove kernel-mode relay support Qingfang Deng
2026-02-13 10:11 ` Arnd Bergmann
2026-02-19 14:06 ` Guillaume Nault [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aZcY9l35A-Yw8NYH@debian \
--to=gnault@redhat.com \
--cc=andrew+netdev@lunn.ch \
--cc=arnd@arndb.de \
--cc=carlsonj@workingcode.com \
--cc=davem@davemloft.net \
--cc=dianne@skoll.ca \
--cc=dqfext@gmail.com \
--cc=edumazet@google.com \
--cc=jaco@uls.co.za \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ppp@vger.kernel.org \
--cc=mostrows@earthlink.net \
--cc=mostrows@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=paulus@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox