From: Mohd Ayaan Anwar <mohd.anwar@oss.qualcomm.com>
To: "Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>
Cc: Andrew Lunn <andrew@lunn.ch>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
linux-stm32@st-md-mailman.stormreply.com,
Neil Armstrong <neil.armstrong@linaro.org>,
netdev@vger.kernel.org, Paolo Abeni <pabeni@redhat.com>,
Vinod Koul <vkoul@kernel.org>
Subject: Re: [PATCH RFC net-next+ 4/9] net: stmmac: qcom-ethqos: convert to use phy_set_mode_ext()
Date: Mon, 23 Feb 2026 15:14:31 +0530 [thread overview]
Message-ID: <aZwhfzkk740kUegR@oss.qualcomm.com> (raw)
In-Reply-To: <E1vt3US-0000000A5eE-1RHM@rmk-PC.armlinux.org.uk>
Hi Russell,
On Thu, Feb 19, 2026 at 12:50:44PM +0000, Russell King (Oracle) wrote:
> @@ -675,20 +676,16 @@ static int ethqos_mac_finish_serdes(struct net_device *ndev, void *priv,
> phy_interface_t interface)
> {
> struct qcom_ethqos *ethqos = priv;
> - int speed, ret = 0;
> + int ret = 0;
>
> qcom_ethqos_set_sgmii_loopback(ethqos, false);
>
> - speed = SPEED_UNKNOWN;
> - if (interface == PHY_INTERFACE_MODE_SGMII)
> - speed = SPEED_1000;
> - else if (interface == PHY_INTERFACE_MODE_2500BASEX)
> - speed = SPEED_2500;
> -
> - if (speed != SPEED_UNKNOWN && speed != ethqos->serdes_speed) {
> - ret = phy_set_speed(ethqos->serdes_phy, speed);
> + if (interface == PHY_INTERFACE_MODE_SGMII ||
> + interface == PHY_INTERFACE_MODE_2500BASEX) {
> + ret = phy_set_mode(ethqos->serdes_phy, PHY_MODE_ETHERNET,
> + interface);
Shouldn't this be phy_set_mode_ext()?
Ayaan
next prev parent reply other threads:[~2026-02-23 9:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-19 12:49 [PATCH RFC net-next+previous 0/9] net: stmmac: qcom-ethqos: further updates Russell King (Oracle)
2026-02-19 12:50 ` [PATCH RFC net-next+ 1/9] net: stmmac: qcom-ethqos: convert to set_clk_tx_rate() method Russell King (Oracle)
2026-02-19 12:50 ` [PATCH RFC net-next+ 2/9] net: stmmac: qcom-ethqos: move ethqos_set_serdes_speed() Russell King (Oracle)
2026-02-23 9:52 ` Mohd Ayaan Anwar
2026-02-19 12:50 ` [PATCH RFC net-next+ 3/9] phy: qcom-sgmii-eth: add .set_mode() and .validate() methods Russell King (Oracle)
2026-02-19 12:50 ` [PATCH RFC net-next+ 4/9] net: stmmac: qcom-ethqos: convert to use phy_set_mode_ext() Russell King (Oracle)
2026-02-23 9:44 ` Mohd Ayaan Anwar [this message]
2026-02-19 12:50 ` [PATCH RFC net-next+ 5/9] phy: qcom-sgmii-eth: remove .set_speed() implementation Russell King (Oracle)
2026-02-19 12:50 ` [PATCH RFC net-next+ 6/9] phy: qcom-sgmii-eth: use PHY interface mode for SerDes settings Russell King (Oracle)
2026-02-19 12:50 ` [PATCH RFC net-next+ 7/9] phy: qcom-sgmii-eth: remove qcom_dwmac_sgmii_phy_interface() Russell King (Oracle)
2026-02-19 12:51 ` [PATCH RFC net-next+ 8/9] phy: qcom-sgmii-eth: relax order of .power_on() vs .set_mode*() Russell King (Oracle)
2026-02-19 12:51 ` [PATCH RFC net-next+ 9/9] net: stmmac: qcom-ethqos: remove phy_set_mode_ext() after phy_power_on() Russell King (Oracle)
2026-02-23 9:54 ` Mohd Ayaan Anwar
2026-02-23 9:49 ` [PATCH RFC net-next+previous 0/9] net: stmmac: qcom-ethqos: further updates Mohd Ayaan Anwar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aZwhfzkk740kUegR@oss.qualcomm.com \
--to=mohd.anwar@oss.qualcomm.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=neil.armstrong@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox