From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 92E0E35A93B for ; Mon, 23 Feb 2026 09:54:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771840465; cv=none; b=tscC3ZJ4rZuHDlA83GCXMWhuXcKodTsjZBN4qEmdZ50lk6k33V/+f+Dg3oWcPiD808W4lNboaK6Ghu4NmVZh3sYPUJtFvptsV7AxMWJhoIXZqCA/XhRx7uLZt/+nAuKdmuWQiM2PJOVgWEyBQfq54noRmkg5/D7oxb6TG4LNOLo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771840465; c=relaxed/simple; bh=Icnu1d1RncN+al6ldVgN2HADlKwEOFX2otQVBPAHv3o=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Am95j2CIRWU4IzzU2/mAHa2pOEADhz6Sb3VKXwu7Dx04vY4HhuEstFY2hhvBYaImXVXFKtMwHMCLp6JRPEhqFhYHa1TD0YvoXc6YltGa3oXbbymEOOQIT2bhvoFkoxqTKN3dEMuyFa7gsNFM9TO7Y0jKvoa+OKoQ6i0AbJ8lqso= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=BDEBQYHN; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=DdYjEoNg; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="BDEBQYHN"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="DdYjEoNg" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61N9BgbM1249093 for ; Mon, 23 Feb 2026 09:54:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=pMJwRoenSFg2hWtcaGyYH8c9 1ypYkTPXJQa7dQ0lvIo=; b=BDEBQYHNvvIodIsKxbVwYcsC/q55fMTVS8gWXSn1 MvlVMX+3JOBrmIW2f0FYtqQF0zbS7d3tCBxxVzCURPXuzIIfBLsqHHP/YLgnjWi9 OiZUT+7M00nUxbDFIWgxX/bOW8X7GQ3tk0EX62ZL2++o7vr12d05QZszV+TiDlLa PC/IELJi2W/iuEr3GvdymOFzrOSReh8b/OMzDkuIxfVQuRGAElNfz0FcMahEgEtp 9hnnBQ59d9E9TY+up3xVynDcHVGEoGVevKt3NxQ10pBbWXL52sJYSBwqsdDM4Sl0 RWr/t+bjK7Pr7g+CfHSUjWoTcVaROPZPUNPWBjGJrd3SLQ== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cf5u9v8em-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 23 Feb 2026 09:54:23 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2aaeafeadbcso49143315ad.1 for ; Mon, 23 Feb 2026 01:54:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1771840462; x=1772445262; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=pMJwRoenSFg2hWtcaGyYH8c91ypYkTPXJQa7dQ0lvIo=; b=DdYjEoNgWqrPSxURSclKJhZXGWZsc+JV28ky6ETIzket3fnfAyOOp7V4KgC/X8dmaU 1QS55G7HZ/fSdwwV8rTkfZtMIAoZe2OeXDSkDc/oJJXNzgRM0xGgwHqYHG4g6+RH0X+8 XINzYRAaLOq5f0sL1ywNH6h5ya3YOn1Bt8Vexz02pdut5jdXsQLHTlG3FIsOsYwxKS/m uw8DQp6tB6apt5LhN1VKysLOOFAI0PcrjllJOTv89GETvbUKT336FL9ENa4ZwqxXmReY TpKShepQw248XVuvYAmBQU8kcuT4CAph0mVNsU7puKEMvE/EwKpQ4kkxqccquVvyYtWh vKVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771840462; x=1772445262; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pMJwRoenSFg2hWtcaGyYH8c91ypYkTPXJQa7dQ0lvIo=; b=dZkOBxZSRgWt8jcV2JkT2c7iq4xGFyFW0HOjHF5QxkhTDf3wGKZKQQGwLM4kLO3y5R nYRf52p2vB1Png1RkCtoaDiCRo5UXi6EHx9W7p3vj5BRV7G9QBkoKB5vLLTbZjxEEVmc PwGbE488Bzz18duoBlJLivWIaS85x4JSNMgLKX2yeljNFzNXZ8oRS3mKMY6H4yo7+mhx 2PK/y+XgyDcuFbcCQSKJQbgH0d2XeX7bsVv/iO8rhtyLDQKWdeFUe1CUJkSLuo6KWUIv JwSmogLKM4I8SffblBnfy7W8Q9vd1omjWhQFatxOJK5K4z3jkLD4EGSeJi1yrO22fplu X99g== X-Forwarded-Encrypted: i=1; AJvYcCUJqpTIsP+giCnoRxU5yXcXCaTE9gOapJ+wbWh6UhSGFkTpoH4NTen65YdgzHfY0Ex/z+DuqPM=@vger.kernel.org X-Gm-Message-State: AOJu0Yzc7vEQP8jGMhw/0R8Vc1ljtJp9D3iNf7DTsu4sW1UwgwCfxFVb zbLDyKHeqxfmO18dmyq5xVYi0NpvSnIFDTuT7ZyF1CHpZDFVn/KG17fC5rsovRudIEl+XwhyW9Z UXOjDA8D7o1xxCHHUeEdTW6NdMCyFXQtPurhr7U9UGdvLFYdNz9meEqKAYyk= X-Gm-Gg: ATEYQzwEiySQQpqpSy+A+FC9/S/I+QW6SeElyFEU0OJeSfqCQP7/8nEy8JMdanAkykd RTwUqC+58I4Bm/E0PnSfEjtToiGQicQfzt8KgOLwGtWu9SpVybbZNJpNHXzToHKmJclLMniKsRp 6+IIcJ3DMyEvvmHKI9NVwSUXK3aG058I8PNh6h3i7/tHuTyqULEC1CS+BVXh4M2KcHxLOENfzIv xBIHTQcN3nwb2K+aq5UDXK3lf55YWiaqYDmo5roWrWkYgR+dhtKg2LunoobBfNiVEg+P9hPd3Nx xxo0198XpREjqiFqIasBgLjjOwcr6OEKL2MDaHV9tuCLN1nAZu9Rjajfn/c5BSH/zh7dVnNTYzV ZNDV76B8nIxTAkRZmQL53CnOKfslLp+prnEk= X-Received: by 2002:a17:90b:48ce:b0:340:ec6f:5ac5 with SMTP id 98e67ed59e1d1-358ae7c3134mr5861407a91.2.1771840462347; Mon, 23 Feb 2026 01:54:22 -0800 (PST) X-Received: by 2002:a17:90b:48ce:b0:340:ec6f:5ac5 with SMTP id 98e67ed59e1d1-358ae7c3134mr5861383a91.2.1771840461811; Mon, 23 Feb 2026 01:54:21 -0800 (PST) Received: from oss.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-358af93b9d1sm6128924a91.15.2026.02.23.01.54.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Feb 2026 01:54:21 -0800 (PST) Date: Mon, 23 Feb 2026 15:24:15 +0530 From: Mohd Ayaan Anwar To: "Russell King (Oracle)" Cc: Andrew Lunn , Alexandre Torgue , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, Neil Armstrong , netdev@vger.kernel.org, Paolo Abeni , Vinod Koul Subject: Re: [PATCH RFC net-next+ 9/9] net: stmmac: qcom-ethqos: remove phy_set_mode_ext() after phy_power_on() Message-ID: References: Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjIzMDA4NCBTYWx0ZWRfX8VsrpoDmuOw1 HTZDrr9kASb09m8NwQglZEr/48p1Py0xcI/Od2epcmoEP+ITkNhxZsGjC9+RZ5IWj3oWs2zxfEM Pir+2SaVK5MA89FLIEolSQ9eelyW2B8qbzVcrHUMHSoI8BlDbX4tKsSgyzcq72qwp0fe+CKqnL+ AfZ4a1w402YZDJpDWzRW7CoLkQlktojiNj9iZFYk3uhM0r7cFjbRqa5bOTHRfWgND6lYXXn0SQN v4SYr1QroUxI1Nw/jsX7t328aLIH1Amw6bmCyA4kAZ8zP2sMUNAccPBZ1OZefeW313+NIGpAjoG +zh6C9FhxEThAeTEn/BLfOXYCaglDTZtVGmZcLwQ/OLPvjc1tQnaZ4WWZePXRG8FW3J0lBiZZq3 81DZ96fyLxTZic9QVkw7mN19jnc4fF+qOsBdXYcOcVdWmTTotwzmP3enlCkmZO9uYcd9vFchO+7 eT4vD8lSX9pVjuHtr3g== X-Proofpoint-GUID: mmSvE5TZB9k8KQ8XHTtckNQX4znPD3uT X-Proofpoint-ORIG-GUID: mmSvE5TZB9k8KQ8XHTtckNQX4znPD3uT X-Authority-Analysis: v=2.4 cv=RpDI7SmK c=1 sm=1 tr=0 ts=699c23cf cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=kj9zAlcOel0A:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=PHq6YzTAAAAA:8 a=EUspDBNiAAAA:8 a=_j33rwhWCIcg66mWb4UA:9 a=CjuIK1q_8ugA:10 a=GvdueXVYPmCkWapjIL-Q:22 a=ZKzU8r6zoKMcqsNulkmm:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-23_02,2026-02-20_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 adultscore=0 suspectscore=0 clxscore=1015 spamscore=0 bulkscore=0 impostorscore=0 phishscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2602230084 On Thu, Feb 19, 2026 at 12:51:10PM +0000, Russell King (Oracle) wrote: > The call to phy_set_mode_ext() after phy_power_on() was a work-around > for the qcom-sgmii-eth SerDes driver that only re-enabled its clocks on > phy_power_on() but did not configure the PHY. Now that the SerDes driver > fully configures the SerDes at phy_power_on(), there is no need to call > phy_set_mode_ext() immediately afterwards. > > This also means we no longer need to record the previous operating mode > of the driver - this is up to the SerDes driver. In any case, the only > thing that we care about is the SerDes provides the necessary clocks to > the stmmac core to allow it to reset at this point. The actual mode is > irrelevant at this point as the correct mode will be configured in > ethqos_mac_finish_serdes() just before the network device is brought > online. > > Signed-off-by: Russell King (Oracle) > --- > .../stmicro/stmmac/dwmac-qcom-ethqos.c | 18 ++---------------- > 1 file changed, 2 insertions(+), 16 deletions(-) > Reviewed-by: Mohd Ayaan Anwar Ayaan