From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pidgin.makrotopia.org (pidgin.makrotopia.org [185.142.180.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E76343502BA; Mon, 23 Feb 2026 23:12:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.142.180.65 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771888348; cv=none; b=Ea6sebHm545j54w2si6NdY4vHX9yUZR8IGCzpVaaurLr+yNsgWoEaerHYCa/UTZh40/l3WpGZcb3E+vFdydku3KJulJ62vb24+uwpCrmU/8G+H8s2bVAKG9XF9zzc6VkQ2nNodqeoydPi6T0hWY4jXo+jZjZzr/bdqYFeLFAdTk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771888348; c=relaxed/simple; bh=pnvJv1+/1g6KH6AlmPTZRGIvK0vkhCQ0O1avFyhYKUw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=GTmO/075GEoo1BOiXbWBZI5OaqJeK7KCghIIF2YNgas3klGqL2RA1Vn97E+NGm3Jq8pb1GSU2jcuXr1ggt0E8WjTwLg2XyrpvF7VBkVbTHjPHLrPbElm+GiUBH7NihX4N1AFlWjQl5QwiLK+hEgZPPcMVejjhP6F6LRjZX/Drk0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=makrotopia.org; spf=pass smtp.mailfrom=makrotopia.org; arc=none smtp.client-ip=185.142.180.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=makrotopia.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=makrotopia.org Received: from local by pidgin.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.99) (envelope-from ) id 1vuf61-000000000yO-0Opd; Mon, 23 Feb 2026 23:12:09 +0000 Date: Mon, 23 Feb 2026 23:12:04 +0000 From: Daniel Golle To: Bart Van Assche Cc: Peter Zijlstra , Ingo Molnar , Will Deacon , Boqun Feng , Waiman Long , linux-kernel@vger.kernel.org, Marco Elver , Christoph Hellwig , Steven Rostedt , Nick Desaulniers , Nathan Chancellor , Kees Cook , Jann Horn , Bart Van Assche , Andrew Lunn , Jakub Kicinski , Xu Liang , netdev@vger.kernel.org Subject: Re: [PATCH 23/62] net: phy: mxl-86110: Fix locking in an error path Message-ID: References: <20260223220102.2158611-1-bart.vanassche@linux.dev> <20260223220102.2158611-24-bart.vanassche@linux.dev> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260223220102.2158611-24-bart.vanassche@linux.dev> On Mon, Feb 23, 2026 at 02:00:23PM -0800, Bart Van Assche wrote: > From: Bart Van Assche > > Only call phy_unlock_mdio_bus() if phy_lock_mdio_bus() has been called > first. This has been detected by the Clang thread-safety analyzer. > > Cc: Daniel Golle > Cc: Andrew Lunn > Cc: Jakub Kicinski > Cc: Xu Liang > Cc: netdev@vger.kernel.org > Fixes: 3d1b3f4ffc0a ("net: phy: mxl-86110: add basic support for MxL86111 PHY") > Signed-off-by: Bart Van Assche Reviewed-by: Daniel Golle > --- > drivers/net/phy/mxl-86110.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/phy/mxl-86110.c b/drivers/net/phy/mxl-86110.c > index 42a5fe3f115f..d010b023f7b9 100644 > --- a/drivers/net/phy/mxl-86110.c > +++ b/drivers/net/phy/mxl-86110.c > @@ -891,7 +891,7 @@ static int mxl86111_config_inband(struct phy_device *phydev, unsigned int modes) > MII_BMCR, BMCR_ANENABLE, > (modes == LINK_INBAND_DISABLE) ? 0 : BMCR_ANENABLE); > if (ret < 0) > - goto out; > + return ret; > > phy_lock_mdio_bus(phydev); >