From: Eric Dumazet <eric.dumazet@gmail.com>
To: David Miller <davem@davemloft.net>, lorenzo@google.com
Cc: netdev@vger.kernel.org, astrachan@google.com,
subashab@codeaurora.org, dsa@cumulusnetworks.com
Subject: Re: [PATCH net] net: diag: Don't double-free TCP_NEW_SYN_RECV sockets in tcp_abort
Date: Sat, 7 Jul 2018 06:58:28 -0700 [thread overview]
Message-ID: <aa156e24-d642-380b-bf83-cff911ceb034@gmail.com> (raw)
In-Reply-To: <f3c8139d-ce4d-473a-b786-82ec7a7da7ce@gmail.com>
On 07/07/2018 06:29 AM, Eric Dumazet wrote:
>
>
> On 07/07/2018 06:11 AM, David Miller wrote:
>> From: Lorenzo Colitti <lorenzo@google.com>
>> Date: Sat, 7 Jul 2018 16:31:40 +0900
>>
>>> Tested: passes Android sock_diag_test.py, which exercises this codepath
>>
>> If this Android test case exercises this path, why didn't it trigger
>> the double free and thus cause this bug to be found much sooner?
>>
>> Just curious.
>>
>
> Presumably android has not backported yet the refcount_t stuff in their kernels.
>
> That is a guess though...
>
Also maybe the confusion comes from the fact that it is not a double free,
but a use-after-free, which might cause a bug on kernels without
refcount_t saturation.
next prev parent reply other threads:[~2018-07-07 13:58 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-07 7:31 [PATCH net] net: diag: Don't double-free TCP_NEW_SYN_RECV sockets in tcp_abort Lorenzo Colitti
2018-07-07 13:11 ` David Miller
2018-07-07 13:29 ` Eric Dumazet
2018-07-07 13:58 ` Eric Dumazet [this message]
2018-07-09 4:53 ` Lorenzo Colitti
2018-07-09 14:59 ` David Ahern
2018-07-09 15:17 ` Eric Dumazet
2018-07-09 16:14 ` David Ahern
2018-07-09 16:21 ` Eric Dumazet
2018-07-07 13:33 ` David Ahern
2018-07-07 13:45 ` Eric Dumazet
2018-07-07 13:51 ` Eric Dumazet
2018-07-07 13:56 ` David Ahern
2018-07-07 14:16 ` Eric Dumazet
2018-07-07 14:19 ` Eric Dumazet
2018-07-09 5:24 ` Lorenzo Colitti
2018-07-09 15:00 ` David Ahern
2018-07-07 13:28 ` Eric Dumazet
2018-07-07 22:07 ` David Ahern
2018-07-08 1:57 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa156e24-d642-380b-bf83-cff911ceb034@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=astrachan@google.com \
--cc=davem@davemloft.net \
--cc=dsa@cumulusnetworks.com \
--cc=lorenzo@google.com \
--cc=netdev@vger.kernel.org \
--cc=subashab@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).