From: Gal Pressman <gal@nvidia.com>
To: Martin KaFai Lau <martin.lau@linux.dev>
Cc: kuba@kernel.org, Daniel Borkmann <daniel@iogearbox.net>,
ast@kernel.org, bpf@vger.kernel.org, netdev@vger.kernel.org,
syzbot+bdcf141f362ef83335cf@syzkaller.appspotmail.com,
syzbot+b202b7208664142954fa@syzkaller.appspotmail.com,
syzbot+14736e249bce46091c18@syzkaller.appspotmail.com
Subject: Re: [PATCH net-next] tcx: Fix splat in ingress_destroy upon tcx_entry_free
Date: Sun, 6 Aug 2023 16:47:56 +0300 [thread overview]
Message-ID: <aa2a2ab1-1058-df2a-9fbb-19dd4f5edcd4@nvidia.com> (raw)
In-Reply-To: <5247bfae-c0fc-99e0-04a4-55e2019bfdc7@linux.dev>
On 04/08/2023 2:48, Martin KaFai Lau wrote:
> On 8/3/23 4:10 AM, Gal Pressman wrote:
>> On 22/07/2023 2:33, Daniel Borkmann wrote:
>>> On qdisc destruction, the ingress_destroy() needs to update the correct
>>> entry, that is, tcx_entry_update must NULL the dev->tcx_ingress pointer.
>>> Therefore, fix the typo.
>>>
>>> Fixes: e420bed02507 ("bpf: Add fd-based tcx multi-prog infra with
>>> link support")
>>> Reported-by: syzbot+bdcf141f362ef83335cf@syzkaller.appspotmail.com
>>> Reported-by: syzbot+b202b7208664142954fa@syzkaller.appspotmail.com
>>> Reported-by: syzbot+14736e249bce46091c18@syzkaller.appspotmail.com
>>> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
>>
>> Hi Daniel,
>>
>> Our nightly regression testing picked up new memory leaks which were
>> bisected to this commit.
>
> Thanks for the report. Can you help to check if it can be reproduced
> with the latest net-next which has a tcx fix in commit 079082c60aff
> ("tcx: Fix splat during dev unregister")?
>
I think the issue is resolved after this patch, but we're still verifying.
Thanks!
next prev parent reply other threads:[~2023-08-06 13:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-21 23:33 [PATCH net-next] tcx: Fix splat in ingress_destroy upon tcx_entry_free Daniel Borkmann
2023-07-22 1:40 ` Daniel Borkmann
2023-07-24 10:55 ` Petr Machata
2023-07-24 19:10 ` patchwork-bot+netdevbpf
2023-08-03 11:10 ` Gal Pressman
2023-08-03 23:48 ` Martin KaFai Lau
2023-08-06 13:47 ` Gal Pressman [this message]
2023-08-03 23:54 ` Daniel Borkmann
2023-08-06 13:50 ` Gal Pressman
2023-08-04 13:31 ` Ido Schimmel
2023-08-06 13:47 ` Gal Pressman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa2a2ab1-1058-df2a-9fbb-19dd4f5edcd4@nvidia.com \
--to=gal@nvidia.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kuba@kernel.org \
--cc=martin.lau@linux.dev \
--cc=netdev@vger.kernel.org \
--cc=syzbot+14736e249bce46091c18@syzkaller.appspotmail.com \
--cc=syzbot+b202b7208664142954fa@syzkaller.appspotmail.com \
--cc=syzbot+bdcf141f362ef83335cf@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).