From: Ferenc Fejes <fejes@inf.elte.hu>
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: peti.antal99@gmail.com, netdev@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Claudiu Manoil <claudiu.manoil@nxp.com>,
Vinicius Costa Gomes <vinicius.gomes@intel.com>,
Kurt Kanzenbach <kurt@linutronix.de>,
Jacob Keller <jacob.e.keller@intel.com>,
Jamal Hadi Salim <jhs@mojatatu.com>,
Cong Wang <xiyou.wangcong@gmail.com>,
Jiri Pirko <jiri@resnulli.us>,
Simon Horman <simon.horman@corigine.com>
Subject: Re: [PATCH v6 net-next 02/13] net/sched: mqprio: refactor offloading and unoffloading to dedicated functions
Date: Thu, 16 Feb 2023 15:41:23 +0100 [thread overview]
Message-ID: <aa6e590e59fb3e360676a5ada5f80d01e0011d14.camel@inf.elte.hu> (raw)
In-Reply-To: <20230216142846.bjura4mf2f64tmcr@skbuf>
Hi Vladimir!
On Thu, 2023-02-16 at 16:28 +0200, Vladimir Oltean wrote:
> Hi Ferenc,
>
> On Thu, Feb 16, 2023 at 02:05:22PM +0100, Ferenc Fejes wrote:
> > This patch just code refactoring or it modifies the default
> > behavior of
> > the offloading too? I'm asking it in regards of the veth interface.
> > When you configure mqprio, the "hw" parameter is mandatory. By
> > default,
> > it tries to configure it with "hw 1". However as a result, veth
> > spit
> > back "Invalid argument" error (before your patches). Same happens
> > after
> > this patch too, right?
>
> Yup. iproute2 has a default queue configuration built in, if nothing
> else is specified, and this has "hw 1":
> https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/tree/tc/q_mqprio.c#n36
>
> > For veth hardware offloading makes no sense, but giving the "hw 0"
> > argument explicitly as mqprio parameter might counterintuitive.
>
> Agree that giving the right nlattrs to mqprio and trying to slalom
> through their validation is a frustrating minesweeper game. I have
> some
> patches which add some netlink EXT_ACK messages to make this a bit
> less
> sour. I'm regression-testing those, together with some other mqprio
> changes and I hope to send them soon.
Nice, good to hear!
>
> OTOH, "hw 1" is mandatory with the "mode", "shaper", "min_rate" and
> "max_rate" options. This is logical when you think about it (driver
> has
> to act upon them), but indeed it makes mqprio difficult to configure.
>
> With veth, you need to use multi-queue to make use of mqprio/taprio,
> have you done that?
>
> ip link add veth0 numtxqueues 8 numrxqueues 8 type veth peer name
> veth1
Yes, usually I done it with ethtool --set-channels veth0 tx 8 but I
guess that both resulting the same.
Best,
Ferenc
next prev parent reply other threads:[~2023-02-16 14:41 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-04 13:52 [PATCH v6 net-next 00/13] ENETC mqprio/taprio cleanup Vladimir Oltean
2023-02-04 13:52 ` [PATCH v6 net-next 01/13] net/sched: mqprio: refactor nlattr parsing to a separate function Vladimir Oltean
2023-02-04 13:52 ` [PATCH v6 net-next 02/13] net/sched: mqprio: refactor offloading and unoffloading to dedicated functions Vladimir Oltean
2023-02-16 13:05 ` Ferenc Fejes
2023-02-16 14:28 ` Vladimir Oltean
2023-02-16 14:41 ` Ferenc Fejes [this message]
2023-02-04 13:52 ` [PATCH v6 net-next 03/13] net/sched: move struct tc_mqprio_qopt_offload from pkt_cls.h to pkt_sched.h Vladimir Oltean
2023-02-04 13:52 ` [PATCH v6 net-next 04/13] net/sched: mqprio: allow reverse TC:TXQ mappings Vladimir Oltean
2023-02-05 12:42 ` Gerhard Engleder
2023-02-04 13:52 ` [PATCH v6 net-next 05/13] net/sched: mqprio: allow offloading drivers to request queue count validation Vladimir Oltean
2023-02-04 13:53 ` [PATCH v6 net-next 06/13] net/sched: mqprio: add extack messages for " Vladimir Oltean
2023-02-04 13:53 ` [PATCH v6 net-next 07/13] net/sched: taprio: centralize mqprio qopt validation Vladimir Oltean
2023-02-05 12:44 ` Gerhard Engleder
2023-02-04 13:53 ` [PATCH v6 net-next 08/13] net/sched: refactor mqprio qopt reconstruction to a library function Vladimir Oltean
2023-02-04 13:53 ` [PATCH v6 net-next 09/13] net/sched: taprio: pass mqprio queue configuration to ndo_setup_tc() Vladimir Oltean
2023-02-04 13:53 ` [PATCH v6 net-next 10/13] net/sched: taprio: only pass gate mask per TXQ for igc, stmmac, tsnep, am65_cpsw Vladimir Oltean
2023-02-04 13:53 ` [PATCH v6 net-next 11/13] net: enetc: request mqprio to validate the queue counts Vladimir Oltean
2023-02-04 13:53 ` [PATCH v6 net-next 12/13] net: enetc: act upon the requested mqprio queue configuration Vladimir Oltean
2023-02-04 13:53 ` [PATCH v6 net-next 13/13] net: enetc: act upon mqprio queue config in taprio offload Vladimir Oltean
2023-02-06 10:10 ` [PATCH v6 net-next 00/13] ENETC mqprio/taprio cleanup patchwork-bot+netdevbpf
2023-02-06 17:51 ` Jacob Keller
2023-02-07 12:48 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa6e590e59fb3e360676a5ada5f80d01e0011d14.camel@inf.elte.hu \
--to=fejes@inf.elte.hu \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jacob.e.keller@intel.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=kurt@linutronix.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peti.antal99@gmail.com \
--cc=simon.horman@corigine.com \
--cc=vinicius.gomes@intel.com \
--cc=vladimir.oltean@nxp.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox