From: Patrick McHardy <kaber@trash.net>
To: Florian Westphal <fw@strlen.de>, netdev@vger.kernel.org
Subject: Re: [PATCH 1/1] net_sched: drr: warn when qdisc is not work conserving
Date: Thu, 12 Jun 2014 18:03:08 +0200 [thread overview]
Message-ID: <aa75d9b0-e643-4fbe-b2bd-1c85982752e0@email.android.com> (raw)
In-Reply-To: <1402511718-24203-1-git-send-email-fw@strlen.de>
On 11. Juni 2014 20:35:18 MESZ, Florian Westphal <fw@strlen.de> wrote:
>The DRR scheduler requires that items on the active list are work
>conserving, i.e. do not hold on to skbs for throttling purposes, etc.
>Attaching e.g. tbf renders DRR useless because all other classes on the
>active list are delayed as well.
>
>So, warn users that this configuration won't work as expected; we
>already do this in couple of other qdiscs, see e.g.
Why don't prevent this during configuration time in the first place? It doesn't work, a warning might trigger long after creating the broken configuration and will more likely go unnoticed.
next prev parent reply other threads:[~2014-06-12 16:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-11 18:35 [PATCH 1/1] net_sched: drr: warn when qdisc is not work conserving Florian Westphal
2014-06-11 22:59 ` David Miller
2014-06-12 16:03 ` Patrick McHardy [this message]
2014-06-12 16:38 ` Florian Westphal
2014-06-12 17:09 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa75d9b0-e643-4fbe-b2bd-1c85982752e0@email.android.com \
--to=kaber@trash.net \
--cc=fw@strlen.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).