From: <Nicolas.Ferre@microchip.com>
To: <antoine.tenart@bootlin.com>, <davem@davemloft.net>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<Ludovic.Desroches@microchip.com>,
<alexandre.belloni@bootlin.com>
Subject: Re: [PATCH net-next] net: macb: use NAPI_POLL_WEIGHT
Date: Mon, 24 Jun 2019 15:58:02 +0000 [thread overview]
Message-ID: <aa8dbdde-7fd2-24f4-b9db-6112152b25c4@microchip.com> (raw)
In-Reply-To: <20190621152855.30330-1-antoine.tenart@bootlin.com>
On 21/06/2019 at 17:28, Antoine Tenart wrote:
> Use NAPI_POLL_WEIGHT, the default NAPI poll() weight instead of
> redefining our own value (which turns out to be 64 as well).
>
> Signed-off-by: Antoine Tenart <antoine.tenart@bootlin.com>
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
> ---
> drivers/net/ethernet/cadence/macb_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
> index 163deba244ab..1cd1f2c36d6f 100644
> --- a/drivers/net/ethernet/cadence/macb_main.c
> +++ b/drivers/net/ethernet/cadence/macb_main.c
> @@ -3490,7 +3490,7 @@ static int macb_init(struct platform_device *pdev)
>
> queue = &bp->queues[q];
> queue->bp = bp;
> - netif_napi_add(dev, &queue->napi, macb_poll, 64);
> + netif_napi_add(dev, &queue->napi, macb_poll, NAPI_POLL_WEIGHT);
> if (hw_q) {
> queue->ISR = GEM_ISR(hw_q - 1);
> queue->IER = GEM_IER(hw_q - 1);
>
--
Nicolas Ferre
next prev parent reply other threads:[~2019-06-24 15:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-21 15:28 [PATCH net-next] net: macb: use NAPI_POLL_WEIGHT Antoine Tenart
2019-06-24 15:58 ` Nicolas.Ferre [this message]
2019-06-24 16:20 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa8dbdde-7fd2-24f4-b9db-6112152b25c4@microchip.com \
--to=nicolas.ferre@microchip.com \
--cc=Ludovic.Desroches@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=antoine.tenart@bootlin.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).