* [PATCH net-next] net: macb: use NAPI_POLL_WEIGHT
@ 2019-06-21 15:28 Antoine Tenart
2019-06-24 15:58 ` Nicolas.Ferre
2019-06-24 16:20 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Antoine Tenart @ 2019-06-21 15:28 UTC (permalink / raw)
To: davem, nicolas.ferre
Cc: Antoine Tenart, netdev, linux-kernel, ludovic.desroches,
alexandre.belloni
Use NAPI_POLL_WEIGHT, the default NAPI poll() weight instead of
redefining our own value (which turns out to be 64 as well).
Signed-off-by: Antoine Tenart <antoine.tenart@bootlin.com>
---
drivers/net/ethernet/cadence/macb_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
index 163deba244ab..1cd1f2c36d6f 100644
--- a/drivers/net/ethernet/cadence/macb_main.c
+++ b/drivers/net/ethernet/cadence/macb_main.c
@@ -3490,7 +3490,7 @@ static int macb_init(struct platform_device *pdev)
queue = &bp->queues[q];
queue->bp = bp;
- netif_napi_add(dev, &queue->napi, macb_poll, 64);
+ netif_napi_add(dev, &queue->napi, macb_poll, NAPI_POLL_WEIGHT);
if (hw_q) {
queue->ISR = GEM_ISR(hw_q - 1);
queue->IER = GEM_IER(hw_q - 1);
--
2.21.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net-next] net: macb: use NAPI_POLL_WEIGHT
2019-06-21 15:28 [PATCH net-next] net: macb: use NAPI_POLL_WEIGHT Antoine Tenart
@ 2019-06-24 15:58 ` Nicolas.Ferre
2019-06-24 16:20 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Nicolas.Ferre @ 2019-06-24 15:58 UTC (permalink / raw)
To: antoine.tenart, davem
Cc: netdev, linux-kernel, Ludovic.Desroches, alexandre.belloni
On 21/06/2019 at 17:28, Antoine Tenart wrote:
> Use NAPI_POLL_WEIGHT, the default NAPI poll() weight instead of
> redefining our own value (which turns out to be 64 as well).
>
> Signed-off-by: Antoine Tenart <antoine.tenart@bootlin.com>
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
> ---
> drivers/net/ethernet/cadence/macb_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
> index 163deba244ab..1cd1f2c36d6f 100644
> --- a/drivers/net/ethernet/cadence/macb_main.c
> +++ b/drivers/net/ethernet/cadence/macb_main.c
> @@ -3490,7 +3490,7 @@ static int macb_init(struct platform_device *pdev)
>
> queue = &bp->queues[q];
> queue->bp = bp;
> - netif_napi_add(dev, &queue->napi, macb_poll, 64);
> + netif_napi_add(dev, &queue->napi, macb_poll, NAPI_POLL_WEIGHT);
> if (hw_q) {
> queue->ISR = GEM_ISR(hw_q - 1);
> queue->IER = GEM_IER(hw_q - 1);
>
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net-next] net: macb: use NAPI_POLL_WEIGHT
2019-06-21 15:28 [PATCH net-next] net: macb: use NAPI_POLL_WEIGHT Antoine Tenart
2019-06-24 15:58 ` Nicolas.Ferre
@ 2019-06-24 16:20 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2019-06-24 16:20 UTC (permalink / raw)
To: antoine.tenart
Cc: nicolas.ferre, netdev, linux-kernel, ludovic.desroches,
alexandre.belloni
From: Antoine Tenart <antoine.tenart@bootlin.com>
Date: Fri, 21 Jun 2019 17:28:55 +0200
> Use NAPI_POLL_WEIGHT, the default NAPI poll() weight instead of
> redefining our own value (which turns out to be 64 as well).
>
> Signed-off-by: Antoine Tenart <antoine.tenart@bootlin.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-06-24 16:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-21 15:28 [PATCH net-next] net: macb: use NAPI_POLL_WEIGHT Antoine Tenart
2019-06-24 15:58 ` Nicolas.Ferre
2019-06-24 16:20 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).