From: Inochi Amaoto <inochiama@gmail.com>
To: "Russell King (Oracle)" <linux@armlinux.org.uk>,
Inochi Amaoto <inochiama@gmail.com>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Yixun Lan <dlan@kernel.org>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Richard Cochran <richardcochran@gmail.com>,
Paul Walmsley <pjw@kernel.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Alexandre Ghiti <alex@ghiti.fr>, Yao Zi <me@ziyao.cc>,
Yanteng Si <siyanteng@cqsoftware.com.cn>,
Vladimir Oltean <vladimir.oltean@nxp.com>,
Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
Shangjuan Wei <weishangjuan@eswincomputing.com>,
Maxime Chevallier <maxime.chevallier@bootlin.com>,
Chen-Yu Tsai <wens@kernel.org>,
Boon Khai Ng <boon.khai.ng@altera.com>,
Quentin Schulz <quentin.schulz@cherry.de>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Jose Abreu <joabreu@synopsys.com>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
spacemit@lists.linux.dev,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
Yixun Lan <dlan@gentoo.org>, Longbin Li <looong.bin@gmail.com>
Subject: Re: [PATCH net-next v8 3/3] net: stmmac: Add glue layer for Spacemit K3 SoC
Date: Tue, 10 Mar 2026 06:28:08 +0800 [thread overview]
Message-ID: <aa9JCWpJ_EJbUzXV@inochi.infowork> (raw)
In-Reply-To: <aa61v7MQoYq10Jes@shell.armlinux.org.uk>
On Mon, Mar 09, 2026 at 11:57:51AM +0000, Russell King (Oracle) wrote:
> On Mon, Mar 09, 2026 at 08:42:44AM +0800, Inochi Amaoto wrote:
> > +static int spacemit_dwmac_update_irq_config(struct spacmit_dwmac *dwmac,
> > + struct stmmac_resources *stmmac_res)
> > +{
> > + unsigned int mask = CTRL_WAKE_IRQ_EN;
> > + unsigned int val = stmmac_res->wol_irq >= 0 ? CTRL_WAKE_IRQ_EN : 0;
>
> This looks like the last thing I can spot that needs to be addressed.
> netdev wants to see "reverse christmas tree" local variable
> declarations.
>
> Please reverse the order of these two declarations to achieve that.
>
> With that fixed:
>
> Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
>
> Thanks!
>
Great, after some lookup, I find the variables in function
spacemit_set_phy_intf_sel() are also needed to reversed.
I will also fix this in the next version.
Regards,
Inochi
next prev parent reply other threads:[~2026-03-09 22:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-09 0:42 [PATCH net-next v8 0/3] riscv: spacemit: Add ethernet support for K3 Inochi Amaoto
2026-03-09 0:42 ` [PATCH net-next v8 1/3] dt-bindings: net: Add support for Spacemit K3 dwmac Inochi Amaoto
2026-03-09 0:42 ` [PATCH net-next v8 2/3] net: stmmac: platform: Add snps,dwmac-5.40a IP compatible string Inochi Amaoto
2026-03-09 11:54 ` Russell King (Oracle)
2026-03-09 0:42 ` [PATCH net-next v8 3/3] net: stmmac: Add glue layer for Spacemit K3 SoC Inochi Amaoto
2026-03-09 11:57 ` Russell King (Oracle)
2026-03-09 22:28 ` Inochi Amaoto [this message]
2026-03-09 11:59 ` Russell King (Oracle)
2026-03-09 22:26 ` Inochi Amaoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa9JCWpJ_EJbUzXV@inochi.infowork \
--to=inochiama@gmail.com \
--cc=alex@ghiti.fr \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew+netdev@lunn.ch \
--cc=aou@eecs.berkeley.edu \
--cc=boon.khai.ng@altera.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dlan@gentoo.org \
--cc=dlan@kernel.org \
--cc=edumazet@google.com \
--cc=joabreu@synopsys.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux@armlinux.org.uk \
--cc=looong.bin@gmail.com \
--cc=maxime.chevallier@bootlin.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=me@ziyao.cc \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=palmer@dabbelt.com \
--cc=peppe.cavallaro@st.com \
--cc=pjw@kernel.org \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=quentin.schulz@cherry.de \
--cc=richardcochran@gmail.com \
--cc=robh@kernel.org \
--cc=siyanteng@cqsoftware.com.cn \
--cc=spacemit@lists.linux.dev \
--cc=vladimir.oltean@nxp.com \
--cc=weishangjuan@eswincomputing.com \
--cc=wens@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox