Netdev List
 help / color / mirror / Atom feed
From: Matthieu Baerts <matttbe@kernel.org>
To: Hang Nan <2122295973@qq.com>
Cc: netdev@vger.kernel.org, mptcp@lists.linux.dev,
	martineau@kernel.org, geliang@kernel.org, davem@davemloft.net,
	edumazet@kernel.org, kuba@kernel.org, pabeni@redhat.com,
	horms@kernel.org, kuniyu@google.com, willemb@google.com,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH net v5 0/3] mptcp token hash ordering and token 0 lookups
Date: Wed, 18 Nov 2026 11:50:20 +0100	[thread overview]
Message-ID: <aa9a2189-71e5-409e-b89d-c14441bccb72@kernel.org> (raw)
In-Reply-To: <tencent_50E9A78F95855D54DA67136F3D8520017F0A@qq.com>

Hi Hang Nan,

On 16/11/2026 15:58, Hang Nan wrote:
> This series restores acquire ordering for the mptcp token lookup and fixes
> two pre-existing defects in that hash table which ordering alone cannot
> cover.

I didn't do a full review of this series because of the build failures,
but here are just a couple of quick notes:

- The patches you send are not linked to the cover-letter, see the
  In-Reply-To [1] pointing to a different Message-ID than the
  cover-letter [2]. Your messages ID are probably modified when sent.

- Please wait for Netdev Sashiko [3] before sending new versions.

- Use 'mptcp:' prefix instead of 'net: mptcp:'

- Split the new kunit tests from the modification in the code to ease
  backports.

- (Honestly, a test for a !token guard is probably not worth 50 lines.
   The first KUNIT_EXPECT_PTR_EQ on the empty table, or no new test at
   all seems more reasonable.)

- (I agree that the Token 0 is never assigned... in Linux: the RFC8684
   accepts it, but the Linux implementation don't. Maybe mention that in
   the commit message to avoid confusions.)

[1] https://lore.kernel.org/tencent_BB8DA72524E32FD374B8B2950B247B62E207@qq.com
[2] https://lore.kernel.org/tencent_50E9A78F95855D54DA67136F3D8520017F0A@qq.com
[3] https://netdev-ai.bots.linux.dev/sashiko/

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.


      reply	other threads:[~2026-11-18 10:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 14:58 [PATCH net v5 0/3] mptcp token hash ordering and token 0 lookups Hang Nan
2026-11-18 10:50 ` Matthieu Baerts [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aa9a2189-71e5-409e-b89d-c14441bccb72@kernel.org \
    --to=matttbe@kernel.org \
    --cc=2122295973@qq.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=geliang@kernel.org \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=kuniyu@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martineau@kernel.org \
    --cc=mptcp@lists.linux.dev \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=stable@vger.kernel.org \
    --cc=willemb@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox