* [PATCH -next] Bluetooth: Fix Kconfig warning for BT_HIDP
@ 2022-11-22 3:42 YueHaibing
2022-11-22 8:31 ` Paul Menzel
0 siblings, 1 reply; 5+ messages in thread
From: YueHaibing @ 2022-11-22 3:42 UTC (permalink / raw)
To: marcel, johan.hedberg, luiz.dentz, davem, edumazet, kuba, pabeni,
yuehaibing, jkosina, gregkh, benjamin.tissoires
Cc: linux-bluetooth, netdev, linux-kernel
commit 25621bcc8976 add HID_SUPPORT, and HID depends on it now.
Add HID_SUPPORT dependency for BT_HIDP to fix the warning:
WARNING: unmet direct dependencies detected for HID
Depends on [n]: HID_SUPPORT [=n]
Selected by [m]:
- BT_HIDP [=m] && NET [=y] && BT_BREDR [=y] && INPUT [=m]
Fixes: 25621bcc8976 ("HID: Kconfig: split HID support and hid-core compilation")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
net/bluetooth/hidp/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/bluetooth/hidp/Kconfig b/net/bluetooth/hidp/Kconfig
index 14100f341f33..6746be07e222 100644
--- a/net/bluetooth/hidp/Kconfig
+++ b/net/bluetooth/hidp/Kconfig
@@ -1,7 +1,7 @@
# SPDX-License-Identifier: GPL-2.0-only
config BT_HIDP
tristate "HIDP protocol support"
- depends on BT_BREDR && INPUT
+ depends on BT_BREDR && INPUT && HID_SUPPORT
select HID
help
HIDP (Human Interface Device Protocol) is a transport layer
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH -next] Bluetooth: Fix Kconfig warning for BT_HIDP
2022-11-22 3:42 [PATCH -next] Bluetooth: Fix Kconfig warning for BT_HIDP YueHaibing
@ 2022-11-22 8:31 ` Paul Menzel
2022-11-22 9:06 ` Benjamin Tissoires
2022-11-22 9:06 ` YueHaibing
0 siblings, 2 replies; 5+ messages in thread
From: Paul Menzel @ 2022-11-22 8:31 UTC (permalink / raw)
To: YueHaibing
Cc: marcel, johan.hedberg, luiz.dentz, davem, edumazet, kuba, pabeni,
jkosina, gregkh, benjamin.tissoires, linux-bluetooth, netdev,
linux-kernel
Dear YueHaibing,
Thank you for your patch.
Am 22.11.22 um 04:42 schrieb YueHaibing:
Maybe use the more specific summary below:
Bluetooth: Add HID_SUPPORT dependency for BT_HIDP
> commit 25621bcc8976 add HID_SUPPORT, and HID depends on it now.
add*s*
or
Commit 25621bcc8976 ("HID: Kconfig: split HID support and hid-core
compilation") introduces the new Kconfig symbol HID_SUPPORT …
Kind regards,
Paul
> Add HID_SUPPORT dependency for BT_HIDP to fix the warning:
>
> WARNING: unmet direct dependencies detected for HID
> Depends on [n]: HID_SUPPORT [=n]
> Selected by [m]:
> - BT_HIDP [=m] && NET [=y] && BT_BREDR [=y] && INPUT [=m]
>
> Fixes: 25621bcc8976 ("HID: Kconfig: split HID support and hid-core compilation")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> net/bluetooth/hidp/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/bluetooth/hidp/Kconfig b/net/bluetooth/hidp/Kconfig
> index 14100f341f33..6746be07e222 100644
> --- a/net/bluetooth/hidp/Kconfig
> +++ b/net/bluetooth/hidp/Kconfig
> @@ -1,7 +1,7 @@
> # SPDX-License-Identifier: GPL-2.0-only
> config BT_HIDP
> tristate "HIDP protocol support"
> - depends on BT_BREDR && INPUT
> + depends on BT_BREDR && INPUT && HID_SUPPORT
> select HID
> help
> HIDP (Human Interface Device Protocol) is a transport layer
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH -next] Bluetooth: Fix Kconfig warning for BT_HIDP
2022-11-22 8:31 ` Paul Menzel
@ 2022-11-22 9:06 ` Benjamin Tissoires
2022-11-22 9:18 ` YueHaibing
2022-11-22 9:06 ` YueHaibing
1 sibling, 1 reply; 5+ messages in thread
From: Benjamin Tissoires @ 2022-11-22 9:06 UTC (permalink / raw)
To: Paul Menzel
Cc: YueHaibing, marcel, johan.hedberg, luiz.dentz, davem, edumazet,
kuba, pabeni, jkosina, gregkh, linux-bluetooth, netdev,
linux-kernel
Hi,
On Tue, Nov 22, 2022 at 9:37 AM Paul Menzel <pmenzel@molgen.mpg.de> wrote:
>
> Dear YueHaibing,
>
>
> Thank you for your patch.
>
>
> Am 22.11.22 um 04:42 schrieb YueHaibing:
>
> Maybe use the more specific summary below:
>
> Bluetooth: Add HID_SUPPORT dependency for BT_HIDP
>
> > commit 25621bcc8976 add HID_SUPPORT, and HID depends on it now.
>
> add*s*
>
> or
>
> Commit 25621bcc8976 ("HID: Kconfig: split HID support and hid-core
> compilation") introduces the new Kconfig symbol HID_SUPPORT …
>
>
> Kind regards,
>
> Paul
>
>
> > Add HID_SUPPORT dependency for BT_HIDP to fix the warning:
> >
> > WARNING: unmet direct dependencies detected for HID
> > Depends on [n]: HID_SUPPORT [=n]
> > Selected by [m]:
> > - BT_HIDP [=m] && NET [=y] && BT_BREDR [=y] && INPUT [=m]
> >
> > Fixes: 25621bcc8976 ("HID: Kconfig: split HID support and hid-core compilation")
> > Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> > ---
FWIW, a fix is already in -next:
https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git/commit/?h=for-6.2/hid-bpf&id=6cc90ccd4f6cfed98e2a3a378debc69f28d57473
But thanks for the patch nonetheless!
Cheers,
Benjamin
>
> > net/bluetooth/hidp/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/net/bluetooth/hidp/Kconfig b/net/bluetooth/hidp/Kconfig
> > index 14100f341f33..6746be07e222 100644
> > --- a/net/bluetooth/hidp/Kconfig
> > +++ b/net/bluetooth/hidp/Kconfig
> > @@ -1,7 +1,7 @@
> > # SPDX-License-Identifier: GPL-2.0-only
> > config BT_HIDP
> > tristate "HIDP protocol support"
> > - depends on BT_BREDR && INPUT
> > + depends on BT_BREDR && INPUT && HID_SUPPORT
> > select HID
> > help
> > HIDP (Human Interface Device Protocol) is a transport layer
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH -next] Bluetooth: Fix Kconfig warning for BT_HIDP
2022-11-22 9:06 ` Benjamin Tissoires
@ 2022-11-22 9:18 ` YueHaibing
0 siblings, 0 replies; 5+ messages in thread
From: YueHaibing @ 2022-11-22 9:18 UTC (permalink / raw)
To: Benjamin Tissoires, Paul Menzel
Cc: marcel, johan.hedberg, luiz.dentz, davem, edumazet, kuba, pabeni,
jkosina, gregkh, linux-bluetooth, netdev, linux-kernel
On 2022/11/22 17:06, Benjamin Tissoires wrote:
> Hi,
>
> On Tue, Nov 22, 2022 at 9:37 AM Paul Menzel <pmenzel@molgen.mpg.de> wrote:
>>
>> Dear YueHaibing,
>>
>>
>> Thank you for your patch.
>>
>>
>> Am 22.11.22 um 04:42 schrieb YueHaibing:
>>
>> Maybe use the more specific summary below:
>>
>> Bluetooth: Add HID_SUPPORT dependency for BT_HIDP
>>
>>> commit 25621bcc8976 add HID_SUPPORT, and HID depends on it now.
>>
>> add*s*
>>
>> or
>>
>> Commit 25621bcc8976 ("HID: Kconfig: split HID support and hid-core
>> compilation") introduces the new Kconfig symbol HID_SUPPORT …
>>
>>
>> Kind regards,
>>
>> Paul
>>
>>
>>> Add HID_SUPPORT dependency for BT_HIDP to fix the warning:
>>>
>>> WARNING: unmet direct dependencies detected for HID
>>> Depends on [n]: HID_SUPPORT [=n]
>>> Selected by [m]:
>>> - BT_HIDP [=m] && NET [=y] && BT_BREDR [=y] && INPUT [=m]
>>>
>>> Fixes: 25621bcc8976 ("HID: Kconfig: split HID support and hid-core compilation")
>>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>>> ---
>
>
> FWIW, a fix is already in -next:
> https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git/commit/?h=for-6.2/hid-bpf&id=6cc90ccd4f6cfed98e2a3a378debc69f28d57473
OK, thanks for your info.
>
> But thanks for the patch nonetheless!
>
> Cheers,
> Benjamin
>
>>
>>> net/bluetooth/hidp/Kconfig | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/net/bluetooth/hidp/Kconfig b/net/bluetooth/hidp/Kconfig
>>> index 14100f341f33..6746be07e222 100644
>>> --- a/net/bluetooth/hidp/Kconfig
>>> +++ b/net/bluetooth/hidp/Kconfig
>>> @@ -1,7 +1,7 @@
>>> # SPDX-License-Identifier: GPL-2.0-only
>>> config BT_HIDP
>>> tristate "HIDP protocol support"
>>> - depends on BT_BREDR && INPUT
>>> + depends on BT_BREDR && INPUT && HID_SUPPORT
>>> select HID
>>> help
>>> HIDP (Human Interface Device Protocol) is a transport layer
>>
>
> .
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH -next] Bluetooth: Fix Kconfig warning for BT_HIDP
2022-11-22 8:31 ` Paul Menzel
2022-11-22 9:06 ` Benjamin Tissoires
@ 2022-11-22 9:06 ` YueHaibing
1 sibling, 0 replies; 5+ messages in thread
From: YueHaibing @ 2022-11-22 9:06 UTC (permalink / raw)
To: Paul Menzel
Cc: marcel, johan.hedberg, luiz.dentz, davem, edumazet, kuba, pabeni,
jkosina, gregkh, benjamin.tissoires, linux-bluetooth, netdev,
linux-kernel
On 2022/11/22 16:31, Paul Menzel wrote:
> Dear YueHaibing,
>
>
> Thank you for your patch.
>
>
> Am 22.11.22 um 04:42 schrieb YueHaibing:
>
> Maybe use the more specific summary below:
>
> Bluetooth: Add HID_SUPPORT dependency for BT_HIDP
>
>> commit 25621bcc8976 add HID_SUPPORT, and HID depends on it now.
>
> add*s*
>
> or
>
> Commit 25621bcc8976 ("HID: Kconfig: split HID support and hid-core compilation") introduces the new Kconfig symbol HID_SUPPORT …
>
>
Thanks for your review, v2 is on the way.
> Kind regards,
>
> Paul
>
>
>> Add HID_SUPPORT dependency for BT_HIDP to fix the warning:
>>
>> WARNING: unmet direct dependencies detected for HID
>> Depends on [n]: HID_SUPPORT [=n]
>> Selected by [m]:
>> - BT_HIDP [=m] && NET [=y] && BT_BREDR [=y] && INPUT [=m]
>>
>> Fixes: 25621bcc8976 ("HID: Kconfig: split HID support and hid-core compilation")
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>> ---
>> net/bluetooth/hidp/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/net/bluetooth/hidp/Kconfig b/net/bluetooth/hidp/Kconfig
>> index 14100f341f33..6746be07e222 100644
>> --- a/net/bluetooth/hidp/Kconfig
>> +++ b/net/bluetooth/hidp/Kconfig
>> @@ -1,7 +1,7 @@
>> # SPDX-License-Identifier: GPL-2.0-only
>> config BT_HIDP
>> tristate "HIDP protocol support"
>> - depends on BT_BREDR && INPUT
>> + depends on BT_BREDR && INPUT && HID_SUPPORT
>> select HID
>> help
>> HIDP (Human Interface Device Protocol) is a transport layer
>
> .
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-11-22 9:18 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-22 3:42 [PATCH -next] Bluetooth: Fix Kconfig warning for BT_HIDP YueHaibing
2022-11-22 8:31 ` Paul Menzel
2022-11-22 9:06 ` Benjamin Tissoires
2022-11-22 9:18 ` YueHaibing
2022-11-22 9:06 ` YueHaibing
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).