From: Joe Damato <joe@dama.to>
To: Chris J Arges <carges@cloudflare.com>
Cc: michael.chan@broadcom.com, pavan.chebbi@broadcom.com,
kuba@kernel.org, Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
"David S. Miller" <davem@davemloft.net>,
Jesper Dangaard Brouer <hawk@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
Stanislav Fomichev <sdf@fomichev.me>,
kernel-team@cloudflare.com, netdev@vger.kernel.org,
bpf@vger.kernel.org
Subject: Re: [PATCH net-next v3 0/5] bnxt_en: Add XDP RSS hash metadata support
Date: Mon, 9 Mar 2026 17:51:38 -0700 [thread overview]
Message-ID: <aa9rGglS62WGgSMk@devvm20253.cco0.facebook.com> (raw)
In-Reply-To: <20260306230600.1628196-1-carges@cloudflare.com>
On Fri, Mar 06, 2026 at 05:00:15PM -0600, Chris J Arges wrote:
> This series adds XDP RSS hash metadata extraction support for the bnxt_en
> driver and includes selftests to validate the functionality. I was able
> to test this on a BCM57414 NIC.
>
> Note: I don't have hardware to test v3 completions at the moment.
>
> Patches 1-3 implement the driver support:
> - Patch 1 adds bnxt_xdp_buff to wrap xdp_buff with
> pointers to the hardware RX completion descriptors and the
> completion type. This is similar to other driver implementations.
> - Patch 2 adds the xmo_rx_hash callback for CMP_TYPE_RX_L2_CMP completions.
> - Patch 3 adds handling for CMP_TYPE_RX_L2_V3_CMP completions
>
> Patches 4-5 add selftest coverage:
> - Patch 4 refactors common BPF map helper functions out of the
> existing xdp.py selftest into a shared net/lib/py/bpf.py module.
> - Patch 5 adds an XDP metadata selftest that loads an XDP program
> calling bpf_xdp_metadata_rx_hash. The test skips on devices without
> xdp-rx-metadata-features.
>
> v2: https://lore.kernel.org/netdev/20260303024510.644962-1-carges@cloudflare.com/
> - bnxt xdp: actually fixed RCT issues
> - bnxt xdp: Added patch 3 to handle CMP_TYPE_RX_L2_V3_CMP completions.
>
> v1: https://lore.kernel.org/netdev/cover.1772211065.git.carges@cloudflare.com/
> - selftests: moved tests into net/hw
> - selftests: fix pylinter errors
> - selftests: add check for no error count
> - bnxt_xdp: followed RCT for variable declaration
> - rebased on net-next
I think I commented this on the v2 [1], but it would be super helpful to put
the summary of changes in each patch itself to make it easier for reviewers.
I think you dropped my Reviewed-by's, so I'm not sure which patches changed
and which didn't :(
[1]: https://lore.kernel.org/netdev/aacsQvvOoL29Rvyw@devvm20253.cco0.facebook.com/
next prev parent reply other threads:[~2026-03-10 0:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-06 23:00 [PATCH net-next v3 0/5] bnxt_en: Add XDP RSS hash metadata support Chris J Arges
2026-03-06 23:00 ` [PATCH net-next v3 1/5] bnxt_en: use bnxt_xdp_buff for xdp context Chris J Arges
2026-03-10 0:52 ` Joe Damato
2026-03-13 0:14 ` Andy Gospodarek
2026-03-06 23:00 ` [PATCH net-next v3 2/5] bnxt_en: Implement XDP RSS hash metadata extraction Chris J Arges
2026-03-10 0:56 ` Joe Damato
2026-03-13 0:15 ` Andy Gospodarek
2026-03-06 23:00 ` [PATCH net-next v3 3/5] bnxt_en: Implement XDP RSS hash metadata extraction for V3_CMP Chris J Arges
2026-03-10 1:02 ` Joe Damato
2026-03-13 0:15 ` Andy Gospodarek
2026-03-06 23:00 ` [PATCH net-next v3 4/5] selftests: net: move common xdp.py functions into lib Chris J Arges
2026-03-10 0:54 ` Joe Damato
2026-03-06 23:00 ` [PATCH net-next v3 5/5] selftests: drv-net: xdp: Add rss_hash metadata tests Chris J Arges
2026-03-10 0:51 ` Joe Damato [this message]
2026-03-10 2:06 ` [PATCH net-next v3 0/5] bnxt_en: Add XDP RSS hash metadata support Chris Arges
2026-03-10 2:37 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa9rGglS62WGgSMk@devvm20253.cco0.facebook.com \
--to=joe@dama.to \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=carges@cloudflare.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=hawk@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=kernel-team@cloudflare.com \
--cc=kuba@kernel.org \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pavan.chebbi@broadcom.com \
--cc=sdf@fomichev.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox