[PATCH V2] nfc: nxp-nci: allow GPIOs to sleep

[PATCH V2] nfc: nxp-nci: allow GPIOs to sleep

[Ian Ray]

Allow the firmware and enable GPIOs to sleep.

This fixes a `WARN_ON' and allows the driver to operate GPIOs which are
connected to I2C GPIO expanders.

-- >8 --
kernel: WARNING: CPU: 3 PID: 2636 at drivers/gpio/gpiolib.c:3880 gpiod_set_value+0x88/0x98
-- >8 --

Fixes: 6be88670fc59 ("NFC: nxp-nci_i2c: Add I2C support to NXP NCI driver")
Cc: stable@vger.kernel.org
Signed-off-by: Ian Ray <ian.ray@gehealthcare.com>
---
Changes since v1:
 - Add fixes tag (thanks to Charalampos Mitrodimas)
 - Cc stable since there are a few in-tree boards using compatible "nxp,nxp-nci-i2c".
---
 drivers/nfc/nxp-nci/i2c.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/nfc/nxp-nci/i2c.c b/drivers/nfc/nxp-nci/i2c.c
index 6a5ce8ff91f0..b3d34433bd14 100644
--- a/drivers/nfc/nxp-nci/i2c.c
+++ b/drivers/nfc/nxp-nci/i2c.c
@@ -47,8 +47,8 @@ static int nxp_nci_i2c_set_mode(void *phy_id,
 {
 	struct nxp_nci_i2c_phy *phy = (struct nxp_nci_i2c_phy *) phy_id;
 
-	gpiod_set_value(phy->gpiod_fw, (mode == NXP_NCI_MODE_FW) ? 1 : 0);
-	gpiod_set_value(phy->gpiod_en, (mode != NXP_NCI_MODE_COLD) ? 1 : 0);
+	gpiod_set_value_cansleep(phy->gpiod_fw, (mode == NXP_NCI_MODE_FW) ? 1 : 0);
+	gpiod_set_value_cansleep(phy->gpiod_en, (mode != NXP_NCI_MODE_COLD) ? 1 : 0);
 	usleep_range(10000, 15000);
 
 	if (mode == NXP_NCI_MODE_COLD)
-- 
2.49.0

Re: [PATCH V2] nfc: nxp-nci: allow GPIOs to sleep

[Paolo Abeni]

On 2/23/26 8:05 AM, Ian Ray wrote:
> Allow the firmware and enable GPIOs to sleep.
> 
> This fixes a `WARN_ON' and allows the driver to operate GPIOs which are
> connected to I2C GPIO expanders.
> 
> -- >8 --
> kernel: WARNING: CPU: 3 PID: 2636 at drivers/gpio/gpiolib.c:3880 gpiod_set_value+0x88/0x98
> -- >8 --
> 
> Fixes: 6be88670fc59 ("NFC: nxp-nci_i2c: Add I2C support to NXP NCI driver")
> Cc: stable@vger.kernel.org
> Signed-off-by: Ian Ray <ian.ray@gehealthcare.com>

When resubmitting with the correct fixes tag, please additionally
include the target tree in the subj prefix (in this case 'net').

Thanks,

Paolo

Re: [PATCH V2] nfc: nxp-nci: allow GPIOs to sleep

[Ian Ray]

On Tue, Feb 24, 2026 at 01:31:16PM +0100, Paolo Abeni wrote:
> On 2/23/26 8:05 AM, Ian Ray wrote:
> > Allow the firmware and enable GPIOs to sleep.
> >
> > This fixes a `WARN_ON' and allows the driver to operate GPIOs which are
> > connected to I2C GPIO expanders.
> >
> > -- >8 --
> > kernel: WARNING: CPU: 3 PID: 2636 at drivers/gpio/gpiolib.c:3880 gpiod_set_value+0x88/0x98
> > -- >8 --
> >
> > Fixes: 6be88670fc59 ("NFC: nxp-nci_i2c: Add I2C support to NXP NCI driver")
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Ian Ray <ian.ray@gehealthcare.com>
> 
> When resubmitting with the correct fixes tag, please additionally
> include the target tree in the subj prefix (in this case 'net').

Is that prefix correct?  At least recent changes use the "nfc" prefix
that I used in the subject.

$ git log --oneline drivers/nfc/ | head
57be33f85e36 nfc: nxp-nci: remove interrupt trigger type
f40ddcc0c0ca Revert "nfc/nci: Add the inconsistency check between the input data length and count"
885bebac9909 nfc: pn533: Fix error code in pn533_acr122_poweron_rdr()
7cf3ac8a9c0a NFC: mei_phy: fix kernel-doc warnings
661bfb4699f8 nfc: s3fwrn5: Use SHA-1 library instead of crypto_shash
c6f68f69416d nfc: pn533: Delete an unnecessary check
5d69351820ea NFC: trf7970a: Create device-tree parameter for RX gain reduction
41cb08555c41 treewide, timers: Rename from_timer() to timer_container_of()

> 
> Thanks,
> 
> Paolo
> 

Thanks,
Ian