From: Florian Westphal <fw@strlen.de>
To: Paolo Abeni <pabeni@redhat.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
netfilter-devel@vger.kernel.org, pablo@netfilter.org,
netdev@vger.kernel.org
Subject: Re: [PATCH net 1/2] netfilter: nf_conntrack_h323: fix OOB read in decode_choice()
Date: Thu, 26 Feb 2026 15:14:01 +0100 [thread overview]
Message-ID: <aaBVKVXk5T7j7jvU@strlen.de> (raw)
In-Reply-To: <61b18149-17e4-439a-97d3-74f0dc20a78f@redhat.com>
Paolo Abeni <pabeni@redhat.com> wrote:
> On 2/26/26 10:10 AM, Florian Westphal wrote:
> > Florian Westphal <fw@strlen.de> wrote:
> >> From: Vahagn Vardanian <vahagn@redrays.io>
> >>
> >> In decode_choice(), the boundary check before get_len() uses the
> >> variable `len`, which is still 0 from its initialization at the top of
> >> the function:
> >>
> >
> > @net maintainers: would you mind applying this patch directly?
> >
> > I don't know when Pablo can re-spin his fix, and I don't want
> > to hold up the H323 patch.
>
> Makes sense. Note that I'll apply the patch (as opposed to pull it),
> meaning it will get a new hash.
Yes, thats fine.
At the moment both nf and nf-next stictly follow net/net-next, i.e.
nf:main and nf-next:main might be behind the corresponding net
tree, but are never ahead.
Patches are queued up in :testing. This allows me to rebase and
if necessary drop patches again.
Then, for pull request, last "good" testing branch gets tagged,
then that tag is used in the pull request.
After you pull changes, I re-sync the nf tree the net one and
push to main.
next prev parent reply other threads:[~2026-02-26 14:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-25 13:06 [PATCH net 0/2] netfilter updates for net Florian Westphal
2026-02-25 13:06 ` [PATCH net 1/2] netfilter: nf_conntrack_h323: fix OOB read in decode_choice() Florian Westphal
2026-02-26 9:10 ` Florian Westphal
2026-02-26 11:47 ` Paolo Abeni
2026-02-26 14:14 ` Florian Westphal [this message]
2026-02-26 11:48 ` Paolo Abeni
2026-02-26 14:00 ` patchwork-bot+netdevbpf
2026-02-25 13:06 ` [PATCH net 2/2] netfilter: nf_tables: unconditionally bump set->nelems before insertion Florian Westphal
2026-02-26 3:56 ` [net,2/2] " Jakub Kicinski
2026-02-26 8:19 ` Florian Westphal
2026-02-26 16:28 ` Pablo Neira Ayuso
2026-02-26 17:19 ` Paolo Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aaBVKVXk5T7j7jvU@strlen.de \
--to=fw@strlen.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox