From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 90F45349AF5 for ; Fri, 27 Feb 2026 19:04:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772219091; cv=none; b=ZYoIVjsAotMF2c6+3pdlwhScGIel3kBSREX5TweMe8L4M5irTBdttFZsSswt9AfDTeVhWBnrIa54izniKf/3pb8y8hgvOVZlyhOHA8WrCco5M1tpTkYS8m9HP8F2pBL4HN0mo84fWgQmz5so4RNmvJVbC1IboctVeCsIXhUPGIg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772219091; c=relaxed/simple; bh=IMAyHPy/blEQ/2vnWAKKyy0ruHH1HS387rxT0IWZDHU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jwXqz0RLIBl19143AJGnG8S+Ra7ztaJec16xQ1JW9s9wdytYTwREyhJtKww2mcp3qA7FXdBzDWbJHzbk2umUOLWudKQyd/oWnptOIAEiBpEJWyYSEwX+2t8VxMAz+tz5Y3jkGTSUphgoMcD6DtFKQFRs50z2R33NK8jwZph/v+g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dama.to; spf=none smtp.mailfrom=dama.to; dkim=pass (2048-bit key) header.d=dama-to.20230601.gappssmtp.com header.i=@dama-to.20230601.gappssmtp.com header.b=o4uRYTK9; arc=none smtp.client-ip=209.85.210.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dama.to Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=dama.to Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=dama-to.20230601.gappssmtp.com header.i=@dama-to.20230601.gappssmtp.com header.b="o4uRYTK9" Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-8274843810cso1063618b3a.3 for ; Fri, 27 Feb 2026 11:04:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dama-to.20230601.gappssmtp.com; s=20230601; t=1772219089; x=1772823889; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=seXoHa8MttyanDQdn7I7ioBq+qRY17Mw0b5Mol0x4jI=; b=o4uRYTK91pxdLEsQ03ktEwRmtIKQCUAtyTP39KwH0McABvNGMdNkzXDNjpCuJCSLVW LrPOVJ94eH+4R7UOoMqrKO6UKiHcS3v+7fyPofiTHHJ4H3kzQzukSIcbMegKs18JiXCK joBmGbnI9pg6NU80U8g3OlLMJ8tlrHzVEniZzcZ+yA+Q824qsR9TQFJf2yJqGHNvhp6E weBKgGGj1dtr8CTALLOAEhUvSuCaMbMcxEjXOtXYLHMVHBXogyLkeCsp23fqhkU82eTO 3Mf8TYhACRW7m9B+tGfZT2vgov0bmAJuJpppwN7D8eLXFfpMhpvHoyV7u7NTLv9huXew YWsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772219089; x=1772823889; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=seXoHa8MttyanDQdn7I7ioBq+qRY17Mw0b5Mol0x4jI=; b=IQ6PmNMFckGxRVpbVE5FKW7bENffU6+DBMisfT7hBkq0O9Ch0KdePXbFDBbBjTY36e yX9+YTdBGNhNb40fVZs6tl0RPxQe4gKE1dnnhQV9+Gu6J534KXzjDb/7L9TDKF/Wm3Q2 7Xi5dyv9T3oA+GiOzfdedMqSMlL6FsLU7hQ88RNJlVPTAuUMVQW0MvcybI6XnY7+zn+w TRQvUqS89XGt8Hz6H1fsw3SV4Js5PrvPGFa5sbKitmA8ksFpp247efnkEwrYnWn4c8Mc uo62NDGw+iZhEPXTB5QjLlwYkQCF/NruWHgbSG/xwFcDeLvOdYrcmwnGjuCYnS7LYNle OFZQ== X-Forwarded-Encrypted: i=1; AJvYcCWltC87ZDHVwOSayNuKlQOCC5vTCD/K1YV6nCNQJgXyOFZcCurz00XPtD62N1vOZmUjpmtp5ao=@vger.kernel.org X-Gm-Message-State: AOJu0YzoZknZP+Os79C9HfgXsp34U7AdRpNL+GJhGbuNliYvVSbwe47x aoLZbvsF+lc0pohJH1tQAvVZdvcPzXoumWqYgU0qyzb2nwnXgToglDVrW/jMdB8bv88= X-Gm-Gg: ATEYQzwsrDkF47HnBYatXTVorKI+s5xKm/5z8o1iTaHUPw0LLkskmoKjAh8u2uG5gnx xHflNzvbMje0/Wupm6zPdTchkubFfAWehCd4IHB3xrhlqqIOSnE77y0NWyJ9yw7g9MedsxEz9g6 sdxHtm6nf63JzHognG3XbtpK6fIwCf/IZdPfqp1yii5VoSt1k19EZDPU9X3qngh7hKbBM3NNrZX eryn4/RGvGfarS8VHr9LM2kJu2LC4cYC6r9B2o9VB7b8/HqZLxH6IwrsQKPUF1c+M8U5YG7J15R UR6YLNlzkBGRAKdJ5q4Bds1Z4uwHoEMs+h2Y9Wpq56r1KCgCU6veZUkzbQOu+VnrxMHsbtc4LvJ Zo/iMcY9Ohd/rUzo/hrC8TnQSLMpJFUWkQAViOrZpfe5icPk50FO4033WF7sRjPo19JPmCxI2RN 3g2AA= X-Received: by 2002:a05:6a00:94c1:b0:823:1276:9a86 with SMTP id d2e1a72fcca58-8274d9ebcdcmr4188044b3a.39.1772219088702; Fri, 27 Feb 2026 11:04:48 -0800 (PST) Received: from localhost ([2a03:2880:2ff:9::]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82739d8c5bdsm5954955b3a.19.2026.02.27.11.04.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Feb 2026 11:04:48 -0800 (PST) Date: Fri, 27 Feb 2026 11:04:47 -0800 From: Joe Damato To: Chris J Arges Cc: michael.chan@broadcom.com, pavan.chebbi@broadcom.com, Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Stanislav Fomichev , kernel-team@cloudflare.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org Subject: Re: [PATCH net-next 2/4] bnxt_en: Implement XDP RSS hash metadata extraction Message-ID: Mail-Followup-To: Joe Damato , Chris J Arges , michael.chan@broadcom.com, pavan.chebbi@broadcom.com, Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Stanislav Fomichev , kernel-team@cloudflare.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org References: <7fe1e129215a789e55a446610321737aef10e20e.1772211065.git.carges@cloudflare.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7fe1e129215a789e55a446610321737aef10e20e.1772211065.git.carges@cloudflare.com> On Fri, Feb 27, 2026 at 11:40:18AM -0600, Chris J Arges wrote: > Add support for extracting RSS hash values and hash types from hardware > completion descriptors in XDP programs for bnxt_en. > > Add IP_TYPE definition for determining if completion is ipv4 or ipv6. In > addition add ITYPE_ICMP flag for identifying ICMP completions. > > Signed-off-by: Chris J Arges > --- > drivers/net/ethernet/broadcom/bnxt/bnxt.c | 5 ++ > drivers/net/ethernet/broadcom/bnxt/bnxt.h | 2 + > drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c | 47 +++++++++++++++++++ > drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.h | 3 ++ > 4 files changed, 57 insertions(+) [...] > diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c > index 85cbeb35681c..f75060374163 100644 > --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c > +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c > @@ -472,3 +472,50 @@ bnxt_xdp_build_skb(struct bnxt *bp, struct sk_buff *skb, u8 num_frags, > xdp_buff_get_skb_flags(xdp)); > return skb; > } > + > +int bnxt_xdp_rx_hash(const struct xdp_md *ctx, u32 *hash, > + enum xdp_rss_hash_type *rss_type) > +{ > + const struct bnxt_xdp_buff *xdp = (void *)ctx; > + const struct rx_cmp *rxcmp = xdp->rxcmp; > + const struct rx_cmp_ext *rxcmp1 = xdp->rxcmp1; > + u32 itypes; > + enum xdp_rss_hash_type hash_type = 0; Nit: This may need to be put into RCT style. (?) Everything else seemed OK to me... Reviewed-by: Joe Damato