From: Joe Damato <joe@dama.to>
To: Jiawen Wu <jiawenwu@trustnetic.com>
Cc: netdev@vger.kernel.org, Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
Mengyuan Lou <mengyuanlou@net-swift.com>
Subject: Re: [PATCH net-next v2 3/8] net: ngbe: improve the reset flow
Date: Fri, 27 Feb 2026 11:24:34 -0800 [thread overview]
Message-ID: <aaHvchv+ufkoQSNG@devvm20253.cco0.facebook.com> (raw)
In-Reply-To: <20260227073450.23680-4-jiawenwu@trustnetic.com>
On Fri, Feb 27, 2026 at 03:34:45PM +0800, Jiawen Wu wrote:
> Implement wx->do_reset() for ngbe driver, and improve the specific reset
> flow.
It might be better to more verbosely describe how the reset flow is improved,
to make it is easier for reviewers?
> Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>
> ---
> .../net/ethernet/wangxun/ngbe/ngbe_ethtool.c | 1 -
> drivers/net/ethernet/wangxun/ngbe/ngbe_main.c | 49 +++++++++++++++++--
> drivers/net/ethernet/wangxun/ngbe/ngbe_type.h | 1 +
> 3 files changed, 47 insertions(+), 4 deletions(-)
Reviewed-by: Joe Damato <joe@dama.to>
next prev parent reply other threads:[~2026-02-27 19:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-27 7:34 [PATCH net-next v2 0/8] Wangxun improvement and new support Jiawen Wu
2026-02-27 7:34 ` [PATCH net-next v2 1/8] net: ngbe: move the WOL functions to libwx Jiawen Wu
2026-02-27 7:34 ` [PATCH net-next v2 2/8] net: ngbe: remove redundant macros Jiawen Wu
2026-02-27 18:19 ` Joe Damato
2026-02-27 7:34 ` [PATCH net-next v2 3/8] net: ngbe: improve the reset flow Jiawen Wu
2026-02-27 19:24 ` Joe Damato [this message]
2026-02-27 7:34 ` [PATCH net-next v2 4/8] net: wangxun: move reusable PCI driver ops functions into libwx Jiawen Wu
2026-02-27 7:34 ` [PATCH net-next v2 5/8] net: txgbe: add power management support Jiawen Wu
2026-02-27 19:22 ` Joe Damato
2026-02-27 7:34 ` [PATCH net-next v2 6/8] net: wangxun: move ethtool_ops.set_channels into libwx Jiawen Wu
2026-02-27 7:34 ` [PATCH net-next v2 7/8] net: wangxun: add Tx timeout process Jiawen Wu
2026-02-28 21:12 ` [net-next,v2,7/8] " Jakub Kicinski
2026-02-27 7:34 ` [PATCH net-next v2 8/8] net: wangxun: implement pci_error_handlers ops Jiawen Wu
2026-02-28 21:13 ` Jakub Kicinski
2026-02-28 21:15 ` [PATCH net-next v2 0/8] Wangxun improvement and new support Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aaHvchv+ufkoQSNG@devvm20253.cco0.facebook.com \
--to=joe@dama.to \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jiawenwu@trustnetic.com \
--cc=kuba@kernel.org \
--cc=mengyuanlou@net-swift.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox